You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2018/11/30 12:30:21 UTC

[GitHub] wenfengwang commented on issue #4: [WIP] send orderly

wenfengwang commented on issue #4: [WIP] send orderly
URL: https://github.com/apache/rocketmq-client-go/pull/4#issuecomment-443189805
 
 
   I found vendor directory under the root path, and it just contains testify. IMO, testify only affect test code, we need not control version of it. if test case failed as upstream API changed, just fix it(incompatible API changed is very low frequency), which rather than use vendor to guarantee all test code work well, vendor make our codebase much heavier.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services