You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/05/06 13:02:48 UTC

[GitHub] [dolphinscheduler] SbloodyS commented on a diff in pull request #9917: [Feature-9177][Task] The sql task supports configuring segmentation notation to provide execution of multiple statements

SbloodyS commented on code in PR #9917:
URL: https://github.com/apache/dolphinscheduler/pull/9917#discussion_r866805630


##########
dolphinscheduler-ui/src/views/projects/task/components/node/tasks/use-sql.ts:
##########
@@ -46,6 +46,7 @@ export function useSql({
     timeout: 30,
     type: 'MYSQL',
     displayRows: 10,
+    segmentSeparator: '',

Review Comment:
   I think we should set a default value of semicolon to reduce repeated operations of users. What do you think?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org