You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/16 09:37:11 UTC
[GitHub] [pulsar] thetumbled opened a new issue, #17692: [Bug] ThresholdShedder calculate wrong percentOfTrafficToOffload
thetumbled opened a new issue, #17692:
URL: https://github.com/apache/pulsar/issues/17692
### Search before asking
- [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar.
### Version
pulsar 2.9.3
### Minimal reproduce step
org/apache/pulsar/broker/loadbalance/impl/ThresholdShedder.java:105
<img width="660" alt="image" src="https://user-images.githubusercontent.com/52550727/190605693-91dd452f-8bbc-4e1f-9c33-28d74fd41685.png">
the document says that load shedder will removing enough bundles to bring the unloaded broker 5% below the current average broker usage,but the implementation also minus the threshold.The correct implementation should be the following code?
```
double percentOfTrafficToOffload =
currentUsage - avgUsage + ADDITIONAL_THRESHOLD_PERCENT_MARGIN;
```
### What did you expect to see?
,
### What did you see instead?
,
### Anything else?
_No response_
### Are you willing to submit a PR?
- [X] I'm willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] thetumbled closed issue #17692: [Bug] ThresholdShedder calculate wrong percentOfTrafficToOffload
Posted by GitBox <gi...@apache.org>.
thetumbled closed issue #17692: [Bug] ThresholdShedder calculate wrong percentOfTrafficToOffload
URL: https://github.com/apache/pulsar/issues/17692
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on issue #17692: [Bug] ThresholdShedder calculate wrong percentOfTrafficToOffload
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #17692:
URL: https://github.com/apache/pulsar/issues/17692#issuecomment-1280179935
The issue had no activity for 30 days, mark with Stale label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org