You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "taepper (via GitHub)" <gi...@apache.org> on 2026/09/07 12:56:37 UTC
[PR] GH-51210: [C++] Initialize `output_` on empty `select_k` inputs [arrow]
taepper opened a new pull request, #51212:
URL: https://github.com/apache/arrow/pull/51212
### Rationale for this change
This fixes possible crashes of `SelectKUnstable` if inputs were empty
### What changes are included in this PR?
This includes the bug fix and test cases which cover the broken prior behavior.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
**This PR contains a "Critical Fix".**:
(c) a bug that causes a crash
If `SelectKUnstable` is called on an empty table or chunked-array the process terminates with the exception `std::bad_variant_access`.
Through python, the wrapping of the (invalid) Datum in a python object already fails with the following error message:
```
ValueError: Unable to wrap Datum in a Python object
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-51210: [C++] Initialize `output_` on empty `select_k` inputs [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #51212:
URL: https://github.com/apache/arrow/pull/51212#issuecomment-5664506803
Oops, sorry @taepper , I had forgotten to merge this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-51210: [C++] Initialize `output_` on empty `select_k` inputs [arrow]
Posted by "taepper (via GitHub)" <gi...@apache.org>.
taepper commented on PR #51212:
URL: https://github.com/apache/arrow/pull/51212#issuecomment-5664164733
bump
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-51210: [C++] Initialize `output_` on empty `select_k` inputs [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou merged PR #51212:
URL: https://github.com/apache/arrow/pull/51212
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org