You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Brian Wickman <wi...@apache.org> on 2014/08/04 22:44:56 UTC
Re: Review Request 23863: AURORA-587: Example ServerSet Announcer
implementation
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23863/#review49501
-----------------------------------------------------------
sorry for the radio silence on this -- vacation + other work. will send out an updated review once the e2e finishes.
- Brian Wickman
On July 24, 2014, 10:32 p.m., Brian Wickman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23863/
> -----------------------------------------------------------
>
> (Updated July 24, 2014, 10:32 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Bugs: AURORA-587
> https://issues.apache.org/jira/browse/AURORA-587
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This is an exemplar ServerSet Announcer implementation in apache.aurora.executor.common. Open to suggestions about wiring up -- right now it is enabled via command line flags, but we don't have prior art for invoking the executor with command line flags (I think the scheduler just takes -thermos_executor_path, which is fine if we promote the pattern of writing a thin shell wrapper around the executor.pex.) We can alternately switch to entry_points style a la AURORA-216 prior to submitting this, so that people just need to pip install as a plugin, but would require a separate review. Open to ideas.
>
>
> Diffs
> -----
>
> examples/vagrant/aurorabuild.sh 9f604d36cc083c3679d0c4c8821d74dca64a1805
> examples/vagrant/upstart/aurora-scheduler.conf 05b2f2662311cd4859bfe57df6eee7b431c474eb
> src/main/python/apache/aurora/executor/bin/BUILD 6b3f620a1d1b004c6be9965f6dceb7c8913a8e4c
> src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 198f2f6feb3782a98c3784297599ad218b54209e
> src/main/python/apache/aurora/executor/common/BUILD d0ff6fbf594663cd12ffb4b6d3f330e3a1ac123c
> src/main/python/apache/aurora/executor/common/announcer.py PRE-CREATION
> src/test/python/apache/aurora/executor/common/BUILD 8b54e910a671cde0265ade3155cb495c6314347b
> src/test/python/apache/aurora/executor/common/test_announcer.py PRE-CREATION
> src/test/sh/org/apache/aurora/e2e/http/http_example_updated.aurora dcf61033743317a51dd2f77e8d254c4781cb6a93
> src/test/sh/org/apache/aurora/e2e/test_common.sh def823b2f1f4bc67304221efa06e0e561d9bf521
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 9c5652829ac306dda5f7e95e164c85713e18988f
> src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh 2af256d65850bd861111279dff4b5c53f234cf7a
>
> Diff: https://reviews.apache.org/r/23863/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python/apache/aurora/executor/common:announcer -v
>
>
> Thanks,
>
> Brian Wickman
>
>