You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2025/05/11 05:09:01 UTC
[PR] GH-46304: [Release][Packaging] Use optimized debug build for .deb [arrow]
kou opened a new pull request, #46392:
URL: https://github.com/apache/arrow/pull/46392
### Rationale for this change
We want to get source line from back trace by `addr2line`. We can do it by with debug symbol.
### What changes are included in this PR?
Use `RelWithDebInfo`/`debugoptimized` instead of `Release`/`release`.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
Yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46304: [Release][Packaging] Use optimized debug build for .deb [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on code in PR #46392:
URL: https://github.com/apache/arrow/pull/46392#discussion_r2086189541
##########
dev/tasks/linux-packages/apache-arrow/debian/rules:
##########
@@ -88,19 +89,9 @@ override_dh_auto_install:
--sourcedirectory=c_glib \
--builddirectory=c_glib_build \
--buildsystem=meson+ninja
- # Remove built files to reduce disk usage
- dh_auto_clean \
Review Comment:
no worries at all! I was just wondering if it had anything to do that I might be missing!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46304: [Release][Packaging] Use optimized debug build for .deb [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #46392:
URL: https://github.com/apache/arrow/pull/46392#issuecomment-2869463756
@github-actions crossbow submit debian* ubuntu*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46304: [Release][Packaging] Use optimized debug build for .deb [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #46392:
URL: https://github.com/apache/arrow/pull/46392#discussion_r2085736596
##########
dev/tasks/linux-packages/apache-arrow/debian/rules:
##########
@@ -88,19 +89,9 @@ override_dh_auto_install:
--sourcedirectory=c_glib \
--builddirectory=c_glib_build \
--buildsystem=meson+ninja
- # Remove built files to reduce disk usage
- dh_auto_clean \
Review Comment:
The latter. Sorry for mixing unrelated changes...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46304: [Release][Packaging] Use optimized debug build for .deb [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #46392:
URL: https://github.com/apache/arrow/pull/46392#issuecomment-2869464432
Revision: 6c6e2e68c93f0d41bffb4714acb82ac14fdb2026
Submitted crossbow builds: [ursacomputing/crossbow @ actions-14598d46dd](https://github.com/ursacomputing/crossbow/branches/all?query=actions-14598d46dd)
|Task|Status|
|----|------|
|debian-bookworm-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14952567206/job/42003996975)|
|debian-bookworm-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14952567207/job/42003996960)|
|debian-trixie-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14952567091/job/42003996689)|
|debian-trixie-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14952567075/job/42003996679)|
|ubuntu-jammy-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14952567275/job/42003997147)|
|ubuntu-jammy-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14952567107/job/42003996690)|
|ubuntu-noble-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14952567146/job/42003996875)|
|ubuntu-noble-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/14952567217/job/42003996983)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46304: [Release][Packaging] Use optimized debug build for .deb [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd merged PR #46392:
URL: https://github.com/apache/arrow/pull/46392
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46304: [Release][Packaging] Use optimized debug build for .deb [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #46392:
URL: https://github.com/apache/arrow/pull/46392#issuecomment-2876901914
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit e7ccca6917be3bf8be9c25e35bd6b2459e69be0b.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/42144482454) has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46304: [Release][Packaging] Use optimized debug build for .deb [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on code in PR #46392:
URL: https://github.com/apache/arrow/pull/46392#discussion_r2084091557
##########
dev/tasks/linux-packages/apache-arrow/debian/rules:
##########
@@ -88,19 +89,9 @@ override_dh_auto_install:
--sourcedirectory=c_glib \
--builddirectory=c_glib_build \
--buildsystem=meson+ninja
- # Remove built files to reduce disk usage
- dh_auto_clean \
Review Comment:
just a question, is this removal of `dh_auto_clean` required because it was removing some required debug symbols or something like this? or is just unrelated to the other change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46304: [Release][Packaging] Use optimized debug build for .deb [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #46392:
URL: https://github.com/apache/arrow/pull/46392#issuecomment-2869463832
:warning: GitHub issue #46304 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org