You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/01/07 07:40:25 UTC
[GitHub] [spark] yoda-mon commented on pull request #34896: [SPARK-37568][SQL] Support 2-arguments by the convert_timezone() function
yoda-mon commented on pull request #34896:
URL: https://github.com/apache/spark/pull/34896#issuecomment-1007202017
@MaxGekk
Sorry for the delayed response, I tried to follow your advice.
However at
```
def this(targetTz: Expression, sourceTs: Expression) =
this(Literal("UTC"), targetTz, sourceTs)
```
`sourceTz` is not ignored. After the constructor I could use `timeZoneId` as`sourceTz` that copied by the mix-in, but in that case, it's difficult to distinguish `TimeStampLTZ` and `TimeStampNTZ`.
Please let me know if there is something I missed to use the mix-in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org