You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2020/08/07 00:02:42 UTC

[GitHub] [incubator-yunikorn-k8shim] ayubpathan commented on a change in pull request #173: [YUNIKORN-345] Add Travis job matrix to cover different K8s versions in e2e test

ayubpathan commented on a change in pull request #173:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/173#discussion_r466742915



##########
File path: .travis.yml
##########
@@ -53,13 +48,22 @@ jobs:
         on:
           branch: master
           condition: $TRAVIS_EVENT_TYPE = cron
-    - stage: integration tests
-      install:
-        - go get -v github.com/onsi/ginkgo/ginkgo
-        - go get -v github.com/onsi/gomega
-        - go get -v -t ./...
-        - export PATH=$PATH:$HOME/gopath/bin
-      script:
-        - ./scripts/run-e2e-tests.sh -a "test" -n ${CLUSTER_NAME} -v ${KIND_NODE_IMAGE}
-      after_script:
-        - ./scripts/run-e2e-tests.sh -a "cleanup" -n ${CLUSTER_NAME}
+    - stage: e2e tests

Review comment:
       can these stages be renamed as per the k8s versions..
   For example: e2e tests against v1.14 k8s 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org