You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/10/25 23:16:13 UTC
[GitHub] [ozone] swamirishi opened a new pull request, #3887: HDDS-7413. Fix logging while marking container state unhealthy
swamirishi opened a new pull request, #3887:
URL: https://github.com/apache/ozone/pull/3887
## What changes were proposed in this pull request?
Currently the logging shows the new state as the previous state after setting the state as UNHEALTHY. We need to fix the logging to show the previous state of the container.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7413
## How was this patch tested?
Logging Changes, no testing required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kaijchen merged pull request #3887: HDDS-7413. Fix logging while marking container state unhealthy
Posted by GitBox <gi...@apache.org>.
kaijchen merged PR #3887:
URL: https://github.com/apache/ozone/pull/3887
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #3887: HDDS-7413. Fix logging while marking container state unhealthy
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on PR #3887:
URL: https://github.com/apache/ozone/pull/3887#issuecomment-1291623450
Thanks @swamirishi for the fix, @kaijchen for the review.
> ## How was this patch tested?
> Logging Changes, no testing required.
Instead of saying "no testing required", I think including log excerpt from both old and new versions in the PR would be useful in this case. Getting the container to unhealthy might also require some steps. Excerpt from old, wrong version is useful in the Jira issue when the bug is reported. This helps reviewers, and anyone searching for the bug (e.g. for potential fix to backport).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org