You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by pratik pandey <pr...@gmail.com> on 2017/09/22 07:29:52 UTC
Review Request 62493: ATLAS-2162 : Add hyperlink for URI formatted
attribute value on property table
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62493/
-----------------------------------------------------------
Review request for atlas, Apoorv Naik, keval bhatt, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
Bugs: ATLAS-2162
https://issues.apache.org/jira/browse/ATLAS-2162
Repository: atlas
Description
-------
Show hyperlink in property table of entity detail page when string having valid URL format.
Diffs
-----
dashboardv2/public/css/scss/theme.scss dc56148
dashboardv2/public/js/utils/CommonViewFunction.js 0fa8506
dashboardv2/public/js/utils/Utils.js 0e2b489
Diff: https://reviews.apache.org/r/62493/diff/1/
Testing
-------
Tested with URL string table rendering as url.
Thanks,
pratik pandey
Re: Review Request 62493: ATLAS-2162 : Add hyperlink for URI formatted
attribute value on property table
Posted by Ashutosh Mestry <am...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62493/#review185999
-----------------------------------------------------------
dashboardv2/public/js/utils/CommonViewFunction.js
Line 220 (original), 228 (patched)
<https://reviews.apache.org/r/62493/#comment262343>
Generally speaking, composing tags manually is not a best practice.
dashboardv2/public/js/utils/Utils.js
Lines 647 (patched)
<https://reviews.apache.org/r/62493/#comment262344>
Is possible to move this to a global place, so that this does not get created and initializd each time.
- Ashutosh Mestry
On Sept. 22, 2017, 7:29 a.m., pratik pandey wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62493/
> -----------------------------------------------------------
>
> (Updated Sept. 22, 2017, 7:29 a.m.)
>
>
> Review request for atlas, Apoorv Naik, keval bhatt, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-2162
> https://issues.apache.org/jira/browse/ATLAS-2162
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Show hyperlink in property table of entity detail page when string having valid URL format.
>
>
> Diffs
> -----
>
> dashboardv2/public/css/scss/theme.scss dc56148
> dashboardv2/public/js/utils/CommonViewFunction.js 0fa8506
> dashboardv2/public/js/utils/Utils.js 0e2b489
>
>
> Diff: https://reviews.apache.org/r/62493/diff/1/
>
>
> Testing
> -------
>
> Tested with URL string table rendering as url.
>
>
> Thanks,
>
> pratik pandey
>
>
Re: Review Request 62493: ATLAS-2162 : Add hyperlink for URI formatted
attribute value on property table
Posted by Nixon Rodrigues <ni...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62493/#review185985
-----------------------------------------------------------
Ship it!
Ship It!
- Nixon Rodrigues
On Sept. 22, 2017, 7:29 a.m., pratik pandey wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62493/
> -----------------------------------------------------------
>
> (Updated Sept. 22, 2017, 7:29 a.m.)
>
>
> Review request for atlas, Apoorv Naik, keval bhatt, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-2162
> https://issues.apache.org/jira/browse/ATLAS-2162
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Show hyperlink in property table of entity detail page when string having valid URL format.
>
>
> Diffs
> -----
>
> dashboardv2/public/css/scss/theme.scss dc56148
> dashboardv2/public/js/utils/CommonViewFunction.js 0fa8506
> dashboardv2/public/js/utils/Utils.js 0e2b489
>
>
> Diff: https://reviews.apache.org/r/62493/diff/1/
>
>
> Testing
> -------
>
> Tested with URL string table rendering as url.
>
>
> Thanks,
>
> pratik pandey
>
>