You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Abraham Elmahrek <ab...@cloudera.com> on 2014/07/25 22:20:43 UTC
Review Request 23947: Sqoop: From/To: Repository changes
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23947/
-----------------------------------------------------------
Review request for Sqoop.
Bugs: SQOOP-1376
https://issues.apache.org/jira/browse/SQOOP-1376
Repository: sqoop-sqoop2
Description
-------
The repository was hacked together in order to get the rest of Sqoop working. The most important modifications are the changes to how SQ_OPERATION is being used and how Job forms are being queried.
Diffs
-----
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 5bce3a9
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java fcbb475
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java 7042a53
Diff: https://reviews.apache.org/r/23947/diff/
Testing
-------
N/A
Thanks,
Abraham Elmahrek
Re: Review Request 23947: Sqoop: From/To: Repository changes
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23947/#review49842
-----------------------------------------------------------
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
<https://reviews.apache.org/r/23947/#comment87233>
I don't see the return value used anywhere? Fine to follow-up in separate JIRA.
Jarcec
- Jarek Cecho
On July 25, 2014, 8:20 p.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23947/
> -----------------------------------------------------------
>
> (Updated July 25, 2014, 8:20 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1376
> https://issues.apache.org/jira/browse/SQOOP-1376
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> The repository was hacked together in order to get the rest of Sqoop working. The most important modifications are the changes to how SQ_OPERATION is being used and how Job forms are being queried.
>
>
> Diffs
> -----
>
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 5bce3a9
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java fcbb475
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java 7042a53
>
> Diff: https://reviews.apache.org/r/23947/diff/
>
>
> Testing
> -------
>
> N/A
>
>
> Thanks,
>
> Abraham Elmahrek
>
>