You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "splett2 (via GitHub)" <gi...@apache.org> on 2023/05/17 16:34:05 UTC

[GitHub] [kafka] splett2 opened a new pull request, #13727: MINOR: Rename handleSnapshot to handleLoadSnapshot

splett2 opened a new pull request, #13727:
URL: https://github.com/apache/kafka/pull/13727

   This PR tries to make it explicit that `handleSnapshot` is handling the loading of a snapshot. To someone who is not familiar with the code or KRaft's design, `handleSnapshot` may sound like the event is a snapshot event, whereas it is really a snapshot loading event.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] cmccabe commented on pull request #13727: MINOR: Rename handleSnapshot to handleLoadSnapshot

Posted by "cmccabe (via GitHub)" <gi...@apache.org>.
cmccabe commented on PR #13727:
URL: https://github.com/apache/kafka/pull/13727#issuecomment-1551766740

   merged, thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] cmccabe closed pull request #13727: MINOR: Rename handleSnapshot to handleLoadSnapshot

Posted by "cmccabe (via GitHub)" <gi...@apache.org>.
cmccabe closed pull request #13727: MINOR: Rename handleSnapshot to handleLoadSnapshot
URL: https://github.com/apache/kafka/pull/13727


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org