You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/03/05 08:57:20 UTC

[GitHub] [hudi] cuibo01 commented on a change in pull request #4880: [HUDI-2752] The MOR DELETE block breaks the event time sequence of CDC

cuibo01 commented on a change in pull request #4880:
URL: https://github.com/apache/hudi/pull/4880#discussion_r820070818



##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieAppendHandle.java
##########
@@ -475,12 +475,12 @@ private void writeToBuffer(HoodieRecord<T> record) {
     }
     Option<IndexedRecord> indexedRecord = getIndexedRecord(record);
     if (indexedRecord.isPresent()) {
-      // Skip the Ignore Record.
+      // Skip the ignored record.
       if (!indexedRecord.get().equals(IGNORE_RECORD)) {
         recordList.add(indexedRecord.get());
       }
     } else {
-      keysToDelete.add(record.getKey());
+      keysToDelete.add(DeleteKey.create(record.getKey(), record.getData().getOrderingVal()));
     }

Review comment:
       >I have no good idea how to be compatible yet.
   
   How to Resolve Data Compatibility 
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org