[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #7665: [WiP] [api] [database] New, migrate to new FAB API side by side

[GitBox <gi...@apache.org>]

mistercrunch commented on a change in pull request #7665: [WiP] [api] [database] New, migrate to new FAB API side by side
URL: https://github.com/apache/incubator-superset/pull/7665#discussion_r299135955
 
 

 ##########
 File path: superset/views/database/forms.py
 ##########
 @@ -0,0 +1,200 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+# pylint: disable=C,R,W
+"""Contains the logic to create cohesive forms on the explore view"""
+from flask_appbuilder.fieldwidgets import BS3TextFieldWidget
+from flask_appbuilder.forms import DynamicForm
+from flask_babel import lazy_gettext as _
+from flask_wtf.file import FileAllowed, FileField, FileRequired
+from wtforms import BooleanField, IntegerField, SelectField, StringField
+from wtforms.ext.sqlalchemy.fields import QuerySelectField
+from wtforms.validators import DataRequired, Length, NumberRange, Optional
+
+from superset import app, db, security_manager
+from superset.forms import CommaSeparatedListField, filter_not_empty_values
+from superset.models import core as models
+
+config = app.config
+
+
+class CsvToDatabaseForm(DynamicForm):
 
 Review comment:
   I'm not sure if that belongs under here in `views/database/...`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org