You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/02/20 04:59:48 UTC

[GitHub] [incubator-shardingsphere] ppourali opened a new issue #4379: use of SPI to extend/modify statement executor (executeQuery)

ppourali opened a new issue #4379: use of SPI to extend/modify statement executor (executeQuery)
URL: https://github.com/apache/incubator-shardingsphere/issues/4379
 
 
   Hi,
   
   I was wondering if there is a good way to modify the implementation of the statement executor function (i.e., executeQuery function) like SPI. I can see that the encryption datasource and sharding datasource provide different implementations of the executeQuery function defined in EncryptStatment class and ShardingStatement class. So, should I provide SPI for each of these classes to modify their behavior?
   
   Thanks,
   Parsa

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] ppourali commented on issue #4379: use of SPI to extend/modify statement executor (executeQuery)

Posted by GitBox <gi...@apache.org>.
ppourali commented on issue #4379: use of SPI to extend/modify statement executor (executeQuery)
URL: https://github.com/apache/incubator-shardingsphere/issues/4379#issuecomment-591026183
 
 
   Thanks for the reply, so, what do you suggest if we want to customize only one class in the sharding-proxy project? Let's say we want to extend/customize a small portion of ProxySQLExecuteCallback class.
   
   Regards,
   Parsa

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #4379: use of SPI to extend/modify statement executor (executeQuery)

Posted by GitBox <gi...@apache.org>.
terrymanu commented on issue #4379: use of SPI to extend/modify statement executor (executeQuery)
URL: https://github.com/apache/incubator-shardingsphere/issues/4379#issuecomment-596180300
 
 
   Because they are still refactoring now, so I cannot guarantee how to use it now.
   Maybe we can talk about this after 2 month. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [shardingsphere] RaigorJiang closed issue #4379: use of SPI to extend/modify statement executor (executeQuery)

Posted by GitBox <gi...@apache.org>.
RaigorJiang closed issue #4379:
URL: https://github.com/apache/shardingsphere/issues/4379


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] RaigorJiang commented on issue #4379: use of SPI to extend/modify statement executor (executeQuery)

Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on issue #4379:
URL: https://github.com/apache/shardingsphere/issues/4379#issuecomment-926544606


   Since this issue has been inactive for more than 1 year, we will close it. 
   If you still have related questions, please submit a new issue, thank you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #4379: use of SPI to extend/modify statement executor (executeQuery)

Posted by GitBox <gi...@apache.org>.
terrymanu commented on issue #4379: use of SPI to extend/modify statement executor (executeQuery)
URL: https://github.com/apache/incubator-shardingsphere/issues/4379#issuecomment-589508283
 
 
   Thank you for provide the good idea. Actually, we have already to plan to a pluggable architecture, the discussion mail is https://lists.apache.org/thread.html/77afaffc7a9da81d2bb08a8f0bf6601530ecc751dbd732dc666c2eb6%40%3Cdev.shardingsphere.apache.org%3E
   
   It maybe spend 2-3 month to finish it. The pluggable architecture use SPI to implement pluggable, it should include executor.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services