You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2020/01/17 15:16:02 UTC
[GitHub] [openwhisk] sciabarra opened a new pull request #4801: add
standalone to dockerhub
sciabarra opened a new pull request #4801: add standalone to dockerhub
URL: https://github.com/apache/openwhisk/pull/4801
<!--- Provide a concise summary of your changes in the Title -->
## Description
<!--- Provide a detailed description of your changes. -->
<!--- Include details of what problem you are solving and how your changes are tested. -->
Add the standalone docker image to docker hub
## Related issue and scope
<!--- Please include a link to a related issue if there is one. -->
- [ ] I opened an issue to propose and discuss this change (#????)
## My changes affect the following components
<!--- Select below all system components are affected by your change. -->
<!--- Enter an `x` in all applicable boxes. -->
- [ ] API
- [ ] Controller
- [ ] Message Bus (e.g., Kafka)
- [ ] Loadbalancer
- [ ] Invoker
- [ ] Intrinsic actions (e.g., sequences, conductors)
- [ ] Data stores (e.g., CouchDB)
- [ ] Tests
- [x] Deployment
- [ ] CLI
- [ ] General tooling
- [ ] Documentation
## Types of changes
<!--- What types of changes does your code introduce? Use `x` in all the boxes that apply: -->
- [ ] Bug fix (generally a non-breaking change which closes an issue).
- [x] Enhancement or new feature (adds new functionality).
- [ ] Breaking change (a bug fix or enhancement which changes existing behavior).
## Checklist:
<!--- Please review the points below which help you make sure you've covered all aspects of the change you're making. -->
- [x] I signed an [Apache CLA](https://github.com/apache/openwhisk/blob/master/CONTRIBUTING.md).
- [ ] I reviewed the [style guides](https://github.com/apache/openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :).
- [ ] I added tests to cover my changes.
- [ ] My changes require further changes to the documentation.
- [ ] I updated the documentation where necessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] dgrove-oss commented on issue #4801: add standalone to
dockerhub
Posted by GitBox <gi...@apache.org>.
dgrove-oss commented on issue #4801: add standalone to dockerhub
URL: https://github.com/apache/openwhisk/pull/4801#issuecomment-575792766
confirming that it worked as expected. openwhisk/standalone:nightly is available on dockerhub
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] sciabarracom merged pull request #4801: add standalone
to dockerhub
Posted by GitBox <gi...@apache.org>.
sciabarracom merged pull request #4801: add standalone to dockerhub
URL: https://github.com/apache/openwhisk/pull/4801
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] mcdan commented on issue #4801: add standalone to
dockerhub
Posted by GitBox <gi...@apache.org>.
mcdan commented on issue #4801: add standalone to dockerhub
URL: https://github.com/apache/openwhisk/pull/4801#issuecomment-575668895
How do we feel about the image name: https://github.com/apache/openwhisk/blob/master/core/standalone/build.gradle#L28 `standalone`?
Should we update the docs to use this as the "quickstart" seeing as it's a lot quicker?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] dgrove-oss commented on issue #4801: add standalone to
dockerhub
Posted by GitBox <gi...@apache.org>.
dgrove-oss commented on issue #4801: add standalone to dockerhub
URL: https://github.com/apache/openwhisk/pull/4801#issuecomment-575685928
No strong opinion in the image name. Since the jar file, configuration, etc. are also called standalone it seems plausible to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] chetanmeh commented on issue #4801: add standalone to
dockerhub
Posted by GitBox <gi...@apache.org>.
chetanmeh commented on issue #4801: add standalone to dockerhub
URL: https://github.com/apache/openwhisk/pull/4801#issuecomment-575685422
> Should we update the docs to use this as the "quickstart" seeing as it's a lot quicker?
I thought using that later but then thought it gives a feeling that this can be used as a quickstart for actual usage. So used convention used by [Spark Standalone](https://spark.apache.org/docs/latest/spark-standalone.html). But if people think we can change it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] sciabarra commented on issue #4801: add standalone to
dockerhub
Posted by GitBox <gi...@apache.org>.
sciabarra commented on issue #4801: add standalone to dockerhub
URL: https://github.com/apache/openwhisk/pull/4801#issuecomment-575717802
I prefer standalone for consistency with the others
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services