You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/03/21 08:07:04 UTC

[GitHub] [airflow] sagmansercan commented on pull request #22389: make operator's execution_timeout configurable

sagmansercan commented on pull request #22389:
URL: https://github.com/apache/airflow/pull/22389#issuecomment-1073576408


   > Since it is possible to provide a _None_ `execution_timeout`, the config format also need to support that.
   
   Thanks for the comment, could you provide more details on your suggestion with an example use case?
   
   The default behavior is already `None`.  One can leave this section key empty, or even not define it in its cfg file. This approach tries to cover the "providing None" case with an empty value.
   
   Are you suggesting that the string "None" should also be handled? If so, It would be great to hear what is the difference between "empty string" and "None" is, based on use cases. Additionally, how can we achieve that without explicitly checking if the given string is equal to "None". Also `eval` does this, but either way both of them do not sound right to me.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org