[jira] [Commented] (LOG4J2-2351) AbstractLogEvent.instant should be exposed for mutation

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LOG4J2-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16511035#comment-16511035 ] 

ASF GitHub Bot commented on LOG4J2-2351:
----------------------------------------

Github user cakofony commented on the issue:

    https://github.com/apache/logging-log4j2/pull/180
  
    merged


> AbstractLogEvent.instant should be exposed for mutation
> -------------------------------------------------------
>
>                 Key: LOG4J2-2351
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-2351
>             Project: Log4j 2
>          Issue Type: Improvement
>    Affects Versions: 2.11.0, 3.0.0
>            Reporter: Carter Kozak
>            Assignee: Carter Kozak
>            Priority: Trivial
>             Fix For: 3.0.0, 2.11.1
>
>
> Extending AbstractLogEvent there is currently no way to mutate the instant without casting the return value of "getInstant()".
> By making instant protected, classes extending AbstractLogEvent can avoid creating a second Instant implementation in addition to the default.
> Alternatively, we can use a static constant immutable instant, and return that form getInstant by default. This would break any consumers that cast getInstant to a MutableInstant.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)