You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by tzulitai <gi...@git.apache.org> on 2017/06/27 08:43:58 UTC
[GitHub] flink pull request #4191: [FLINK-6867] [elasticsearch] Fix instable Elastics...
GitHub user tzulitai opened a pull request:
https://github.com/apache/flink/pull/4191
[FLINK-6867] [elasticsearch] Fix instable Elasticsearch 1.x ITCases
The root cause for the instability in ES 1.x is that we're testing both embedded client mode and transport client mode against the same Elasticsearch environment. This PR ignores the embedded mode testing, as that method is generally discouraged anyways.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tzulitai/flink FLINK-6867
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4191.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4191
----
commit ee09a7b99adbbadec584c5df1297139303f0c604
Author: Tzu-Li (Gordon) Tai <tz...@apache.org>
Date: 2017-06-27T08:40:51Z
[FLINK-6867] [elasticsearch] Fix instable Elasticsearch 1.x ITCases
The root cause for the instability in ES 1.x is that we're testing both
embedded client mode and transport client mode against the same
Elasticsearch environment. This commit ignores the embedded mode
testing, as that method is generally discouraged anyways.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4191: [FLINK-6867] [elasticsearch] Fix instable Elastics...
Posted by tzulitai <gi...@git.apache.org>.
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/4191#discussion_r124284249
--- Diff: flink-connectors/flink-connector-elasticsearch/src/test/java/org/apache/flink/streaming/connectors/elasticsearch/ElasticsearchSinkITCase.java ---
@@ -67,7 +68,11 @@ public void testTransportClientFails() throws Exception{
/**
* Tests that the Elasticsearch sink works properly using an embedded node to connect to Elasticsearch.
+ *
+ * NOTE: This is ignored, since executing both embedded client mode and transport client mode introduces
+ * instability for node discovery in ES 1.x. See FLINK-6867.
*/
+ @Ignore
--- End diff --
I would not expect it to be enabled again, at least for the Travis runs.
At the rate of the new Elasticsearch versions (there's already a 6.x now), we might also consider dropping 1.x support soon.
Makes sense, will remove it completely :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4191: [FLINK-6867] [elasticsearch] Fix instable Elastics...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4191
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4191: [FLINK-6867] [elasticsearch] Fix instable Elasticsearch 1...
Posted by tzulitai <gi...@git.apache.org>.
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/4191
Merging once Travis gives green.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4191: [FLINK-6867] [elasticsearch] Fix instable Elastics...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4191#discussion_r124260908
--- Diff: flink-connectors/flink-connector-elasticsearch/src/test/java/org/apache/flink/streaming/connectors/elasticsearch/ElasticsearchSinkITCase.java ---
@@ -67,7 +68,11 @@ public void testTransportClientFails() throws Exception{
/**
* Tests that the Elasticsearch sink works properly using an embedded node to connect to Elasticsearch.
+ *
+ * NOTE: This is ignored, since executing both embedded client mode and transport client mode introduces
+ * instability for node discovery in ES 1.x. See FLINK-6867.
*/
+ @Ignore
--- End diff --
that would also resolve the checkstyle violation :P
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4191: [FLINK-6867] [elasticsearch] Fix instable Elastics...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4191#discussion_r124260636
--- Diff: flink-connectors/flink-connector-elasticsearch/src/test/java/org/apache/flink/streaming/connectors/elasticsearch/ElasticsearchSinkITCase.java ---
@@ -67,7 +68,11 @@ public void testTransportClientFails() throws Exception{
/**
* Tests that the Elasticsearch sink works properly using an embedded node to connect to Elasticsearch.
+ *
+ * NOTE: This is ignored, since executing both embedded client mode and transport client mode introduces
+ * instability for node discovery in ES 1.x. See FLINK-6867.
*/
+ @Ignore
--- End diff --
Do we expect to ever enable this test again? if not, let's just remove it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---