You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by Noble Paul നോബിള് नोब्ळ् <no...@gmail.com> on 2008/12/14 18:51:04 UTC
Re: svn commit: r726504 - /lucene/solr/trunk/src/java/org/apache/solr/handler/SnapPuller.java
this may not be necessary. I did not store the Pattern object with a purpose
On Sun, Dec 14, 2008 at 11:16 PM, <sh...@apache.org> wrote:
> Author: shalin
> Date: Sun Dec 14 09:46:21 2008
> New Revision: 726504
>
> URL: http://svn.apache.org/viewvc?rev=726504&view=rev
> Log:
> SOLR-913 -- Expensive Pattern object made static in SnapPuller
>
> Modified:
> lucene/solr/trunk/src/java/org/apache/solr/handler/SnapPuller.java
>
> Modified: lucene/solr/trunk/src/java/org/apache/solr/handler/SnapPuller.java
> URL: http://svn.apache.org/viewvc/lucene/solr/trunk/src/java/org/apache/solr/handler/SnapPuller.java?rev=726504&r1=726503&r2=726504&view=diff
> ==============================================================================
> --- lucene/solr/trunk/src/java/org/apache/solr/handler/SnapPuller.java (original)
> +++ lucene/solr/trunk/src/java/org/apache/solr/handler/SnapPuller.java Sun Dec 14 09:46:21 2008
> @@ -947,12 +947,11 @@
> }
>
> static Integer readInterval(String interval) {
> - Pattern pattern = Pattern.compile(INTERVAL_PATTERN);
> if (interval == null)
> return null;
> int result = 0;
> if (interval != null) {
> - Matcher m = pattern.matcher(interval.trim());
> + Matcher m = INTERVAL_PATTERN.matcher(interval.trim());
> if (m.find()) {
> String hr = m.group(1);
> String min = m.group(2);
> @@ -1004,5 +1003,5 @@
>
> public static final String INTERVAL_ERR_MSG = "The " + POLL_INTERVAL + " must be in this format 'HH:mm:ss'";
>
> - private static final String INTERVAL_PATTERN = "(\\d*?):(\\d*?):(\\d*)";
> + private static final Pattern INTERVAL_PATTERN = Pattern.compile("(\\d*?):(\\d*?):(\\d*)");
> }
>
>
>
--
--Noble Paul