[GitHub] [jena] afs commented on pull request #988: [JENA-2096] Added ability to delete old DB after compaction has completed successfully

[GitBox <gi...@apache.org>]

afs commented on pull request #988:
URL: https://github.com/apache/jena/pull/988#issuecomment-828611307


   I don't see any test for compact+delete=true/false for Fuseki.
   
   There are exceptions when running the test suite left over from the previosu PR. There are changes on main to fix some of them 
   a4346e6493 : `jena-fuseki-main/testing/FusekiEmbedded/tdb2-config.ttl` and 927b137bcd test `compact_01`.
   (so please rebase).
   
   `TestConfigFile.serverTDB2` is still throwing an exception. The compact there can simply be removed and a test for compact in Fuseki provided separately, which run compact both with and without delete=true and tests the Fuseki disk state. (All in one test means only one new database created.) 
   
   The compact/delete-true case can be skipped for Windows.
   
   The problem is that the tests have a memory TDB2 database and that does not provide compact. Compact is a disk-based operation.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org