You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2023/04/01 15:45:37 UTC
[GitHub] [arrow] kou opened a new pull request, #34838: GH-34837: [GLib][Ruby] Add Arrow::{Sparse,Dense}UnionArray#get_value
kou opened a new pull request, #34838:
URL: https://github.com/apache/arrow/pull/34838
### Rationale for this change
They are missing.
### What changes are included in this PR?
The following GLib APIs are added for them:
* `garrow_union_array_get_type_code()`
* `garrow_union_array_get_child_id()`
* `garrow_dense_union_array_get_value_offset()`
`Arrow::{Sparse,Dense}UnionArray#{to_records,values}` have a backward incompatible change:
* Don't include field name:
* Before: `{"field_name" => value}`
* After: `value`
Because I think that `"field_name"` is useless for many cases. Only `value` is suitable for many cases.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
Yes.
**This PR includes breaking changes to public APIs.**
See the above description for details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34838: GH-34837: [GLib][Ruby] Add Arrow::{Sparse,Dense}UnionArray#get_value
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34838:
URL: https://github.com/apache/arrow/pull/34838#issuecomment-1493013885
* Closes: #34837
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #34838: GH-34837: [GLib][Ruby] Add Arrow::{Sparse,Dense}UnionArray#get_value
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #34838:
URL: https://github.com/apache/arrow/pull/34838#issuecomment-1493378839
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou merged pull request #34838: GH-34837: [GLib][Ruby] Add Arrow::{Sparse,Dense}UnionArray#get_value
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #34838:
URL: https://github.com/apache/arrow/pull/34838
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #34838: GH-34837: [GLib][Ruby] Add Arrow::{Sparse,Dense}UnionArray#get_value
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #34838:
URL: https://github.com/apache/arrow/pull/34838#issuecomment-1493417360
Benchmark runs are scheduled for baseline = adf33cc430101d1d6878b546e1473431ca5f280c and contender = 67fbca9e565f7ba8deb5767238c2c703cd7406c1. 67fbca9e565f7ba8deb5767238c2c703cd7406c1 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/471ee85796624f41af719768d251f27f...cf7edfcf21184c728a634b0ac012a5cb/)
[Failed :arrow_down:0.56% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/a9cddf869a95411596971f4c16108778...26e663b23ac44060961b06f4819c3d94/)
[Finished :arrow_down:0.77% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/03951db5cf15400fa15709f2f1181af1...7373d247568b471aae4718e16fa32b2f/)
[Failed :arrow_down:0.0% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/505e9df739694f739ca01bdf2915ecb8...0189f674c5754261a13b64f8c6934506/)
Buildkite builds:
[Finished] [`67fbca9e` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2613)
[Failed] [`67fbca9e` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2644)
[Finished] [`67fbca9e` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2611)
[Failed] [`67fbca9e` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2635)
[Finished] [`adf33cc4` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2612)
[Failed] [`adf33cc4` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2643)
[Finished] [`adf33cc4` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2610)
[Failed] [`adf33cc4` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2634)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34838: GH-34837: [GLib][Ruby] Add Arrow::{Sparse,Dense}UnionArray#get_value
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34838:
URL: https://github.com/apache/arrow/pull/34838#issuecomment-1493013895
:warning: GitHub issue #34837 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #34838: GH-34837: [GLib][Ruby] Add Arrow::{Sparse,Dense}UnionArray#get_value
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #34838:
URL: https://github.com/apache/arrow/pull/34838#issuecomment-1493417425
['Python', 'R'] benchmarks have high level of regressions.
[test-mac-arm](https://conbench.ursa.dev/compare/runs/a9cddf869a95411596971f4c16108778...26e663b23ac44060961b06f4819c3d94/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org