You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@parquet.apache.org by "Fokko (via GitHub)" <gi...@apache.org> on 2023/04/13 14:18:34 UTC

[GitHub] [parquet-format] Fokko opened a new pull request, #199: PARQUET-2270: Bump Thrift to 0.18.1

Fokko opened a new pull request, #199:
URL: https://github.com/apache/parquet-format/pull/199

   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [Parquet Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references them in the PR title. For example, "PARQUET-1234: My Parquet PR"
     - https://issues.apache.org/jira/browse/PARQUET-XXX
     - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain Javadoc that explain what it does
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [parquet-format] wgtmac commented on pull request #199: PARQUET-2270: Bump Thrift to 0.18.1

Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac commented on PR #199:
URL: https://github.com/apache/parquet-format/pull/199#issuecomment-1507818861

   Could you please make the CI happy?
   
   ```
   =================================================================================
   ========== [FATAL] Build is configured to require Thrift version 0.18.1 ==========
   ========== Currently installed: Thrift version 0.14.1
   =================================================================================
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [parquet-format] Fokko closed pull request #199: PARQUET-2270: Bump Thrift to 0.18.1

Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko closed pull request #199: PARQUET-2270: Bump Thrift to 0.18.1
URL: https://github.com/apache/parquet-format/pull/199


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [parquet-format] Fokko commented on pull request #199: PARQUET-2270: Bump Thrift to 0.18.1

Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on PR #199:
URL: https://github.com/apache/parquet-format/pull/199#issuecomment-1513758137

   This would require dropping Java 8: https://github.com/apache/thrift/pull/2785


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org