You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2021/02/03 23:51:44 UTC
[GitHub] [bookkeeper] dlg99 opened a new pull request #2582: Upgrading GRPC version
dlg99 opened a new pull request #2582:
URL: https://github.com/apache/bookkeeper/pull/2582
Descriptions of the changes in this PR:
upgraded GRPC
Will need to upgrade GRPC in pulsar as well
### Motivation
TableService stopped working under load.
jstack points to a problem with GRPC that is fixed in later versions
### Changes
upgraded GRPC
Master Issue: #2581
> ---
> In order to uphold a high standard for quality for code contributions, Apache BookKeeper runs various precommit
> checks for pull requests. A pull request can only be merged when it passes precommit checks.
>
> ---
> Be sure to do all of the following to help us incorporate your contribution
> quickly and easily:
>
> If this PR is a BookKeeper Proposal (BP):
>
> - [ ] Make sure the PR title is formatted like:
> `<BP-#>: Description of bookkeeper proposal`
> `e.g. BP-1: 64 bits ledger is support`
> - [ ] Attach the master issue link in the description of this PR.
> - [ ] Attach the google doc link if the BP is written in Google Doc.
>
> Otherwise:
>
> - [ ] Make sure the PR title is formatted like:
> `<Issue #>: Description of pull request`
> `e.g. Issue 123: Description ...`
> - [ ] Make sure tests pass via `mvn clean apache-rat:check install spotbugs:check`.
> - [ ] Replace `<Issue #>` in the title with the actual Issue number.
>
> ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli commented on a change in pull request #2582: Upgrading GRPC version
Posted by GitBox <gi...@apache.org>.
eolivelli commented on a change in pull request #2582:
URL: https://github.com/apache/bookkeeper/pull/2582#discussion_r572654979
##########
File path: pom.xml
##########
@@ -475,6 +476,27 @@
<artifactId>grpc-all</artifactId>
<version>${grpc.version}</version>
</dependency>
+ <dependency>
+ <groupId>io.grpc</groupId>
+ <artifactId>grpc-netty-shaded</artifactId>
+ <version>${grpc.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>io.grpc</groupId>
+ <artifactId>grpc-protobuf</artifactId>
+ <version>${grpc.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>io.grpc</groupId>
+ <artifactId>grpc-stub</artifactId>
+ <version>${grpc.version}</version>
+ </dependency>
+ <dependency> <!-- necessary for Java 9+ -->
+ <groupId>org.apache.tomcat</groupId>
+ <artifactId>annotations-api</artifactId>
+ <version>${tomcat-annotations.version}</version>
+ <scope>provided</scope>
+ </dependency>
Review comment:
This comment looks addressed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] lhotari commented on a change in pull request #2582: Upgrading GRPC version
Posted by GitBox <gi...@apache.org>.
lhotari commented on a change in pull request #2582:
URL: https://github.com/apache/bookkeeper/pull/2582#discussion_r572672859
##########
File path: metadata-drivers/etcd/pom.xml
##########
@@ -51,10 +51,32 @@
<version>${grpc.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.arquillian.cube</groupId>
+ <artifactId>arquillian-cube-docker</artifactId>
+ <version>${arquillian-cube.version}</version>
Review comment:
resolved by 2d86dc7
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] lhotari commented on a change in pull request #2582: Upgrading GRPC version
Posted by GitBox <gi...@apache.org>.
lhotari commented on a change in pull request #2582:
URL: https://github.com/apache/bookkeeper/pull/2582#discussion_r570030889
##########
File path: pom.xml
##########
@@ -130,7 +130,8 @@
<freebuilder.version>1.14.9</freebuilder.version>
<google.code.version>3.0.2</google.code.version>
<google.errorprone.version>2.1.2</google.errorprone.version>
- <grpc.version>1.18.0</grpc.version>
+ <grpc.version>1.35.0</grpc.version>
+ <tomcat-annotations.version>1.35.0</tomcat-annotations.version>
Review comment:
I guess that the `tomcat-annotations.version` is not correct. What is the exact reason for introducing this dependency?
It looks like the dependency isn't maintained, updated last in 2017: https://search.maven.org/artifact/org.apache.tomcat/annotations-api
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] lhotari commented on a change in pull request #2582: Upgrading GRPC version
Posted by GitBox <gi...@apache.org>.
lhotari commented on a change in pull request #2582:
URL: https://github.com/apache/bookkeeper/pull/2582#discussion_r572669514
##########
File path: metadata-drivers/etcd/pom.xml
##########
@@ -51,10 +51,32 @@
<version>${grpc.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.arquillian.cube</groupId>
+ <artifactId>arquillian-cube-docker</artifactId>
+ <version>${arquillian-cube.version}</version>
Review comment:
should have `<scope>test</scope>` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] lhotari commented on a change in pull request #2582: Upgrading GRPC version
Posted by GitBox <gi...@apache.org>.
lhotari commented on a change in pull request #2582:
URL: https://github.com/apache/bookkeeper/pull/2582#discussion_r572672614
##########
File path: metadata-drivers/etcd/pom.xml
##########
@@ -43,14 +44,39 @@
</exclusion>
</exclusions>
</dependency>
+
<dependency>
<groupId>io.grpc</groupId>
<artifactId>grpc-all</artifactId>
+ <version>${grpc.version}</version>
+ </dependency>
+
+ <dependency>
+ <groupId>org.arquillian.cube</groupId>
+ <artifactId>arquillian-cube-docker</artifactId>
+ <version>${arquillian-cube.version}</version>
+ <exclusions>
+ <exclusion>
+ <groupId>com.github.docker-java</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
</dependency>
+ <dependency>
+ <groupId>org.jboss.arquillian.junit</groupId>
+ <artifactId>arquillian-junit-standalone</artifactId>
+ <version>${arquillian-junit.version}</version>
+ <exclusions>
+ <exclusion>
+ <groupId>com.github.docker-java</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+
<dependency>
<groupId>org.testcontainers</groupId>
<artifactId>testcontainers</artifactId>
- <scope>test</scope>
Review comment:
resolved by 2d86dc7e6
##########
File path: metadata-drivers/etcd/pom.xml
##########
@@ -51,10 +51,32 @@
<version>${grpc.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.arquillian.cube</groupId>
+ <artifactId>arquillian-cube-docker</artifactId>
+ <version>${arquillian-cube.version}</version>
+ <exclusions>
+ <exclusion>
+ <groupId>com.github.docker-java</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>org.jboss.arquillian.junit</groupId>
+ <artifactId>arquillian-junit-standalone</artifactId>
+ <version>${arquillian-junit.version}</version>
Review comment:
resolved by 2d86dc7
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] dlg99 commented on pull request #2582: Upgrading GRPC version
Posted by GitBox <gi...@apache.org>.
dlg99 commented on pull request #2582:
URL: https://github.com/apache/bookkeeper/pull/2582#issuecomment-773633909
The problem with the integration tests seems to be related to the etcd client.
We use com.coreos:jetcd-core 0.0.2 currently, it is 2 years old and unmaintained. It relies on the API that no longer exists in newer grpc
The new etcd client is io.etcd:jetcd-core 0.5.4; all imports and some APIs seem to have change as well; I'll try to update etcd client as well.
I am not sure what/whom this can affect but anyone running 2yo etcd should consider rethinking their life choices. :/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] lhotari commented on a change in pull request #2582: Upgrading GRPC version
Posted by GitBox <gi...@apache.org>.
lhotari commented on a change in pull request #2582:
URL: https://github.com/apache/bookkeeper/pull/2582#discussion_r570029472
##########
File path: pom.xml
##########
@@ -475,6 +476,27 @@
<artifactId>grpc-all</artifactId>
<version>${grpc.version}</version>
</dependency>
+ <dependency>
+ <groupId>io.grpc</groupId>
+ <artifactId>grpc-netty-shaded</artifactId>
+ <version>${grpc.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>io.grpc</groupId>
+ <artifactId>grpc-protobuf</artifactId>
+ <version>${grpc.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>io.grpc</groupId>
+ <artifactId>grpc-stub</artifactId>
+ <version>${grpc.version}</version>
+ </dependency>
+ <dependency> <!-- necessary for Java 9+ -->
+ <groupId>org.apache.tomcat</groupId>
+ <artifactId>annotations-api</artifactId>
+ <version>${tomcat-annotations.version}</version>
+ <scope>provided</scope>
+ </dependency>
Review comment:
There's a grpc-bom Maven BOM available since version 1.25 . I wonder if we should replace the individual dependencies in the `dependencyManagement` of `pom.xml` with the `grpc-bom` import?
Something like:
```
<dependency>
<groupId>io.grpc</groupId>
<artifactId>grpc-bom</artifactId>
<version>${grpc.version}</version>
<type>pom</type>
<scope>import</scope>
</dependency>
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] dlg99 commented on pull request #2582: Upgrading GRPC version
Posted by GitBox <gi...@apache.org>.
dlg99 commented on pull request #2582:
URL: https://github.com/apache/bookkeeper/pull/2582#issuecomment-773633909
The problem with the integration tests seems to be related to the etcd client.
We use com.coreos:jetcd-core 0.0.2 currently, it is 2 years old and unmaintained. It relies on the API that no longer exists in newer grpc
The new etcd client is io.etcd:jetcd-core 0.5.4; all imports and some APIs seem to have change as well; I'll try to update etcd client as well.
I am not sure what/whom this can affect but anyone running 2yo etcd should consider rethinking their life choices. :/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] dlg99 commented on pull request #2582: Upgrading GRPC version
Posted by GitBox <gi...@apache.org>.
dlg99 commented on pull request #2582:
URL: https://github.com/apache/bookkeeper/pull/2582#issuecomment-775367557
So far:
I had to upgrade etcd client, which dragged testcontainers (and docker-java) upgrade as well.
All tests pass now.
I left netty at its current version. jetcd dependencies use newer version but TLS tests timeout with it
I see that netty had this change https://github.com/netty/netty/pull/10407 in 4.1.52 that got reverted https://github.com/netty/netty/pull/10980 in 4.1.59 (today's release, not even on maven central yet) - I suspect this is the reason for the test timeout. As long as etcd test pass I assume it is ok with older version.
A few notes:
Most of the API changes (deprecated => current) are rather mechanical.
`EtcdBookieRegister` deserves closer look.
I left deprecated grpc API in couple of places (i.e. `BKRegistrationNameResolverProvider`) because one experimental API (ManagedChannelBuilder.nameResolverFactory) is deprecated in favor of another experimental API (NameResolverRegistry) and introducing larger changes didn't make sense if that experimental change can get deprecated soon anyways.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] lhotari commented on a change in pull request #2582: Upgrading GRPC version
Posted by GitBox <gi...@apache.org>.
lhotari commented on a change in pull request #2582:
URL: https://github.com/apache/bookkeeper/pull/2582#discussion_r572664272
##########
File path: metadata-drivers/etcd/pom.xml
##########
@@ -43,14 +44,39 @@
</exclusion>
</exclusions>
</dependency>
+
<dependency>
<groupId>io.grpc</groupId>
<artifactId>grpc-all</artifactId>
+ <version>${grpc.version}</version>
+ </dependency>
+
+ <dependency>
+ <groupId>org.arquillian.cube</groupId>
+ <artifactId>arquillian-cube-docker</artifactId>
+ <version>${arquillian-cube.version}</version>
+ <exclusions>
+ <exclusion>
+ <groupId>com.github.docker-java</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
</dependency>
+ <dependency>
+ <groupId>org.jboss.arquillian.junit</groupId>
+ <artifactId>arquillian-junit-standalone</artifactId>
+ <version>${arquillian-junit.version}</version>
+ <exclusions>
+ <exclusion>
+ <groupId>com.github.docker-java</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+
<dependency>
<groupId>org.testcontainers</groupId>
<artifactId>testcontainers</artifactId>
- <scope>test</scope>
Review comment:
Why is `<scope>test</scope>` removed from testcontainers dependency?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] lhotari commented on a change in pull request #2582: Upgrading GRPC version
Posted by GitBox <gi...@apache.org>.
lhotari commented on a change in pull request #2582:
URL: https://github.com/apache/bookkeeper/pull/2582#discussion_r572662336
##########
File path: pom.xml
##########
@@ -130,7 +130,8 @@
<freebuilder.version>1.14.9</freebuilder.version>
<google.code.version>3.0.2</google.code.version>
<google.errorprone.version>2.1.2</google.errorprone.version>
- <grpc.version>1.18.0</grpc.version>
+ <grpc.version>1.35.0</grpc.version>
+ <tomcat-annotations.version>1.35.0</tomcat-annotations.version>
Review comment:
This is resolved.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] lhotari commented on a change in pull request #2582: Upgrading GRPC version
Posted by GitBox <gi...@apache.org>.
lhotari commented on a change in pull request #2582:
URL: https://github.com/apache/bookkeeper/pull/2582#discussion_r570029472
##########
File path: pom.xml
##########
@@ -475,6 +476,27 @@
<artifactId>grpc-all</artifactId>
<version>${grpc.version}</version>
</dependency>
+ <dependency>
+ <groupId>io.grpc</groupId>
+ <artifactId>grpc-netty-shaded</artifactId>
+ <version>${grpc.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>io.grpc</groupId>
+ <artifactId>grpc-protobuf</artifactId>
+ <version>${grpc.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>io.grpc</groupId>
+ <artifactId>grpc-stub</artifactId>
+ <version>${grpc.version}</version>
+ </dependency>
+ <dependency> <!-- necessary for Java 9+ -->
+ <groupId>org.apache.tomcat</groupId>
+ <artifactId>annotations-api</artifactId>
+ <version>${tomcat-annotations.version}</version>
+ <scope>provided</scope>
+ </dependency>
Review comment:
There's a grpc-bom Maven BOM available since version 1.25 . I wonder if we should replace the individual dependencies in the `dependencyManagement` of `pom.xml` with the `grpc-bom` import?
Something like:
```
<dependency>
<groupId>io.grpc</groupId>
<artifactId>grpc-bom</artifactId>
<version>${grpc.version}</version>
<type>pom</type>
<scope>import</scope>
</dependency>
```
##########
File path: pom.xml
##########
@@ -130,7 +130,8 @@
<freebuilder.version>1.14.9</freebuilder.version>
<google.code.version>3.0.2</google.code.version>
<google.errorprone.version>2.1.2</google.errorprone.version>
- <grpc.version>1.18.0</grpc.version>
+ <grpc.version>1.35.0</grpc.version>
+ <tomcat-annotations.version>1.35.0</tomcat-annotations.version>
Review comment:
I guess that the `tomcat-annotations.version` is not correct. What is the exact reason for introducing this dependency?
It looks like the dependency isn't maintained, updated last in 2017: https://search.maven.org/artifact/org.apache.tomcat/annotations-api
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli commented on pull request #2582: Upgrading GRPC version
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #2582:
URL: https://github.com/apache/bookkeeper/pull/2582#issuecomment-775753031
@dlg99 I have added a commit in order to address @lhotari comment
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli merged pull request #2582: Upgrading GRPC version to 1.33, Netty to 4.1.50Final and ETCD client driver
Posted by GitBox <gi...@apache.org>.
eolivelli merged pull request #2582:
URL: https://github.com/apache/bookkeeper/pull/2582
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] lhotari commented on a change in pull request #2582: Upgrading GRPC version
Posted by GitBox <gi...@apache.org>.
lhotari commented on a change in pull request #2582:
URL: https://github.com/apache/bookkeeper/pull/2582#discussion_r572669685
##########
File path: metadata-drivers/etcd/pom.xml
##########
@@ -51,10 +51,32 @@
<version>${grpc.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.arquillian.cube</groupId>
+ <artifactId>arquillian-cube-docker</artifactId>
+ <version>${arquillian-cube.version}</version>
+ <exclusions>
+ <exclusion>
+ <groupId>com.github.docker-java</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>org.jboss.arquillian.junit</groupId>
+ <artifactId>arquillian-junit-standalone</artifactId>
+ <version>${arquillian-junit.version}</version>
Review comment:
should have `<scope>test</scope>` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] dlg99 commented on pull request #2582: Upgrading GRPC version
Posted by GitBox <gi...@apache.org>.
dlg99 commented on pull request #2582:
URL: https://github.com/apache/bookkeeper/pull/2582#issuecomment-775578408
@eolivelli The licenses weren't updated in a while. I.e. licenses still referred netty 4.1.32, the build is on 4.1.50, similarly others (rocksdb etc).
I did first pass on updating the licenses for the server, haven't touched two other tars.
TBH at this point I am thinking that the best way to deal with this is:
- undo last commit (licenses change) in this PR
- create separate issue/PR specifically for the licenses update; make it a blocker for the release, if needed. Deal with licenses there.
- add licenses validation into the PR validation
This is what's currently left for the server, after the last commit:
```
$ dev/check-binary-license bookkeeper-dist/server/target/bookkeeper-server-4.13.0-SNAPSHOT-bin.tar.gz
com.google.android-annotations-4.1.1.4.jar unaccounted for in LICENSE
com.google.auto.value-auto-value-annotations-1.7.jar unaccounted for in LICENSE
com.google.code.gson-gson-2.8.6.jar unaccounted for in LICENSE
com.google.guava-failureaccess-1.0.1.jar unaccounted for in LICENSE
com.google.guava-guava-30.0-jre.jar unaccounted for in LICENSE
com.google.guava-listenablefuture-9999.0-empty-to-avoid-conflict-with-guava.jar unaccounted for in LICENSE
com.google.http-client-google-http-client-1.34.0.jar unaccounted for in LICENSE
com.google.http-client-google-http-client-jackson2-1.34.0.jar unaccounted for in LICENSE
com.google.j2objc-j2objc-annotations-1.3.jar unaccounted for in LICENSE
com.google.protobuf-protobuf-java-util-3.12.0.jar unaccounted for in LICENSE
com.google.re2j-re2j-1.2.jar unaccounted for in LICENSE
com.squareup.okhttp-okhttp-2.7.4.jar unaccounted for in LICENSE
io.dropwizard.metrics-metrics-core-3.1.0.jar unaccounted for in LICENSE
io.perfmark-perfmark-api-0.19.0.jar unaccounted for in LICENSE
org.apache.thrift-libthrift-0.12.0.jar unaccounted for in LICENSE
org.checkerframework-checker-qual-3.5.0.jar unaccounted for in LICENSE
org.conscrypt-conscrypt-openjdk-uber-2.5.1.jar unaccounted for in LICENSE
org.rocksdb-rocksdbjni-6.10.2.jar unaccounted for in LICENSE
org.xerial.snappy-snappy-java-1.1.7.jar unaccounted for in LICENSE
com.google.guava-guava-30.0.jar mentioned in LICENSE, but not bundled
org.rocksdb-rocksdbjni-5.13.1.jar mentioned in LICENSE, but not bundled
com.google.code.gson-gson-2.7.jar mentioned in LICENSE, but not bundled
com.squareup.okhttp-okhttp-2.5.0.jar mentioned in LICENSE, but not bundled
org.apache.thrift-libthrift-0.9.3.jar mentioned in LICENSE, but not bundled
org.rocksdb-rocksdbjni-5.13.1.jar mentioned in LICENSE, but not bundled
com.google.protobuf.nano-protobuf-javanano-3.0.0-alpha-5.jar mentioned in LICENSE, but not bundled
jline-jline-2.11.jar mentioned in LICENSE, but not bundled
org.checkerframework-checker-compat-qual-2.5.2.jar mentioned in LICENSE, but not bundled
io.netty-netty-tcnative-boringssl-static-2.0.20.Final.jar mentioned in NOTICE, but not bundled
io.grpc-grpc-protobuf-nano-1.33.0.jar mentioned in NOTICE, but not bundled
deps/protobuf-3.14.0/LICENSE linked from LICENSE, but not found in tarball
deps/javax.servlet-api-4.0.0/CDDL+GPL-1.1 linked from LICENSE, but not found in tarball
deps/protobuf-3.5.1/LICENSE bundled, but not linked from LICENSE
deps/javax.servlet-api-3.1.0/CDDL+GPL-1.1 bundled, but not linked from LICENSE
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org