[GitHub] sgoeminn commented on a change in pull request #2445: CLOUDSTACK-10218: fix for forced network update to a nuage network of?

[GitBox <gi...@apache.org>]

sgoeminn commented on a change in pull request #2445: CLOUDSTACK-10218: fix for forced network update to a nuage network of?
URL: https://github.com/apache/cloudstack/pull/2445#discussion_r166019251
 
 

 ##########
 File path: plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java
 ##########
 @@ -470,14 +468,14 @@ public void reserve(NicProfile nic, Network network, VirtualMachineProfile vm, D
             HostVO nuageVspHost = _nuageVspManager.getNuageVspHost(network.getPhysicalNetworkId());
             VspNetwork vspNetwork = _nuageVspEntityBuilder.buildVspNetwork(vm.getVirtualMachine().getDomainId(), network);
 
-            if (vm.getType() == VirtualMachine.Type.DomainRouter && vspNetwork.getVirtualRouterIp().equals("null")) {
+            boolean isUpgradeNetworkOffering = vm.getType() == VirtualMachine.Type.DomainRouter && vspNetwork.getVirtualRouterIp()
 
 Review comment:
   @DaanHoogland if a VR is spinned in a network that currently has no virtual router ip (vspNetwork.getVRip==null), it means that there was no virtual router before and that the network offering is changed. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services