[GitHub] [pinot] nizarhejazi commented on a diff in pull request #8468: Support Single-valued BigDecimal columns across different SQL statements, and Pinot transforms and operators

[GitBox <gi...@apache.org>]

nizarhejazi commented on code in PR #8468:
URL: https://github.com/apache/pinot/pull/8468#discussion_r844294458


##########
pinot-common/src/main/java/org/apache/pinot/common/utils/PinotDataType.java:
##########
@@ -136,6 +143,11 @@ public double toDouble(Object value) {
       return ((Number) value).doubleValue();
     }
 
+    @Override
+    public BigDecimal toBigDecimal(Object value) {
+      return new BigDecimal(toInt(value));

Review Comment:
   Using `BigDecimal.valueOf()` requires extra cast from `int` to `long` and hence I use the constructor that takes int.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org