You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Valentin Valchev (JIRA)" <ji...@apache.org> on 2010/04/13 10:54:48 UTC
[jira] Created: (FELIX-2277) Allow the user to select display
language
Allow the user to select display language
-----------------------------------------
Key: FELIX-2277
URL: https://issues.apache.org/jira/browse/FELIX-2277
Project: Felix
Issue Type: Improvement
Components: Web Console
Affects Versions: webconsole-3.0.0
Reporter: Valentin Valchev
Priority: Minor
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (FELIX-2277) Allow the user to select display
language
Posted by "Valentin Valchev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Valentin Valchev updated FELIX-2277:
------------------------------------
Attachment: langselect.zip
I've created a small prototype that adds a little icon on the top/right corner of the page.
When you move the mouse over it, few flags for selecting the language are shown.
Clicking on the flag sets the cookie and reloads the page.
The code is rather simple. To add new language just need a new image like this:
<img src="de.gif" alt="de" title="Deutsch"/>
'alt' attribute is actually used as value for the cookie. Title is the language name. It is shown as tooltip by the browser.
The icons are free and taken from http://famfamfam.com/lab/icons/flags/
So, WDYT?
> Allow the user to select display language
> -----------------------------------------
>
> Key: FELIX-2277
> URL: https://issues.apache.org/jira/browse/FELIX-2277
> Project: Felix
> Issue Type: Improvement
> Components: Web Console
> Affects Versions: webconsole-3.0.0
> Reporter: Valentin Valchev
> Priority: Minor
> Attachments: langselect.zip
>
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (FELIX-2277) Allow the user to select display
language
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger closed FELIX-2277.
------------------------------------
Apache Felix Web Console 3.1.2 has been released. The issues are now closed.
> Allow the user to select display language
> -----------------------------------------
>
> Key: FELIX-2277
> URL: https://issues.apache.org/jira/browse/FELIX-2277
> Project: Felix
> Issue Type: Improvement
> Components: Web Console
> Affects Versions: webconsole-3.0.0
> Reporter: Valentin Valchev
> Assignee: Valentin Valchev
> Priority: Minor
> Fix For: webconsole-3.1.2
>
> Attachments: langselect.zip, locale-select.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FELIX-2277) Allow the user to select display
language
Posted by "Valentin Valchev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Valentin Valchev updated FELIX-2277:
------------------------------------
Attachment: locale-select.patch
Provided patch against HEAD
Please note, that binary files (flag images are not included in the patch). If you want to test it you should manually install them in webconsole\src\main\resources\res\flags\
I've just placed bg.gif, de.gif and en.gif from the previously attached zip file.
For more information about how the languages are detected see the WebConsoleConstants.ATTR_LANG_MAP javadoc.
> Allow the user to select display language
> -----------------------------------------
>
> Key: FELIX-2277
> URL: https://issues.apache.org/jira/browse/FELIX-2277
> Project: Felix
> Issue Type: Improvement
> Components: Web Console
> Affects Versions: webconsole-3.0.0
> Reporter: Valentin Valchev
> Priority: Minor
> Attachments: langselect.zip, locale-select.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (FELIX-2277) Allow the user to select display
language
Posted by "Valentin Valchev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Valentin Valchev reassigned FELIX-2277:
---------------------------------------
Assignee: Valentin Valchev
> Allow the user to select display language
> -----------------------------------------
>
> Key: FELIX-2277
> URL: https://issues.apache.org/jira/browse/FELIX-2277
> Project: Felix
> Issue Type: Improvement
> Components: Web Console
> Affects Versions: webconsole-3.0.0
> Reporter: Valentin Valchev
> Assignee: Valentin Valchev
> Priority: Minor
> Attachments: langselect.zip, locale-select.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-2277) Allow the user to select display
language
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12889653#action_12889653 ]
Felix Meschberger commented on FELIX-2277:
------------------------------------------
Looks good with the following comments:
(1) I would change line 626 of the patched AbstractWebConsolePlugin file to
if (null != langMap && !langMap.isEmpty())
thus to not render the flag "button" if there is no flag to render
(2) How about caching the flags map in the OsgiManager class. The contents of the map is rendered on each request, thus the entries scanned on each request. On the other hand the entries only change when the bundle is resolved and the OsgiManager class recreated any way. WDYT ?
Other than that,I am all for applying the patch. Thanks.
> Allow the user to select display language
> -----------------------------------------
>
> Key: FELIX-2277
> URL: https://issues.apache.org/jira/browse/FELIX-2277
> Project: Felix
> Issue Type: Improvement
> Components: Web Console
> Affects Versions: webconsole-3.0.0
> Reporter: Valentin Valchev
> Assignee: Valentin Valchev
> Priority: Minor
> Attachments: langselect.zip, locale-select.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FELIX-2277) Allow the user to select display
language
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger updated FELIX-2277:
-------------------------------------
Fix Version/s: webconsole-3.1.2
I would like to include this with the next release.
> Allow the user to select display language
> -----------------------------------------
>
> Key: FELIX-2277
> URL: https://issues.apache.org/jira/browse/FELIX-2277
> Project: Felix
> Issue Type: Improvement
> Components: Web Console
> Affects Versions: webconsole-3.0.0
> Reporter: Valentin Valchev
> Assignee: Valentin Valchev
> Priority: Minor
> Fix For: webconsole-3.1.2
>
> Attachments: langselect.zip, locale-select.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (FELIX-2277) Allow the user to select display
language
Posted by "Valentin Valchev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Valentin Valchev resolved FELIX-2277.
-------------------------------------
Resolution: Fixed
Fixed in rev. 984311 with !isEmpty() remark applied and caching of the language map.
> Allow the user to select display language
> -----------------------------------------
>
> Key: FELIX-2277
> URL: https://issues.apache.org/jira/browse/FELIX-2277
> Project: Felix
> Issue Type: Improvement
> Components: Web Console
> Affects Versions: webconsole-3.0.0
> Reporter: Valentin Valchev
> Assignee: Valentin Valchev
> Priority: Minor
> Fix For: webconsole-3.1.2
>
> Attachments: langselect.zip, locale-select.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.