You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "keith-turner (via GitHub)" <gi...@apache.org> on 2024/08/24 16:32:10 UTC
[PR] refactors how scan sessions track scan task [accumulo]
keith-turner opened a new pull request, #4829:
URL: https://github.com/apache/accumulo/pull/4829
This is manual refactor of how scan sessions track scan task. MultiScanSession and SinceScanSession both extend ScanSession. Each was tracking scan task separately. Moved this tracking into the parent class ScanSession. This refactoring is needed for #4756 but want to do it on its own to simplify review for bug fix release changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactors how scan sessions track scan task [accumulo]
Posted by "cshannon (via GitHub)" <gi...@apache.org>.
cshannon commented on code in PR #4829:
URL: https://github.com/apache/accumulo/pull/4829#discussion_r1730042285
##########
server/tserver/src/main/java/org/apache/accumulo/tserver/session/ScanSession.java:
##########
@@ -180,9 +183,18 @@ public TabletResolver getTabletResolver() {
return tabletResolver;
}
+ public ScanTask<T> getScanTask() {
+ return scanTask;
+ }
+
+ public void setScanTask(ScanTask<T> scanTask) {
+ this.scanTask = scanTask;
+ }
+
@Override
public boolean cleanup() {
tabletResolver.close();
+
Review Comment:
The cleanup method could be simplified:
```suggestion
@Override
public boolean cleanup() {
tabletResolver.close();
return super.cleanup();
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactors how scan sessions track scan task [accumulo]
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner merged PR #4829:
URL: https://github.com/apache/accumulo/pull/4829
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org