You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2022/04/11 11:02:32 UTC
[GitHub] [incubator-mxnet] piotrwolinski-intel opened a new pull request, #20997: [master] Remove dnnl_ops-inl.h file
piotrwolinski-intel opened a new pull request, #20997:
URL: https://github.com/apache/incubator-mxnet/pull/20997
This PR removes `dnnl_ops-inl.h` file which was holding often redundant declarations. Those that were not redundant were moved to the appropriate header files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bgawrych commented on a diff in pull request #20997: [master] Remove dnnl_ops-inl.h file
Posted by GitBox <gi...@apache.org>.
bgawrych commented on code in PR #20997:
URL: https://github.com/apache/incubator-mxnet/pull/20997#discussion_r855847913
##########
src/operator/leaky_relu-inl.h:
##########
@@ -479,6 +479,18 @@ void LeakyReLUGradCompute(const nnvm::NodeAttrs& attrs,
});
}
+void DNNLLeakyReluForward(const nnvm::NodeAttrs& attrs,
+ const OpContext& ctx,
+ const NDArray& in_data,
+ const OpReqType& req,
+ const NDArray& out_data);
+
+void DNNLLeakyReluBackward(const nnvm::NodeAttrs& attrs,
+ const OpContext& ctx,
+ const std::vector<NDArray>& inputs,
+ const std::vector<OpReqType>& req,
+ const std::vector<NDArray>& outputs);
+
Review Comment:
I think it would be better to move these declaration to one of dnnl file - e.g. dnnl_activation-inl.h and then included in this file with #if MXNET_USE_ONEDNN == 1 guard
This applies to all other changes in this PR as well
btw. current declaration should be also guarded with #if MXNET_USE_ONEDNN == 1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] piotrwolinski-intel commented on pull request #20997: [master] Remove dnnl_ops-inl.h file
Posted by GitBox <gi...@apache.org>.
piotrwolinski-intel commented on PR #20997:
URL: https://github.com/apache/incubator-mxnet/pull/20997#issuecomment-1131567790
@mxnet-bot run ci [miscellaneous, unix-cpu, unix-gpu, website]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20997: [master] Remove dnnl_ops-inl.h file
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on PR #20997:
URL: https://github.com/apache/incubator-mxnet/pull/20997#issuecomment-1114641971
Jenkins CI successfully triggered : [unix-gpu, miscellaneous, unix-cpu, windows-gpu, website]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] piotrwolinski-intel commented on a diff in pull request #20997: [master] Remove dnnl_ops-inl.h file
Posted by GitBox <gi...@apache.org>.
piotrwolinski-intel commented on code in PR #20997:
URL: https://github.com/apache/incubator-mxnet/pull/20997#discussion_r879334267
##########
src/operator/nn/dnnl/dnnl_deconvolution-inl.h:
##########
@@ -130,24 +129,24 @@ class DNNLDeconvFwd {
std::shared_ptr<deconv_fwd_pd_t> fwd_pd;
};
-DNNLDeconvFwd::Tensors::Tensors(const bool no_bias,
- const std::vector<NDArray>& inputs,
- const std::vector<NDArray>& outputs)
- : data(inputs[deconv::kData]),
- weights(inputs[deconv::kWeight]),
- bias(no_bias ? nullptr : &inputs[deconv::kBias]),
- out(outputs[deconv::kOut]) {}
-
-DNNLDeconvFwd::Tensors::Tensors(const NDArray& data,
- const NDArray& weights,
- const NDArray* const bias,
- const NDArray& out)
- : data(data), weights(weights), bias(bias), out(out) {}
-
-DNNLDeconvFwd::DNNLDeconvFwd(const DeconvolutionParam& param, const Tensors& tensors)
- : fwd_pd(CreatePrimitiveDesc(param, tensors)) {
- fwd = std::make_shared<deconv_fwd_t>(*fwd_pd);
-}
+// DNNLDeconvFwd::Tensors::Tensors(const bool no_bias,
+// const std::vector<NDArray>& inputs,
+// const std::vector<NDArray>& outputs)
+// : data(inputs[deconv::kData]),
+// weights(inputs[deconv::kWeight]),
+// bias(no_bias ? nullptr : &inputs[deconv::kBias]),
+// out(outputs[deconv::kOut]) {}
+
+// DNNLDeconvFwd::Tensors::Tensors(const NDArray& data,
+// const NDArray& weights,
+// const NDArray* const bias,
+// const NDArray& out)
+// : data(data), weights(weights), bias(bias), out(out) {}
+
+// DNNLDeconvFwd::DNNLDeconvFwd(const DeconvolutionParam& param, const Tensors& tensors)
+// : fwd_pd(CreatePrimitiveDesc(param, tensors)) {
+// fwd = std::make_shared<deconv_fwd_t>(*fwd_pd);
+// }
Review Comment:
Yes, fixed it, thank You
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bgawrych commented on a diff in pull request #20997: [master] Remove dnnl_ops-inl.h file
Posted by GitBox <gi...@apache.org>.
bgawrych commented on code in PR #20997:
URL: https://github.com/apache/incubator-mxnet/pull/20997#discussion_r879111806
##########
src/operator/nn/dnnl/dnnl_deconvolution-inl.h:
##########
@@ -130,24 +129,24 @@ class DNNLDeconvFwd {
std::shared_ptr<deconv_fwd_pd_t> fwd_pd;
};
-DNNLDeconvFwd::Tensors::Tensors(const bool no_bias,
- const std::vector<NDArray>& inputs,
- const std::vector<NDArray>& outputs)
- : data(inputs[deconv::kData]),
- weights(inputs[deconv::kWeight]),
- bias(no_bias ? nullptr : &inputs[deconv::kBias]),
- out(outputs[deconv::kOut]) {}
-
-DNNLDeconvFwd::Tensors::Tensors(const NDArray& data,
- const NDArray& weights,
- const NDArray* const bias,
- const NDArray& out)
- : data(data), weights(weights), bias(bias), out(out) {}
-
-DNNLDeconvFwd::DNNLDeconvFwd(const DeconvolutionParam& param, const Tensors& tensors)
- : fwd_pd(CreatePrimitiveDesc(param, tensors)) {
- fwd = std::make_shared<deconv_fwd_t>(*fwd_pd);
-}
+// DNNLDeconvFwd::Tensors::Tensors(const bool no_bias,
+// const std::vector<NDArray>& inputs,
+// const std::vector<NDArray>& outputs)
+// : data(inputs[deconv::kData]),
+// weights(inputs[deconv::kWeight]),
+// bias(no_bias ? nullptr : &inputs[deconv::kBias]),
+// out(outputs[deconv::kOut]) {}
+
+// DNNLDeconvFwd::Tensors::Tensors(const NDArray& data,
+// const NDArray& weights,
+// const NDArray* const bias,
+// const NDArray& out)
+// : data(data), weights(weights), bias(bias), out(out) {}
+
+// DNNLDeconvFwd::DNNLDeconvFwd(const DeconvolutionParam& param, const Tensors& tensors)
+// : fwd_pd(CreatePrimitiveDesc(param, tensors)) {
+// fwd = std::make_shared<deconv_fwd_t>(*fwd_pd);
+// }
Review Comment:
overlooked?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bartekkuncer commented on a diff in pull request #20997: [master] Remove dnnl_ops-inl.h file
Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on code in PR #20997:
URL: https://github.com/apache/incubator-mxnet/pull/20997#discussion_r847387297
##########
src/operator/nn/dnnl/dnnl_sum.cc:
##########
@@ -23,10 +23,11 @@
* \author Da Zheng
*/
#include <iostream>
+#include <vector>
#include "operator/operator_common.h"
#include "dnnl_base-inl.h"
-#include "dnnl_ops-inl.h"
+#include "dnnl_sum-inl.h"
Review Comment:
I would do it within this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20997: [master] Remove dnnl_ops-inl.h file
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on PR #20997:
URL: https://github.com/apache/incubator-mxnet/pull/20997#issuecomment-1137414030
Jenkins CI successfully triggered : [centos-cpu, centos-gpu, unix-cpu, edge, miscellaneous, windows-gpu, windows-cpu, unix-gpu, clang, website]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] piotrwolinski-intel commented on pull request #20997: [master] Remove dnnl_ops-inl.h file
Posted by GitBox <gi...@apache.org>.
piotrwolinski-intel commented on PR #20997:
URL: https://github.com/apache/incubator-mxnet/pull/20997#issuecomment-1138392772
@mxnet-bot run ci [unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20997: [master] Remove dnnl_ops-inl.h file
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on PR #20997:
URL: https://github.com/apache/incubator-mxnet/pull/20997#issuecomment-1137246871
Jenkins CI successfully triggered : [sanity]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] piotrwolinski-intel commented on a diff in pull request #20997: [master] Remove dnnl_ops-inl.h file
Posted by GitBox <gi...@apache.org>.
piotrwolinski-intel commented on code in PR #20997:
URL: https://github.com/apache/incubator-mxnet/pull/20997#discussion_r847361568
##########
src/operator/tensor/elemwise_unary_op_basic.cc:
##########
@@ -23,8 +23,8 @@
*/
#include <mxnet/base.h>
-#include "../nn/dnnl/dnnl_ops-inl.h"
#include "./elemwise_binary_op-inl.h"
+#include "../nn/dnnl/dnnl_copy-inl.h"
Review Comment:
Changed, so it will follow the guidelines
##########
src/operator/tensor/matrix_op.cc:
##########
@@ -26,11 +26,11 @@
#include "./elemwise_unary_op.h"
#if MXNET_USE_ONEDNN == 1
#include "../nn/dnnl/dnnl_base-inl.h"
-#include "../nn/dnnl/dnnl_ops-inl.h"
#include "../nn/dnnl/dnnl_reshape-inl.h"
#include "../nn/dnnl/dnnl_slice-inl.h"
#include "../nn/dnnl/dnnl_transpose-inl.h"
#include "../nn/dnnl/dnnl_split-inl.h"
+#include "../nn/dnnl/dnnl_stack-inl.h"
Review Comment:
Changed, so it will follow the guidelines
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20997: [master] Remove dnnl_ops-inl.h file
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on PR #20997:
URL: https://github.com/apache/incubator-mxnet/pull/20997#issuecomment-1120999412
Jenkins CI successfully triggered : [unix-cpu, unix-gpu, miscellaneous, website]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] piotrwolinski-intel commented on pull request #20997: [master] Remove dnnl_ops-inl.h file
Posted by GitBox <gi...@apache.org>.
piotrwolinski-intel commented on PR #20997:
URL: https://github.com/apache/incubator-mxnet/pull/20997#issuecomment-1137413622
@mxnet-bot run ci [centos-cpu, centos-gpu, clang, edge, miscellaneous, unix-cpu, unix-gpu, website, windows-cpu, windows-gpu ]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20997: [master] Remove dnnl_ops-inl.h file
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on PR #20997:
URL: https://github.com/apache/incubator-mxnet/pull/20997#issuecomment-1138392832
Jenkins CI successfully triggered : [unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20997: [master] Remove dnnl_ops-inl.h file
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on PR #20997:
URL: https://github.com/apache/incubator-mxnet/pull/20997#issuecomment-1131567868
Jenkins CI successfully triggered : [miscellaneous, website, unix-gpu, unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bgawrych merged pull request #20997: [master] Remove dnnl_ops-inl.h file
Posted by GitBox <gi...@apache.org>.
bgawrych merged PR #20997:
URL: https://github.com/apache/incubator-mxnet/pull/20997
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] piotrwolinski-intel commented on pull request #20997: [master] Remove dnnl_ops-inl.h file
Posted by GitBox <gi...@apache.org>.
piotrwolinski-intel commented on PR #20997:
URL: https://github.com/apache/incubator-mxnet/pull/20997#issuecomment-1137246695
@mxnet-bot run ci [sanity]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] piotrwolinski-intel commented on pull request #20997: [master] Remove dnnl_ops-inl.h file
Posted by GitBox <gi...@apache.org>.
piotrwolinski-intel commented on PR #20997:
URL: https://github.com/apache/incubator-mxnet/pull/20997#issuecomment-1120999337
@mxnet-bot run ci [miscellaneous, unix-cpu, unix-gpu, website]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] piotrwolinski-intel commented on a diff in pull request #20997: [master] Remove dnnl_ops-inl.h file
Posted by GitBox <gi...@apache.org>.
piotrwolinski-intel commented on code in PR #20997:
URL: https://github.com/apache/incubator-mxnet/pull/20997#discussion_r847359618
##########
src/operator/nn/dnnl/dnnl_sum.cc:
##########
@@ -23,10 +23,11 @@
* \author Da Zheng
*/
#include <iostream>
+#include <vector>
#include "operator/operator_common.h"
#include "dnnl_base-inl.h"
-#include "dnnl_ops-inl.h"
+#include "dnnl_sum-inl.h"
Review Comment:
Is it right now or some additional changes are needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20997: [master] Remove dnnl_ops-inl.h file
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on PR #20997:
URL: https://github.com/apache/incubator-mxnet/pull/20997#issuecomment-1094910472
Hey @piotrwolinski-intel , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [centos-gpu, edge, windows-cpu, unix-gpu, miscellaneous, unix-cpu, website, clang, windows-gpu, sanity, centos-cpu]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bartekkuncer commented on a diff in pull request #20997: [master] Remove dnnl_ops-inl.h file
Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on code in PR #20997:
URL: https://github.com/apache/incubator-mxnet/pull/20997#discussion_r847234251
##########
src/operator/nn/dnnl/dnnl_sum.cc:
##########
@@ -23,10 +23,11 @@
* \author Da Zheng
*/
#include <iostream>
+#include <vector>
#include "operator/operator_common.h"
#include "dnnl_base-inl.h"
-#include "dnnl_ops-inl.h"
+#include "dnnl_sum-inl.h"
Review Comment:
Please uniform sum operator - class declaration (and its functions) should be in inl.h file. Please see how it is done in e.g. dnnl_eltwise* files.
##########
src/operator/quantization/dnnl/dnnl_quantized_act.cc:
##########
@@ -23,8 +23,8 @@
*/
#if MXNET_USE_ONEDNN == 1
-#include "operator/nn/dnnl/dnnl_ops-inl.h"
#include "operator/quantization/quantization_utils.h"
+#include "operator/nn/activation-inl.h"
Review Comment:
Unalphabetical order.
##########
src/operator/tensor/elemwise_unary_op_basic.cc:
##########
@@ -23,8 +23,8 @@
*/
#include <mxnet/base.h>
-#include "../nn/dnnl/dnnl_ops-inl.h"
#include "./elemwise_binary_op-inl.h"
+#include "../nn/dnnl/dnnl_copy-inl.h"
Review Comment:
Maybe remove the dots form the includes?
##########
src/operator/tensor/matrix_op.cc:
##########
@@ -26,11 +26,11 @@
#include "./elemwise_unary_op.h"
#if MXNET_USE_ONEDNN == 1
#include "../nn/dnnl/dnnl_base-inl.h"
-#include "../nn/dnnl/dnnl_ops-inl.h"
#include "../nn/dnnl/dnnl_reshape-inl.h"
#include "../nn/dnnl/dnnl_slice-inl.h"
#include "../nn/dnnl/dnnl_transpose-inl.h"
#include "../nn/dnnl/dnnl_split-inl.h"
+#include "../nn/dnnl/dnnl_stack-inl.h"
Review Comment:
Maybe remove dots form the includes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] piotrwolinski-intel commented on pull request #20997: [master] Remove dnnl_ops-inl.h file
Posted by GitBox <gi...@apache.org>.
piotrwolinski-intel commented on PR #20997:
URL: https://github.com/apache/incubator-mxnet/pull/20997#issuecomment-1114641917
@mxnet-bot run ci [windows-gpu, miscellaneous, unix-cpu, unix-gpu, website]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bartekkuncer commented on a diff in pull request #20997: [master] Remove dnnl_ops-inl.h file
Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on code in PR #20997:
URL: https://github.com/apache/incubator-mxnet/pull/20997#discussion_r855877549
##########
src/operator/nn/dnnl/dnnl_reshape-inl.h:
##########
@@ -53,6 +53,13 @@ typedef OpSignature DNNLReshapeSignature;
DNNLReshapeFwd& GetReshapeForward(const OpReqType& req,
const NDArray& input,
const NDArray& output);
+
+void DNNLReshapeForward(const nnvm::NodeAttrs& attrs,
Review Comment:
All other operators should be done like this one.
##########
src/operator/leaky_relu.cc:
##########
@@ -27,7 +27,6 @@
#include "../common/alm.h"
#if MXNET_USE_ONEDNN == 1
#include "./nn/dnnl/dnnl_base-inl.h"
-#include "./nn/dnnl/dnnl_ops-inl.h"
Review Comment:
Continuation of @bgawrych's comment -> here #include "./nn/dnnl/dnnl_ops-inl.h" should be replaced with an include of other dnnl_XXX-inl.h file with the declarations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] piotrwolinski-intel commented on pull request #20997: [master] Remove dnnl_ops-inl.h file
Posted by GitBox <gi...@apache.org>.
piotrwolinski-intel commented on PR #20997:
URL: https://github.com/apache/incubator-mxnet/pull/20997#issuecomment-1134608808
@mxnet-bot run ci [sanity]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20997: [master] Remove dnnl_ops-inl.h file
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on PR #20997:
URL: https://github.com/apache/incubator-mxnet/pull/20997#issuecomment-1134608905
Jenkins CI successfully triggered : [sanity]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org