[jira] [Work logged] (AMQNET-831) Allow extra AckTypes when using IndividualAcknowledge

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/AMQNET-831?focusedWorklogId=859047&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-859047 ]

ASF GitHub Bot logged work on AMQNET-831:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 26/Apr/23 05:34
            Start Date: 26/Apr/23 05:34
    Worklog Time Spent: 10m 
      Work Description: Jefwillems commented on PR #87:
URL: https://github.com/apache/activemq-nms-amqp/pull/87#issuecomment-1522811260

   Is there anything holding this PR back? 
   Also, a bit unrelated, but what's the release schedule once this and #86 are merged? Do you wait for other related packages to be updated? If so, i can try to contribute in those others as well. 




Issue Time Tracking
-------------------

            Worklog Id:     (was: 859047)
    Remaining Estimate: 23h  (was: 23h 10m)
            Time Spent: 1h  (was: 50m)

> Allow extra AckTypes when using IndividualAcknowledge
> -----------------------------------------------------
>
>                 Key: AMQNET-831
>                 URL: https://issues.apache.org/jira/browse/AMQNET-831
>             Project: ActiveMQ .Net
>          Issue Type: New Feature
>          Components: ActiveMQ, AMQP, NMS
>    Affects Versions: AMQP-2.0.0
>         Environment: Tested with apache artemis (from the latest image on quay.io/artemiscloud/activemq-artemis-broker)
>            Reporter: Jef Willems
>            Priority: Major
>              Labels: features, pull-request-available
>   Original Estimate: 24h
>          Time Spent: 1h
>  Remaining Estimate: 23h
>
> I wrote a pull request to allow acknowledging messages with different AckType's
> When using individual acknowledgement, the current setup only accepts MODIFIED_FAILED_UNDELIVERABLE as a negative ack, the pull request allows to use MODIFIED_FAILED, REJECTED as ack types. This way the client can automatically use broker redelivery configurations.
> The client library also is more in line with the qpid-jms counterpart when implementing this change: [https://github.com/apache/qpid-jms/blob/main/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/AmqpConsumer.java#L323]
>  
> The pull request can be found here: https://github.com/apache/activemq-nms-amqp/pull/86



--
This message was sent by Atlassian Jira
(v8.20.10#820010)