You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/04/15 17:23:53 UTC

[GitHub] [incubator-superset] craig-rueda commented on a change in pull request #9547: [tests] Helper script to run single tests

craig-rueda commented on a change in pull request #9547: [tests] Helper script to run single tests
URL: https://github.com/apache/incubator-superset/pull/9547#discussion_r409009243
 
 

 ##########
 File path: scripts/tests/docker-compose.yml
 ##########
 @@ -0,0 +1,51 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+version: '2'
 
 Review comment:
   Can we instead just use the docker-compose in the root of the repo? Will start to get a bit tricky to manage several files. You can specify which compose to leverage, as well as which containers to build/start on the CMD line, as I see you're doing already.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org