[jira] [Commented] (OPENJPA-2754) update to latest dbcp and verify moving from maxActive to maxTotal

["Romain Manni-Bucau (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OPENJPA-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16660571#comment-16660571 ] 

Romain Manni-Bucau commented on OPENJPA-2754:
---------------------------------------------

we shouldnt do any magic in the config and just let the user rely on the pool impl he wants 1-1 IMHO -> sed in the tests

> update to latest dbcp and verify moving from maxActive to maxTotal
> ------------------------------------------------------------------
>
>                 Key: OPENJPA-2754
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-2754
>             Project: OpenJPA
>          Issue Type: Task
>          Components: jdbc
>    Affects Versions: 3.0.0
>            Reporter: Mark Struberg
>            Priority: Major
>             Fix For: 3.0.1
>
>
> commons-dbcp 2 moved from maxActive to maxTotal 
> https://commons.apache.org/proper/commons-dbcp/
> https://commons.apache.org/proper/commons-dbcp/configuration.html
> But all across our build we still use MaxActive.
> Do we like to keep this? Do we (via reflection) don't care and users need to care for themselves if they switch?
> Do we do it right in our unit tests right now?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)