You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/03/21 03:13:41 UTC

[jira] [Commented] (BEAM-1771) Clean up dataflow/google references/URLs in examples

    [ https://issues.apache.org/jira/browse/BEAM-1771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15934025#comment-15934025 ] 

ASF GitHub Bot commented on BEAM-1771:
--------------------------------------

GitHub user melap opened a pull request:

    https://github.com/apache/beam/pull/2281

    [BEAM-1771] Clean up dataflow/google references/URLs in examples

    R: @aaltay @davorbonaci 
    
    In examples/java/README, I separated and created a section for each runner so it's easy for other runners to add their commands also. Please verify I didn't mess up the command lines when doing that, as I'm not familiar with the bundling. Long term, I am wondering if most of the README content would be better off in the Word Count walkthrough on the website? as it's similar to what's there already, and then we can use tabs for Java/Python and the different runners. It'd also mean the user no longer needs to go back and forth between the walkthrough and the README.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/melap/beam examples

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2281.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2281
    
----
commit 81bcbb4d19843a9f404ed9c8bffb64f66e41fb6d
Author: melissa <me...@google.com>
Date:   2017-03-21T02:35:22Z

    [BEAM-1771] Clean up dataflow/google references/URLs in examples

----


> Clean up dataflow/google references/URLs in examples
> ----------------------------------------------------
>
>                 Key: BEAM-1771
>                 URL: https://issues.apache.org/jira/browse/BEAM-1771
>             Project: Beam
>          Issue Type: Improvement
>          Components: examples-java
>            Reporter: Melissa Pashniak
>            Assignee: Melissa Pashniak
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)