Re: Possible bug in RecentChanges plugin

[Ichiro Furusato <ic...@gmail.com>]

Hi Juan Pablo,

I first thought I'd just comment out the offending line in the
jspwiki-custom.properties file
and update the JSPWiki jar, but that didn't have any effect. A rebuild
popped up the
existing CommandResolverTest failing on the now-incorrect expectation of
RecentChanges.jsp, but commenting that out I got the build to work and upon
installing
it the problem with the RecentChanges page went away -- thanks!

Apart from that everything else looks good with "JSPWiki v2.10.0-svn-64"
with both the
FileSystemProvider and our JsonPageProvider. Our next step is to implement
caching
on our provider.

Ichiro


On Tue, Dec 31, 2013 at 1:24 PM, Juan Pablo Santos Rodríguez <
juanpablo.santos@gmail.com> wrote:

> Hi Ichiro,
>
> thanks for spotting this, indeed it's a bug, not caused by code, but by a
> configuration issue (that's why there aren't any traces at all, you're
> getting the "expected behaviour"): if you check
> $svn/jspwiki-war/src/main/resources/ini/jspwiki.properties, lines 361-372,
> you'll see the default special page references, that is, a group of given
> wiki names which will show you some jsp instead of the requested wiki page.
> On line 372, the culprit:
> jspwiki.specialPage.RecentChanges=RecentChanges.jsp and, as we don't have
> that jsp, you see a blank page.
>
> Seems this was unadvertely introduced by me, when moving MVN3_BRANCH into
> trunk on r1486481, but no clues on how, when or why got in there in the
> first place. Maybe to get CommandResolverTest.testSpecialPageReference
> running, but again that's weird b/c that special page reference is set on
> src/test/resources/jspwiki-custom.properties
>
> Anyway, I'm committing the fix on 2.10.0-svn-63 in a moment
>
>
> br,
> juan pablo
>
>
>
> On Mon, Dec 30, 2013 at 11:51 PM, Ichiro Furusato <
> ichiro.furusato@gmail.com
> > wrote:
>
> > Hi,
> >
> > I'm in a bit of a bind. I've just installed a build from a recent SVN
> > version (which shows up
> > as "JSPWiki v2.10.0-svn-61 ") and noticed that the sidebar link to the
> > RecentChanges page
> > links to the home page, i.e., the link seems to not work. I thought this
> > might be due to some
> > problem in the JSONPageProvider or the template/skin we've created, but
> on
> > switching back
> > to the default FileSystemProvider the link to RecentChanges comes up a
> > blank page but titled
> > "RecentChanges.jsp". Switching from our custom template/skin back to
> > PlainVanilla makes no
> > difference, so this isn't (apparently) template related.
> >
> > Curiously, the FullRecentChanges page works fine, and if I copy the
> content
> > of RecentChanges
> > to a differently-named page, that new page works fine as well. There's
> > nothing showing up in
> > the logs to indicate anything has gone awry.
> >
> > Any ideas? Is this pilot error or something in the new build?
> >
> > Ichiro
> >
>