You are viewing a plain text version of this content. The canonical link for it is here.
Posted to rivet-dev@tcl.apache.org by ka...@apache.org on 2005/12/13 00:37:23 UTC
svn commit: r356419 - in /tcl/rivet/trunk: ChangeLog
rivet/packages/dio/dio.tcl
Author: karl
Date: Mon Dec 12 15:37:19 2005
New Revision: 356419
URL: http://svn.apache.org/viewcvs?rev=356419&view=rev
Log:
Reverted change to "store" method
that removed fields from the store array that were part of the
key and took out this behaviour from the update method.
The problem was that "DIO store" or "DIO update" could cause
fields to disappear from the data array as a side effect, and
the caller had no reason to expect that, hence it broke some
code.
Modified:
tcl/rivet/trunk/ChangeLog
tcl/rivet/trunk/rivet/packages/dio/dio.tcl
Modified: tcl/rivet/trunk/ChangeLog
URL: http://svn.apache.org/viewcvs/tcl/rivet/trunk/ChangeLog?rev=356419&r1=356418&r2=356419&view=diff
==============================================================================
--- tcl/rivet/trunk/ChangeLog (original)
+++ tcl/rivet/trunk/ChangeLog Mon Dec 12 15:37:19 2005
@@ -1,3 +1,13 @@
+2005-12-12 Karl Lehenbauer <ka...@sc.com>
+ * rivet/packages/dio/dio.tcl: Reverted change to "store" method
+ that removed fields from the store array that were part of the
+ key and took out this behaviour from the update method.
+
+ The problem was that "DIO store" or "DIO update" could cause
+ fields to disappear from the data array as a side effect, and
+ the caller had no reason to expect that, hence it broke some
+ code.
+
2005-11-08 Karl Lehenbauer <ka...@sc.com>
* rivet/packages/dio/dio.tcl: Add new "update" method that works
Modified: tcl/rivet/trunk/rivet/packages/dio/dio.tcl
URL: http://svn.apache.org/viewcvs/tcl/rivet/trunk/rivet/packages/dio/dio.tcl?rev=356419&r1=356418&r2=356419&view=diff
==============================================================================
--- tcl/rivet/trunk/rivet/packages/dio/dio.tcl (original)
+++ tcl/rivet/trunk/rivet/packages/dio/dio.tcl Mon Dec 12 15:37:19 2005
@@ -453,13 +453,6 @@
$res destroy
if {$numrows} {
- # remove fields that are part of the key from the fields to
- # be updated because they's superfluous -- they can't be updated
- # if they're part of the where clause anyway
- foreach field $myKeyfield {
- unset -nocomplain array($field)
- }
-
set req [build_update_query array $fields $myTable]
append req [build_key_where_clause $myKeyfield $key]
} else {
@@ -486,13 +479,6 @@
upvar 1 $arrayName $arrayName $arrayName array
set key [makekey $arrayName $myKeyfield]
-
- # remove fields that are part of the key from the fields to
- # be updated because they's superfluous -- they can't be updated
- # if they're part of the where clause anyway
- foreach field $myKeyfield {
- unset -nocomplain array($field)
- }
set fields [::array names array]
set req [build_update_query array $fields $myTable]
---------------------------------------------------------------------
To unsubscribe, e-mail: rivet-cvs-unsubscribe@tcl.apache.org
For additional commands, e-mail: rivet-cvs-help@tcl.apache.org