You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/03/20 16:25:00 UTC

[GitHub] [incubator-shardingsphere] terrymanu opened a new pull request #4870: Dynamic to introduce RouteDecorator

terrymanu opened a new pull request #4870: Dynamic to introduce RouteDecorator
URL: https://github.com/apache/incubator-shardingsphere/pull/4870
 
 
   Fixes #4868.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4870: Dynamic to introduce RouteDecorator

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4870: Dynamic to introduce RouteDecorator
URL: https://github.com/apache/incubator-shardingsphere/pull/4870#issuecomment-601816588
 
 
   ## Pull Request Test Coverage Report for [Build 10452](https://coveralls.io/builds/29506153)
   
   * **9** of **74**   **(12.16%)**  changed or added relevant lines in **8** files are covered.
   * **20** unchanged lines in **5** files lost coverage.
   * Overall coverage decreased (**-0.2%**) to **58.477%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [sharding-core/sharding-core-entry/src/main/java/org/apache/shardingsphere/core/shard/BaseShardingEngine.java](https://coveralls.io/builds/29506153/source?filename=sharding-core%2Fsharding-core-entry%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Fshard%2FBaseShardingEngine.java#L119) | 4 | 5 | 80.0%
   | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/communication/jdbc/wrapper/PreparedStatementExecutorWrapper.java](https://coveralls.io/builds/29506153/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fcommunication%2Fjdbc%2Fwrapper%2FPreparedStatementExecutorWrapper.java#L105) | 0 | 3 | 0.0%
   | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/communication/jdbc/wrapper/StatementExecutorWrapper.java](https://coveralls.io/builds/29506153/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fcommunication%2Fjdbc%2Fwrapper%2FStatementExecutorWrapper.java#L102) | 0 | 3 | 0.0%
   | [shardingsphere-underlying/shardingsphere-route/src/main/java/org/apache/shardingsphere/underlying/route/engine/DateNodeRouter.java](https://coveralls.io/builds/29506153/source?filename=shardingsphere-underlying%2Fshardingsphere-route%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Funderlying%2Froute%2Fengine%2FDateNodeRouter.java#L59) | 0 | 7 | 0.0%
   | [sharding-core/sharding-core-route/src/main/java/org/apache/shardingsphere/sharding/route/engine/ShardingRouteDecorator.java](https://coveralls.io/builds/29506153/source?filename=sharding-core%2Fsharding-core-route%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Froute%2Fengine%2FShardingRouteDecorator.java#L70) | 3 | 11 | 27.27%
   | [sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/statement/MasterSlavePreparedStatement.java](https://coveralls.io/builds/29506153/source?filename=sharding-jdbc%2Fsharding-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fjdbc%2Fcore%2Fstatement%2FMasterSlavePreparedStatement.java#L63) | 0 | 16 | 0.0%
   | [sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/statement/MasterSlaveStatement.java](https://coveralls.io/builds/29506153/source?filename=sharding-jdbc%2Fsharding-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fjdbc%2Fcore%2Fstatement%2FMasterSlaveStatement.java#L82) | 1 | 28 | 3.57%
   <!-- | **Total:** | **9** | **74** | **12.16%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [sharding-core/sharding-core-route/src/main/java/org/apache/shardingsphere/sharding/route/engine/ShardingRouteDecorator.java](https://coveralls.io/builds/29506153/source?filename=sharding-core%2Fsharding-core-route%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Froute%2Fengine%2FShardingRouteDecorator.java#L103) | 1 | 35.59% |
   | [shardingsphere-underlying/shardingsphere-route/src/main/java/org/apache/shardingsphere/underlying/route/engine/DateNodeRouter.java](https://coveralls.io/builds/29506153/source?filename=shardingsphere-underlying%2Fshardingsphere-route%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Funderlying%2Froute%2Fengine%2FDateNodeRouter.java#L80) | 1 | 0% |
   | [sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-registrycenter/src/main/java/org/apache/shardingsphere/orchestration/core/registrycenter/util/IpUtils.java](https://coveralls.io/builds/29506153/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsharding-orchestration-core-registrycenter%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcore%2Fregistrycenter%2Futil%2FIpUtils.java#L63) | 3 | 76.0% |
   | [sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/synctask/history/HistoryDataSyncTask.java](https://coveralls.io/builds/29506153/source?filename=sharding-scaling%2Fsharding-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fcore%2Fsynctask%2Fhistory%2FHistoryDataSyncTask.java#L116) | 7 | 76.47% |
   | [sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/execute/executor/channel/MemoryChannel.java](https://coveralls.io/builds/29506153/source?filename=sharding-scaling%2Fsharding-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fcore%2Fexecute%2Fexecutor%2Fchannel%2FMemoryChannel.java#L61) | 8 | 51.85% |
   <!-- | **Total:** | **20** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29506153/badge)](https://coveralls.io/builds/29506153) |
   | :-- | --: |
   | Change from base [Build 1132](https://coveralls.io/builds/29504108): |  -0.2% |
   | Covered Lines: | 11889 |
   | Relevant Lines: | 20331 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] dongzl merged pull request #4870: Dynamic to introduce RouteDecorator

Posted by GitBox <gi...@apache.org>.
dongzl merged pull request #4870: Dynamic to introduce RouteDecorator
URL: https://github.com/apache/incubator-shardingsphere/pull/4870
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls commented on issue #4870: Dynamic to introduce RouteDecorator

Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4870: Dynamic to introduce RouteDecorator
URL: https://github.com/apache/incubator-shardingsphere/pull/4870#issuecomment-601816588
 
 
   ## Pull Request Test Coverage Report for [Build 2197](https://coveralls.io/builds/29505553)
   
   * **9** of **74**   **(12.16%)**  changed or added relevant lines in **8** files are covered.
   * **2** unchanged lines in **2** files lost coverage.
   * Overall coverage decreased (**-0.1%**) to **58.556%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [sharding-core/sharding-core-entry/src/main/java/org/apache/shardingsphere/core/shard/BaseShardingEngine.java](https://coveralls.io/builds/29505553/source?filename=sharding-core%2Fsharding-core-entry%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Fshard%2FBaseShardingEngine.java#L119) | 4 | 5 | 80.0%
   | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/communication/jdbc/wrapper/PreparedStatementExecutorWrapper.java](https://coveralls.io/builds/29505553/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fcommunication%2Fjdbc%2Fwrapper%2FPreparedStatementExecutorWrapper.java#L105) | 0 | 3 | 0.0%
   | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/communication/jdbc/wrapper/StatementExecutorWrapper.java](https://coveralls.io/builds/29505553/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fcommunication%2Fjdbc%2Fwrapper%2FStatementExecutorWrapper.java#L102) | 0 | 3 | 0.0%
   | [shardingsphere-underlying/shardingsphere-route/src/main/java/org/apache/shardingsphere/underlying/route/engine/DateNodeRouter.java](https://coveralls.io/builds/29505553/source?filename=shardingsphere-underlying%2Fshardingsphere-route%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Funderlying%2Froute%2Fengine%2FDateNodeRouter.java#L59) | 0 | 7 | 0.0%
   | [sharding-core/sharding-core-route/src/main/java/org/apache/shardingsphere/sharding/route/engine/ShardingRouteDecorator.java](https://coveralls.io/builds/29505553/source?filename=sharding-core%2Fsharding-core-route%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Froute%2Fengine%2FShardingRouteDecorator.java#L70) | 3 | 11 | 27.27%
   | [sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/statement/MasterSlavePreparedStatement.java](https://coveralls.io/builds/29505553/source?filename=sharding-jdbc%2Fsharding-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fjdbc%2Fcore%2Fstatement%2FMasterSlavePreparedStatement.java#L63) | 0 | 16 | 0.0%
   | [sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/statement/MasterSlaveStatement.java](https://coveralls.io/builds/29505553/source?filename=sharding-jdbc%2Fsharding-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fjdbc%2Fcore%2Fstatement%2FMasterSlaveStatement.java#L82) | 1 | 28 | 3.57%
   <!-- | **Total:** | **9** | **74** | **12.16%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [sharding-core/sharding-core-route/src/main/java/org/apache/shardingsphere/sharding/route/engine/ShardingRouteDecorator.java](https://coveralls.io/builds/29505553/source?filename=sharding-core%2Fsharding-core-route%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Froute%2Fengine%2FShardingRouteDecorator.java#L103) | 1 | 35.59% |
   | [shardingsphere-underlying/shardingsphere-route/src/main/java/org/apache/shardingsphere/underlying/route/engine/DateNodeRouter.java](https://coveralls.io/builds/29505553/source?filename=shardingsphere-underlying%2Fshardingsphere-route%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Funderlying%2Froute%2Fengine%2FDateNodeRouter.java#L80) | 1 | 0% |
   <!-- | **Total:** | **2** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29505553/badge)](https://coveralls.io/builds/29505553) |
   | :-- | --: |
   | Change from base [Build 1132](https://coveralls.io/builds/29504108): |  -0.1% |
   | Covered Lines: | 11905 |
   | Relevant Lines: | 20331 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services