[GitHub] [bookkeeper] eolivelli commented on a change in pull request #2963: Add throttle for rebuild entryMetadataMap

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #2963:
URL: https://github.com/apache/bookkeeper/pull/2963#discussion_r775127967



##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java
##########
@@ -1067,6 +1067,20 @@ public EntryLogMetadata getEntryLogMetadata(long entryLogId) throws IOException
         }
     }
 
+    public EntryLogMetadata getEntryLogMetadata(long entryLogId, AbstractLogCompactor.Throttler throttler)
+        throws IOException {
+        // First try to extract the EntryLogMetadata from the index, if there's no index then fallback to scanning the
+        // entry log
+        try {
+            return extractEntryLogMetadataFromIndex(entryLogId);
+        } catch (Exception e) {

Review comment:
       Can we catch specific exceptions here?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org