You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "brandboat (via GitHub)" <gi...@apache.org> on 2024/09/08 16:20:19 UTC
[PR] KAFKA-17224 Make ForeachProcessor internal [kafka]
brandboat opened a new pull request, #17129:
URL: https://github.com/apache/kafka/pull/17129
related to https://issues.apache.org/jira/browse/KAFKA-17224
> `ForeachProcessor` is in public package `org.apache.kafka.streams.kstream` but it's actually an internal class.
We should deprecate it and move into an internal package is a future release.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17224 Make ForeachProcessor internal [kafka]
Posted by "brandboat (via GitHub)" <gi...@apache.org>.
brandboat commented on code in PR #17129:
URL: https://github.com/apache/kafka/pull/17129#discussion_r1750381106
##########
streams/src/main/java/org/apache/kafka/streams/kstream/ForeachProcessor.java:
##########
@@ -19,6 +19,10 @@
import org.apache.kafka.streams.processor.api.Processor;
import org.apache.kafka.streams.processor.api.Record;
+/**
+ * @deprecated Since 4.0. Use {@link org.apache.kafka.streams.kstream.internals.ForeachProcessor} instead.
Review Comment:
Indeed, this class should be only for internal usage. I'll remove the description `Use {@link org.apache.kafka.streams.kstream.internals.ForeachProcessor} instead.`, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17224 Make ForeachProcessor internal [kafka]
Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax commented on code in PR #17129:
URL: https://github.com/apache/kafka/pull/17129#discussion_r1752406123
##########
streams/src/main/java/org/apache/kafka/streams/kstream/ForeachProcessor.java:
##########
@@ -19,6 +19,10 @@
import org.apache.kafka.streams.processor.api.Processor;
import org.apache.kafka.streams.processor.api.Record;
+/**
+ * @deprecated Since 4.0. Use {@link org.apache.kafka.streams.kstream.internals.ForeachProcessor} instead.
Review Comment:
This should till be a JavDoc -- not just a in-line comment.
```
/**
* @deprecates since 4.0 and should not be used any longer.
*/
```
Or something like this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17224 Make ForeachProcessor internal [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 merged PR #17129:
URL: https://github.com/apache/kafka/pull/17129
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17224 Make ForeachProcessor internal [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #17129:
URL: https://github.com/apache/kafka/pull/17129#discussion_r1752439861
##########
streams/src/main/java/org/apache/kafka/streams/kstream/ForeachProcessor.java:
##########
@@ -19,6 +19,10 @@
import org.apache.kafka.streams.processor.api.Processor;
import org.apache.kafka.streams.processor.api.Record;
+/**
+ * @deprecated Since 4.0. Use {@link org.apache.kafka.streams.kstream.internals.ForeachProcessor} instead.
Review Comment:
#17156
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17224 Make ForeachProcessor internal [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #17129:
URL: https://github.com/apache/kafka/pull/17129#discussion_r1750375038
##########
streams/src/main/java/org/apache/kafka/streams/kstream/ForeachProcessor.java:
##########
@@ -19,6 +19,10 @@
import org.apache.kafka.streams.processor.api.Processor;
import org.apache.kafka.streams.processor.api.Record;
+/**
+ * @deprecated Since 4.0. Use {@link org.apache.kafka.streams.kstream.internals.ForeachProcessor} instead.
Review Comment:
This description is a bit weird since we expect users should NOT use this class anymore. Also, user should NOT access the classes in `internals` package.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17224 Make ForeachProcessor internal [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #17129:
URL: https://github.com/apache/kafka/pull/17129#discussion_r1752417980
##########
streams/src/main/java/org/apache/kafka/streams/kstream/ForeachProcessor.java:
##########
@@ -19,6 +19,10 @@
import org.apache.kafka.streams.processor.api.Processor;
import org.apache.kafka.streams.processor.api.Record;
+/**
+ * @deprecated Since 4.0. Use {@link org.apache.kafka.streams.kstream.internals.ForeachProcessor} instead.
Review Comment:
@mjsax you are right. will file a follow-up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org