You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2023/01/12 18:35:16 UTC

[GitHub] [cloudstack] DaanHoogland opened a new pull request, #7088: errorprone

DaanHoogland opened a new pull request, #7088:
URL: https://github.com/apache/cloudstack/pull/7088

   ### Description
   
   This PR...
   <!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   <!--- ********************************************************************************* -->
   <!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
   <!--- PLEASE PUT AN 'X' in only **ONE** box -->
   <!--- ********************************************************************************* -->
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   - [x] CI/build
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   
   - [ ] Major
   - [ ] Minor
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [ ] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
   
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #7088: cleanups as suggested by errorprone

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7088:
URL: https://github.com/apache/cloudstack/pull/7088#issuecomment-1643478513

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #7088: cleanups as suggested by errorprone

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on code in PR #7088:
URL: https://github.com/apache/cloudstack/pull/7088#discussion_r1269086431


##########
utils/src/test/java/org/apache/cloudstack/utils/redfish/RedfishClientTest.java:
##########
@@ -87,15 +87,15 @@ public void validateAddressAndPrepareForUrlTestIpv6() {
     public void buildRequestUrlTestHttpsGetSystemId() {
         RedfishClient redfishclient = new RedfishClient(USERNAME, PASSWORD, true, false, REDFISHT_REQUEST_RETRIES);
         String result = redfishclient.buildRequestUrl(oobAddress, RedfishClient.RedfishCmdType.GetSystemId, systemId);
-        String expected = String.format("https://%s/redfish/v1/Systems/", oobAddress, systemId);

Review Comment:
   on second thought , I just assumed it worked with the resulting string so the parameter wasn't needed. No idea what redfish actually requires.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #7088: cleanups as suggested by errorprone

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7088:
URL: https://github.com/apache/cloudstack/pull/7088#issuecomment-1637518828

   @DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #7088: cleanups as suggested by errorprone

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7088:
URL: https://github.com/apache/cloudstack/pull/7088#issuecomment-1637517447

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #7088: cleanups as suggested by errorprone

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on code in PR #7088:
URL: https://github.com/apache/cloudstack/pull/7088#discussion_r1269103938


##########
utils/src/test/java/org/apache/cloudstack/utils/redfish/RedfishClientTest.java:
##########
@@ -87,15 +87,15 @@ public void validateAddressAndPrepareForUrlTestIpv6() {
     public void buildRequestUrlTestHttpsGetSystemId() {
         RedfishClient redfishclient = new RedfishClient(USERNAME, PASSWORD, true, false, REDFISHT_REQUEST_RETRIES);
         String result = redfishclient.buildRequestUrl(oobAddress, RedfishClient.RedfishCmdType.GetSystemId, systemId);
-        String expected = String.format("https://%s/redfish/v1/Systems/", oobAddress, systemId);
+        String expected = String.format("https://%s/redfish/v1/Systems/", oobAddress);
         Assert.assertEquals(expected, result);
     }
 
     @Test
     public void buildRequestUrlTestGetSystemId() {
         RedfishClient redfishclient = new RedfishClient(USERNAME, PASSWORD, false, false, REDFISHT_REQUEST_RETRIES);
         String result = redfishclient.buildRequestUrl(oobAddress, RedfishClient.RedfishCmdType.GetSystemId, systemId);
-        String expected = String.format("http://%s/redfish/v1/Systems/", oobAddress, systemId);
+        String expected = String.format("http://%s/redfish/v1/Systems/", oobAddress);

Review Comment:
   ```suggestion
           String expected = String.format("http://%s/redfish/v1/Systems/%s", oobAddress, systemId);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland closed pull request #7088: errorprone

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland closed pull request #7088: errorprone
URL: https://github.com/apache/cloudstack/pull/7088


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #7088: cleanups as suggested by errorprone

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7088:
URL: https://github.com/apache/cloudstack/pull/7088#issuecomment-1637584288

   Packaging result [SF]: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: el9 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 6491


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] codecov[bot] commented on pull request #7088: cleanups as suggested by errorprone

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #7088:
URL: https://github.com/apache/cloudstack/pull/7088#issuecomment-1639873782

   ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/7088?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   > Merging [#7088](https://app.codecov.io/gh/apache/cloudstack/pull/7088?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (a3a24ea) into [main](https://app.codecov.io/gh/apache/cloudstack/commit/c6237c48acac8b405e1f12492835c86ea33b9829?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (c6237c4) will **increase** coverage by `0.03%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@             Coverage Diff              @@
   ##               main    #7088      +/-   ##
   ============================================
   + Coverage     13.37%   13.41%   +0.03%     
   - Complexity     9321     9367      +46     
   ============================================
     Files          2740     2745       +5     
     Lines        258255   258683     +428     
     Branches      40237    40291      +54     
   ============================================
   + Hits          34542    34697     +155     
   - Misses       219353   219614     +261     
   - Partials       4360     4372      +12     
   ```
   
   
   [see 47 files with indirect coverage changes](https://app.codecov.io/gh/apache/cloudstack/pull/7088/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7088: cleanups as suggested by errorprone

Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on code in PR #7088:
URL: https://github.com/apache/cloudstack/pull/7088#discussion_r1269040176


##########
utils/src/test/java/org/apache/cloudstack/utils/redfish/RedfishClientTest.java:
##########
@@ -87,15 +87,15 @@ public void validateAddressAndPrepareForUrlTestIpv6() {
     public void buildRequestUrlTestHttpsGetSystemId() {
         RedfishClient redfishclient = new RedfishClient(USERNAME, PASSWORD, true, false, REDFISHT_REQUEST_RETRIES);
         String result = redfishclient.buildRequestUrl(oobAddress, RedfishClient.RedfishCmdType.GetSystemId, systemId);
-        String expected = String.format("https://%s/redfish/v1/Systems/", oobAddress, systemId);

Review Comment:
   should not `systemId` be a part of the string ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7088: cleanups as suggested by errorprone

Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on code in PR #7088:
URL: https://github.com/apache/cloudstack/pull/7088#discussion_r1269096636


##########
utils/src/test/java/org/apache/cloudstack/utils/redfish/RedfishClientTest.java:
##########
@@ -87,15 +87,15 @@ public void validateAddressAndPrepareForUrlTestIpv6() {
     public void buildRequestUrlTestHttpsGetSystemId() {
         RedfishClient redfishclient = new RedfishClient(USERNAME, PASSWORD, true, false, REDFISHT_REQUEST_RETRIES);
         String result = redfishclient.buildRequestUrl(oobAddress, RedfishClient.RedfishCmdType.GetSystemId, systemId);
-        String expected = String.format("https://%s/redfish/v1/Systems/", oobAddress, systemId);

Review Comment:
   I guess the pattern is `"https://%s/redfish/v1/Systems/%s"



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #7088: cleanups as suggested by errorprone

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7088:
URL: https://github.com/apache/cloudstack/pull/7088#issuecomment-1647674712

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #7088: errorprone

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7088:
URL: https://github.com/apache/cloudstack/pull/7088#issuecomment-1446101023

   no time to go through all the projects now, I will stop working on this for a while. I think it is worth the trouble though. Any additions/suggestions are welcome.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #7088: cleanups as suggested by errorprone

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7088:
URL: https://github.com/apache/cloudstack/pull/7088#issuecomment-1647676371

   @DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #7088: cleanups as suggested by errorprone

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7088:
URL: https://github.com/apache/cloudstack/pull/7088#issuecomment-1647682729

   Packaging result [SF]: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: el9 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 6548


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #7088: cleanups as suggested by errorprone

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on code in PR #7088:
URL: https://github.com/apache/cloudstack/pull/7088#discussion_r1269083535


##########
utils/src/test/java/org/apache/cloudstack/utils/redfish/RedfishClientTest.java:
##########
@@ -87,15 +87,15 @@ public void validateAddressAndPrepareForUrlTestIpv6() {
     public void buildRequestUrlTestHttpsGetSystemId() {
         RedfishClient redfishclient = new RedfishClient(USERNAME, PASSWORD, true, false, REDFISHT_REQUEST_RETRIES);
         String result = redfishclient.buildRequestUrl(oobAddress, RedfishClient.RedfishCmdType.GetSystemId, systemId);
-        String expected = String.format("https://%s/redfish/v1/Systems/", oobAddress, systemId);

Review Comment:
   hm, not intended change. I will investigate why this creeped in.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #7088: cleanups as suggested by errorprone

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7088:
URL: https://github.com/apache/cloudstack/pull/7088#issuecomment-1647700116

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #7088: cleanups as suggested by errorprone

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on code in PR #7088:
URL: https://github.com/apache/cloudstack/pull/7088#discussion_r1269103263


##########
utils/src/test/java/org/apache/cloudstack/utils/redfish/RedfishClientTest.java:
##########
@@ -87,15 +87,15 @@ public void validateAddressAndPrepareForUrlTestIpv6() {
     public void buildRequestUrlTestHttpsGetSystemId() {
         RedfishClient redfishclient = new RedfishClient(USERNAME, PASSWORD, true, false, REDFISHT_REQUEST_RETRIES);
         String result = redfishclient.buildRequestUrl(oobAddress, RedfishClient.RedfishCmdType.GetSystemId, systemId);
-        String expected = String.format("https://%s/redfish/v1/Systems/", oobAddress, systemId);
+        String expected = String.format("https://%s/redfish/v1/Systems/", oobAddress);

Review Comment:
   ```suggestion
           String expected = String.format("https://%s/redfish/v1/Systems/%s", oobAddress, systemId);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #7088: cleanups as suggested by errorprone

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7088:
URL: https://github.com/apache/cloudstack/pull/7088#issuecomment-1643480423

   @DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rohityadavcloud commented on pull request #7088: errorprone

Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #7088:
URL: https://github.com/apache/cloudstack/pull/7088#issuecomment-1609135710

   Thanks @DaanHoogland given we've sonar and codecov, we can revisit this in future; you may close the PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #7088: cleanups as suggested by errorprone

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on code in PR #7088:
URL: https://github.com/apache/cloudstack/pull/7088#discussion_r1272107143


##########
utils/src/test/java/org/apache/cloudstack/utils/redfish/RedfishClientTest.java:
##########
@@ -87,15 +87,15 @@ public void validateAddressAndPrepareForUrlTestIpv6() {
     public void buildRequestUrlTestHttpsGetSystemId() {
         RedfishClient redfishclient = new RedfishClient(USERNAME, PASSWORD, true, false, REDFISHT_REQUEST_RETRIES);
         String result = redfishclient.buildRequestUrl(oobAddress, RedfishClient.RedfishCmdType.GetSystemId, systemId);
-        String expected = String.format("https://%s/redfish/v1/Systems/", oobAddress, systemId);

Review Comment:
   @weizhouapache the tests actually fail this way. Not sure if this is a bug in the test or in the redfish code (`redfishclient.buildRequestUrl(oobAddress, RedfishClient.RedfishCmdType.GetSystemId, systemId);`)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7088: cleanups as suggested by errorprone

Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on code in PR #7088:
URL: https://github.com/apache/cloudstack/pull/7088#discussion_r1269096636


##########
utils/src/test/java/org/apache/cloudstack/utils/redfish/RedfishClientTest.java:
##########
@@ -87,15 +87,15 @@ public void validateAddressAndPrepareForUrlTestIpv6() {
     public void buildRequestUrlTestHttpsGetSystemId() {
         RedfishClient redfishclient = new RedfishClient(USERNAME, PASSWORD, true, false, REDFISHT_REQUEST_RETRIES);
         String result = redfishclient.buildRequestUrl(oobAddress, RedfishClient.RedfishCmdType.GetSystemId, systemId);
-        String expected = String.format("https://%s/redfish/v1/Systems/", oobAddress, systemId);

Review Comment:
   I guess the pattern is `"https://%s/redfish/v1/Systems/%s"`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] cleanups as suggested by errorprone [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7088:
URL: https://github.com/apache/cloudstack/pull/7088#issuecomment-1744638162

   @DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] cleanups as suggested by errorprone [cloudstack]

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7088:
URL: https://github.com/apache/cloudstack/pull/7088#issuecomment-1744846720

   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] cleanups as suggested by errorprone [cloudstack]

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland merged PR #7088:
URL: https://github.com/apache/cloudstack/pull/7088


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] cleanups as suggested by errorprone [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7088:
URL: https://github.com/apache/cloudstack/pull/7088#issuecomment-1744735051

   Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_multiplication_x: debian :heavy_check_mark: suse15. SL-JID 7210


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rohityadavcloud commented on pull request #7088: errorprone

Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #7088:
URL: https://github.com/apache/cloudstack/pull/7088#issuecomment-1537877622

   @DaanHoogland if codecov, sonar are enough should we drop this? I had proposed this but recently I've found the project backers were let go and this may require more effort than initially thought.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland closed pull request #7088: cleanups as suggested by errorprone

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland closed pull request #7088: cleanups as suggested by errorprone
URL: https://github.com/apache/cloudstack/pull/7088


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #7088: cleanups as suggested by errorprone

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7088:
URL: https://github.com/apache/cloudstack/pull/7088#issuecomment-1647824310

   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #7088: cleanups as suggested by errorprone

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7088:
URL: https://github.com/apache/cloudstack/pull/7088#issuecomment-1640197754

   <b>[SF] Trillian test result (tid-7109)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 798 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7088-t7109-kvm-centos7.zip
   Smoke tests completed. 0 look OK, 0 have errors, 113 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   all_test_safe_shutdown | `Skipped` | --- | test_safe_shutdown.py
   all_test_scale_vm | `Skipped` | --- | test_scale_vm.py
   all_test_2fa | `Skipped` | --- | test_2fa.py
   all_test_regions | `Skipped` | --- | test_regions.py
   all_test_accounts | `Skipped` | --- | test_accounts.py
   all_test_nonstrict_affinity_group | `Skipped` | --- | test_nonstrict_affinity_group.py
   all_test_affinity_groups | `Skipped` | --- | test_affinity_groups.py
   all_test_internal_lb | `Skipped` | --- | test_internal_lb.py
   all_test_usage | `Skipped` | --- | test_usage.py
   all_test_affinity_groups_projects | `Skipped` | --- | test_affinity_groups_projects.py
   all_test_register_userdata | `Skipped` | --- | test_register_userdata.py
   all_test_annotations | `Skipped` | --- | test_annotations.py
   all_test_reset_vm_on_reboot | `Skipped` | --- | test_reset_vm_on_reboot.py
   all_test_async_job | `Skipped` | --- | test_async_job.py
   all_test_ipv6_infra | `Skipped` | --- | test_ipv6_infra.py
   all_test_attach_multiple_volumes | `Skipped` | --- | test_attach_multiple_volumes.py
   all_test_kubernetes_clusters | `Skipped` | --- | test_kubernetes_clusters.py
   all_test_backup_recovery_dummy | `Skipped` | --- | test_backup_recovery_dummy.py
   all_test_outofbandmanagement | `Skipped` | --- | test_outofbandmanagement.py
   all_test_certauthority_root | `Skipped` | --- | test_certauthority_root.py
   all_test_over_provisioning | `Skipped` | --- | test_over_provisioning.py
   all_test_console_endpoint | `Skipped` | --- | test_console_endpoint.py
   all_test_set_sourcenat | `Skipped` | --- | test_set_sourcenat.py
   all_test_create_list_domain_account_project | `Skipped` | --- | test_create_list_domain_account_project.py
   all_test_password_server | `Skipped` | --- | test_password_server.py
   all_test_create_network | `Skipped` | --- | test_create_network.py
   all_test_iso | `Skipped` | --- | test_iso.py
   all_test_snapshots | `Skipped` | --- | test_snapshots.py
   all_test_deploy_vgpu_enabled_vm | `Skipped` | --- | test_deploy_vgpu_enabled_vm.py
   all_test_migration | `Skipped` | --- | test_migration.py
   all_test_deploy_virtio_scsi_vm | `Skipped` | --- | test_deploy_virtio_scsi_vm.py
   all_test_multipleips_per_nic | `Skipped` | --- | test_multipleips_per_nic.py
   all_test_deploy_vm_extra_config_data | `Skipped` | --- | test_deploy_vm_extra_config_data.py
   all_test_persistent_network | `Skipped` | --- | test_persistent_network.py
   all_test_deploy_vm_iso | `Skipped` | --- | test_deploy_vm_iso.py
   all_test_portable_publicip | `Skipped` | --- | test_portable_publicip.py
   all_test_deploy_vm_iso_uefi | `Skipped` | --- | test_deploy_vm_iso_uefi.py
   all_test_nested_virtualization | `Skipped` | --- | test_nested_virtualization.py
   all_test_deploy_vm_root_resize | `Skipped` | --- | test_deploy_vm_root_resize.py
   all_test_network | `Skipped` | --- | test_network.py
   all_test_deploy_vm_with_userdata | `Skipped` | --- | test_deploy_vm_with_userdata.py
   all_test_network_acl | `Skipped` | --- | test_network_acl.py
   all_test_deploy_vms_in_parallel | `Skipped` | --- | test_deploy_vms_in_parallel.py
   all_test_ssvm | `Skipped` | --- | test_ssvm.py
   all_test_deploy_vms_with_varied_deploymentplanners | `Skipped` | --- | test_deploy_vms_with_varied_deploymentplanners.py
   all_test_resource_accounting | `Skipped` | --- | test_resource_accounting.py
   all_test_diagnostics | `Skipped` | --- | test_diagnostics.py
   all_test_portforwardingrules | `Skipped` | --- | test_portforwardingrules.py
   all_test_direct_download | `Skipped` | --- | test_direct_download.py
   all_test_primary_storage | `Skipped` | --- | test_primary_storage.py
   all_test_disk_offerings | `Skipped` | --- | test_disk_offerings.py
   all_test_network_ipv6 | `Skipped` | --- | test_network_ipv6.py
   all_test_disk_provisioning_types | `Skipped` | --- | test_disk_provisioning_types.py
   all_test_network_permissions | `Skipped` | --- | test_network_permissions.py
   all_test_domain_disk_offerings | `Skipped` | --- | test_domain_disk_offerings.py
   all_test_nic | `Skipped` | --- | test_nic.py
   all_test_staticroles | `Skipped` | --- | test_staticroles.py
   all_test_domain_network_offerings | `Skipped` | --- | test_domain_network_offerings.py
   all_test_nic_adapter_type | `Skipped` | --- | test_nic_adapter_type.py
   all_test_domain_service_offerings | `Skipped` | --- | test_domain_service_offerings.py
   all_test_private_roles | `Skipped` | --- | test_private_roles.py
   all_test_domain_vpc_offerings | `Skipped` | --- | test_domain_vpc_offerings.py
   all_test_resource_detail | `Skipped` | --- | test_resource_detail.py
   all_test_dynamicroles | `Skipped` | --- | test_dynamicroles.py
   all_test_hostha_simulator | `Skipped` | --- | test_hostha_simulator.py
   all_test_enable_account_settings_for_domain | `Skipped` | --- | test_enable_account_settings_for_domain.py
   all_test_human_readable_logs | `Skipped` | --- | test_human_readable_logs.py
   all_test_enable_role_based_users_in_projects | `Skipped` | --- | test_enable_role_based_users_in_projects.py
   all_test_privategw_acl | `Skipped` | --- | test_privategw_acl.py
   all_test_events_resource | `Skipped` | --- | test_events_resource.py
   all_test_non_contigiousvlan | `Skipped` | --- | test_non_contigiousvlan.py
   all_test_gateway_on_shared_networks | `Skipped` | --- | test_gateway_on_shared_networks.py
   all_test_privategw_acl_ovs_gre | `Skipped` | --- | test_privategw_acl_ovs_gre.py
   all_test_global_settings | `Skipped` | --- | test_global_settings.py
   all_test_router_dhcphosts | `Skipped` | --- | test_router_dhcphosts.py
   all_test_guest_os | `Skipped` | --- | test_guest_os.py
   all_test_projects | `Skipped` | --- | test_projects.py
   all_test_guest_vlan_range | `Skipped` | --- | test_guest_vlan_range.py
   all_test_public_ip_range | `Skipped` | --- | test_public_ip_range.py
   all_test_host_control_state | `Skipped` | --- | test_host_control_state.py
   all_test_kubernetes_supported_versions | `Skipped` | --- | test_kubernetes_supported_versions.py
   all_test_pvlan | `Skipped` | --- | test_pvlan.py
   all_test_list_ids_parameter | `Skipped` | --- | test_list_ids_parameter.py
   all_test_router_dns | `Skipped` | --- | test_router_dns.py
   all_test_loadbalance | `Skipped` | --- | test_loadbalance.py
   all_test_router_dnsservice | `Skipped` | --- | test_router_dnsservice.py
   all_test_login | `Skipped` | --- | test_login.py
   all_test_routers | `Skipped` | --- | test_routers.py
   all_test_metrics_api | `Skipped` | --- | test_metrics_api.py
   all_test_routers_network_ops | `Skipped` | --- | test_routers_network_ops.py
   all_test_outofbandmanagement_nestedplugin | `Skipped` | --- | test_outofbandmanagement_nestedplugin.py
   all_test_reset_configuration_settings | `Skipped` | --- | test_reset_configuration_settings.py
   all_test_routers_iptables_default_policy | `Skipped` | --- | test_routers_iptables_default_policy.py
   all_test_secondary_storage | `Skipped` | --- | test_secondary_storage.py
   all_test_service_offerings | `Skipped` | --- | test_service_offerings.py
   all_test_storage_policy | `Skipped` | --- | test_storage_policy.py
   all_test_templates | `Skipped` | --- | test_templates.py
   all_test_update_security_group | `Skipped` | --- | test_update_security_group.py
   all_test_usage_events | `Skipped` | --- | test_usage_events.py
   all_test_vm_autoscaling | `Skipped` | --- | test_vm_autoscaling.py
   all_test_vm_deployment_planner | `Skipped` | --- | test_vm_deployment_planner.py
   all_test_vm_life_cycle | `Skipped` | --- | test_vm_life_cycle.py
   all_test_vm_lifecycle_unmanage_import | `Skipped` | --- | test_vm_lifecycle_unmanage_import.py
   all_test_vm_schedule | `Skipped` | --- | test_vm_schedule.py
   all_test_vm_snapshot_kvm | `Skipped` | --- | test_vm_snapshot_kvm.py
   all_test_vm_snapshots | `Skipped` | --- | test_vm_snapshots.py
   all_test_volumes | `Skipped` | --- | test_volumes.py
   all_test_vpc_ipv6 | `Skipped` | --- | test_vpc_ipv6.py
   all_test_vpc_redundant | `Skipped` | --- | test_vpc_redundant.py
   all_test_vpc_router_nics | `Skipped` | --- | test_vpc_router_nics.py
   all_test_vpc_vpn | `Skipped` | --- | test_vpc_vpn.py
   all_test_host_maintenance | `Skipped` | --- | test_host_maintenance.py
   all_test_hostha_kvm | `Skipped` | --- | test_hostha_kvm.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #7088: cleanups as suggested by errorprone

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7088:
URL: https://github.com/apache/cloudstack/pull/7088#issuecomment-1639973294

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #7088: cleanups as suggested by errorprone

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7088:
URL: https://github.com/apache/cloudstack/pull/7088#issuecomment-1640117067

   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #7088: cleanups as suggested by errorprone

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7088:
URL: https://github.com/apache/cloudstack/pull/7088#issuecomment-1647776007

   Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6549


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #7088: cleanups as suggested by errorprone

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7088:
URL: https://github.com/apache/cloudstack/pull/7088#issuecomment-1639974977

   @DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #7088: cleanups as suggested by errorprone

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7088:
URL: https://github.com/apache/cloudstack/pull/7088#issuecomment-1640120451

   @DaanHoogland a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #7088: cleanups as suggested by errorprone

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7088:
URL: https://github.com/apache/cloudstack/pull/7088#issuecomment-1641727266

   <b>[SF] Trillian test result (tid-7114)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 743 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7088-t7114-kvm-centos7.zip
   Smoke tests completed. 0 look OK, 0 have errors, 113 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   all_test_safe_shutdown | `Skipped` | --- | test_safe_shutdown.py
   all_test_scale_vm | `Skipped` | --- | test_scale_vm.py
   all_test_2fa | `Skipped` | --- | test_2fa.py
   all_test_regions | `Skipped` | --- | test_regions.py
   all_test_accounts | `Skipped` | --- | test_accounts.py
   all_test_nonstrict_affinity_group | `Skipped` | --- | test_nonstrict_affinity_group.py
   all_test_affinity_groups | `Skipped` | --- | test_affinity_groups.py
   all_test_internal_lb | `Skipped` | --- | test_internal_lb.py
   all_test_usage | `Skipped` | --- | test_usage.py
   all_test_affinity_groups_projects | `Skipped` | --- | test_affinity_groups_projects.py
   all_test_register_userdata | `Skipped` | --- | test_register_userdata.py
   all_test_annotations | `Skipped` | --- | test_annotations.py
   all_test_reset_vm_on_reboot | `Skipped` | --- | test_reset_vm_on_reboot.py
   all_test_async_job | `Skipped` | --- | test_async_job.py
   all_test_ipv6_infra | `Skipped` | --- | test_ipv6_infra.py
   all_test_attach_multiple_volumes | `Skipped` | --- | test_attach_multiple_volumes.py
   all_test_kubernetes_clusters | `Skipped` | --- | test_kubernetes_clusters.py
   all_test_backup_recovery_dummy | `Skipped` | --- | test_backup_recovery_dummy.py
   all_test_outofbandmanagement | `Skipped` | --- | test_outofbandmanagement.py
   all_test_certauthority_root | `Skipped` | --- | test_certauthority_root.py
   all_test_over_provisioning | `Skipped` | --- | test_over_provisioning.py
   all_test_console_endpoint | `Skipped` | --- | test_console_endpoint.py
   all_test_set_sourcenat | `Skipped` | --- | test_set_sourcenat.py
   all_test_create_list_domain_account_project | `Skipped` | --- | test_create_list_domain_account_project.py
   all_test_password_server | `Skipped` | --- | test_password_server.py
   all_test_create_network | `Skipped` | --- | test_create_network.py
   all_test_iso | `Skipped` | --- | test_iso.py
   all_test_snapshots | `Skipped` | --- | test_snapshots.py
   all_test_deploy_vgpu_enabled_vm | `Skipped` | --- | test_deploy_vgpu_enabled_vm.py
   all_test_migration | `Skipped` | --- | test_migration.py
   all_test_deploy_virtio_scsi_vm | `Skipped` | --- | test_deploy_virtio_scsi_vm.py
   all_test_multipleips_per_nic | `Skipped` | --- | test_multipleips_per_nic.py
   all_test_deploy_vm_extra_config_data | `Skipped` | --- | test_deploy_vm_extra_config_data.py
   all_test_persistent_network | `Skipped` | --- | test_persistent_network.py
   all_test_deploy_vm_iso | `Skipped` | --- | test_deploy_vm_iso.py
   all_test_portable_publicip | `Skipped` | --- | test_portable_publicip.py
   all_test_deploy_vm_iso_uefi | `Skipped` | --- | test_deploy_vm_iso_uefi.py
   all_test_nested_virtualization | `Skipped` | --- | test_nested_virtualization.py
   all_test_deploy_vm_root_resize | `Skipped` | --- | test_deploy_vm_root_resize.py
   all_test_network | `Skipped` | --- | test_network.py
   all_test_deploy_vm_with_userdata | `Skipped` | --- | test_deploy_vm_with_userdata.py
   all_test_network_acl | `Skipped` | --- | test_network_acl.py
   all_test_deploy_vms_in_parallel | `Skipped` | --- | test_deploy_vms_in_parallel.py
   all_test_ssvm | `Skipped` | --- | test_ssvm.py
   all_test_deploy_vms_with_varied_deploymentplanners | `Skipped` | --- | test_deploy_vms_with_varied_deploymentplanners.py
   all_test_resource_accounting | `Skipped` | --- | test_resource_accounting.py
   all_test_diagnostics | `Skipped` | --- | test_diagnostics.py
   all_test_portforwardingrules | `Skipped` | --- | test_portforwardingrules.py
   all_test_direct_download | `Skipped` | --- | test_direct_download.py
   all_test_primary_storage | `Skipped` | --- | test_primary_storage.py
   all_test_disk_offerings | `Skipped` | --- | test_disk_offerings.py
   all_test_network_ipv6 | `Skipped` | --- | test_network_ipv6.py
   all_test_disk_provisioning_types | `Skipped` | --- | test_disk_provisioning_types.py
   all_test_network_permissions | `Skipped` | --- | test_network_permissions.py
   all_test_domain_disk_offerings | `Skipped` | --- | test_domain_disk_offerings.py
   all_test_nic | `Skipped` | --- | test_nic.py
   all_test_staticroles | `Skipped` | --- | test_staticroles.py
   all_test_domain_network_offerings | `Skipped` | --- | test_domain_network_offerings.py
   all_test_nic_adapter_type | `Skipped` | --- | test_nic_adapter_type.py
   all_test_domain_service_offerings | `Skipped` | --- | test_domain_service_offerings.py
   all_test_private_roles | `Skipped` | --- | test_private_roles.py
   all_test_domain_vpc_offerings | `Skipped` | --- | test_domain_vpc_offerings.py
   all_test_resource_detail | `Skipped` | --- | test_resource_detail.py
   all_test_dynamicroles | `Skipped` | --- | test_dynamicroles.py
   all_test_hostha_simulator | `Skipped` | --- | test_hostha_simulator.py
   all_test_enable_account_settings_for_domain | `Skipped` | --- | test_enable_account_settings_for_domain.py
   all_test_human_readable_logs | `Skipped` | --- | test_human_readable_logs.py
   all_test_enable_role_based_users_in_projects | `Skipped` | --- | test_enable_role_based_users_in_projects.py
   all_test_privategw_acl | `Skipped` | --- | test_privategw_acl.py
   all_test_events_resource | `Skipped` | --- | test_events_resource.py
   all_test_non_contigiousvlan | `Skipped` | --- | test_non_contigiousvlan.py
   all_test_gateway_on_shared_networks | `Skipped` | --- | test_gateway_on_shared_networks.py
   all_test_privategw_acl_ovs_gre | `Skipped` | --- | test_privategw_acl_ovs_gre.py
   all_test_global_settings | `Skipped` | --- | test_global_settings.py
   all_test_router_dhcphosts | `Skipped` | --- | test_router_dhcphosts.py
   all_test_guest_os | `Skipped` | --- | test_guest_os.py
   all_test_projects | `Skipped` | --- | test_projects.py
   all_test_guest_vlan_range | `Skipped` | --- | test_guest_vlan_range.py
   all_test_public_ip_range | `Skipped` | --- | test_public_ip_range.py
   all_test_host_control_state | `Skipped` | --- | test_host_control_state.py
   all_test_kubernetes_supported_versions | `Skipped` | --- | test_kubernetes_supported_versions.py
   all_test_pvlan | `Skipped` | --- | test_pvlan.py
   all_test_list_ids_parameter | `Skipped` | --- | test_list_ids_parameter.py
   all_test_router_dns | `Skipped` | --- | test_router_dns.py
   all_test_loadbalance | `Skipped` | --- | test_loadbalance.py
   all_test_router_dnsservice | `Skipped` | --- | test_router_dnsservice.py
   all_test_login | `Skipped` | --- | test_login.py
   all_test_routers | `Skipped` | --- | test_routers.py
   all_test_metrics_api | `Skipped` | --- | test_metrics_api.py
   all_test_routers_network_ops | `Skipped` | --- | test_routers_network_ops.py
   all_test_outofbandmanagement_nestedplugin | `Skipped` | --- | test_outofbandmanagement_nestedplugin.py
   all_test_reset_configuration_settings | `Skipped` | --- | test_reset_configuration_settings.py
   all_test_routers_iptables_default_policy | `Skipped` | --- | test_routers_iptables_default_policy.py
   all_test_secondary_storage | `Skipped` | --- | test_secondary_storage.py
   all_test_service_offerings | `Skipped` | --- | test_service_offerings.py
   all_test_storage_policy | `Skipped` | --- | test_storage_policy.py
   all_test_templates | `Skipped` | --- | test_templates.py
   all_test_update_security_group | `Skipped` | --- | test_update_security_group.py
   all_test_usage_events | `Skipped` | --- | test_usage_events.py
   all_test_vm_autoscaling | `Skipped` | --- | test_vm_autoscaling.py
   all_test_vm_deployment_planner | `Skipped` | --- | test_vm_deployment_planner.py
   all_test_vm_life_cycle | `Skipped` | --- | test_vm_life_cycle.py
   all_test_vm_lifecycle_unmanage_import | `Skipped` | --- | test_vm_lifecycle_unmanage_import.py
   all_test_vm_schedule | `Skipped` | --- | test_vm_schedule.py
   all_test_vm_snapshot_kvm | `Skipped` | --- | test_vm_snapshot_kvm.py
   all_test_vm_snapshots | `Skipped` | --- | test_vm_snapshots.py
   all_test_volumes | `Skipped` | --- | test_volumes.py
   all_test_vpc_ipv6 | `Skipped` | --- | test_vpc_ipv6.py
   all_test_vpc_redundant | `Skipped` | --- | test_vpc_redundant.py
   all_test_vpc_router_nics | `Skipped` | --- | test_vpc_router_nics.py
   all_test_vpc_vpn | `Skipped` | --- | test_vpc_vpn.py
   all_test_host_maintenance | `Skipped` | --- | test_host_maintenance.py
   all_test_hostha_kvm | `Skipped` | --- | test_hostha_kvm.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #7088: cleanups as suggested by errorprone

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7088:
URL: https://github.com/apache/cloudstack/pull/7088#issuecomment-1641553112

   <b>[SF] Trillian test result (tid-7110)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 46064 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7088-t7110-kvm-centos7.zip
   Smoke tests completed. 111 look OK, 2 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_migrate_VM_and_root_volume | `Error` | 81.64 | test_vm_life_cycle.py
   test_02_migrate_VM_with_two_data_disks | `Error` | 56.40 | test_vm_life_cycle.py
   test_02_redundant_VPC_default_routes | `Failure` | 370.32 | test_vpc_redundant.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #7088: cleanups as suggested by errorprone

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7088:
URL: https://github.com/apache/cloudstack/pull/7088#issuecomment-1642801295

   <b>[SF] Trillian test result (tid-7117)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 43434 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7088-t7117-kvm-centos7.zip
   Smoke tests completed. 112 look OK, 1 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_migrate_VM_and_root_volume | `Error` | 77.74 | test_vm_life_cycle.py
   test_02_migrate_VM_with_two_data_disks | `Error` | 53.41 | test_vm_life_cycle.py
   test_04_nonsecured_to_secured_vm_migration | `Error` | 199.16 | test_vm_life_cycle.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] cleanups as suggested by errorprone [cloudstack]

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7088:
URL: https://github.com/apache/cloudstack/pull/7088#issuecomment-1744635674

   let's test again
   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #7088: errorprone

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7088:
URL: https://github.com/apache/cloudstack/pull/7088#issuecomment-1538065912

   > @DaanHoogland if codecov, sonar are enough should we drop this? I had proposed this but recently I've found the project backers were let go and this may require more effort than initially thought.
   
   That is too bad, but if so, we should drop it or change the code to not require errorprone. I think most of the changes on code are legit, so we could revert just the pom and leave the rest so far in.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #7088: cleanups as suggested by errorprone

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7088:
URL: https://github.com/apache/cloudstack/pull/7088#issuecomment-1647828400

   @DaanHoogland a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #7088: cleanups as suggested by errorprone

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7088:
URL: https://github.com/apache/cloudstack/pull/7088#issuecomment-1648791226

   <b>[SF] Trillian test result (tid-7148)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 41002 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7088-t7148-kvm-centos7.zip
   Smoke tests completed. 112 look OK, 1 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_migrate_VM_and_root_volume | `Error` | 79.74 | test_vm_life_cycle.py
   test_02_migrate_VM_with_two_data_disks | `Error` | 52.41 | test_vm_life_cycle.py
   test_01_secure_vm_migration | `Error` | 151.20 | test_vm_life_cycle.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #7088: cleanups as suggested by errorprone

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7088:
URL: https://github.com/apache/cloudstack/pull/7088#issuecomment-1647702746

   @DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] cleanups as suggested by errorprone [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7088:
URL: https://github.com/apache/cloudstack/pull/7088#issuecomment-1744848157

   @DaanHoogland a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] cleanups as suggested by errorprone [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7088:
URL: https://github.com/apache/cloudstack/pull/7088#issuecomment-1746022436

   <b>[SF] Trillian test result (tid-7824)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 48470 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7088-t7824-kvm-centos7.zip
   Smoke tests completed. 112 look OK, 1 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_05_vmschedule_test_e2e | `Failure` | 270.98 | test_vm_schedule.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #7088: cleanups as suggested by errorprone

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7088:
URL: https://github.com/apache/cloudstack/pull/7088#issuecomment-1640047551

   Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6503


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org