You are viewing a plain text version of this content. The canonical link for it is here.
Posted to discuss-archive@tvm.apache.org by "guan404ming (via GitHub)" <gi...@apache.org> on 2026/01/02 08:07:30 UTC
[PR] chore: fix compiler warnings [tvm-ffi]
guan404ming opened a new pull request, #378:
URL: https://github.com/apache/tvm-ffi/pull/378
## Why
- Unused parameter `num_args` in `GetMismatchMessageAux` template function
- Extra semicolon after `TVM_FFI_DLL_EXPORT_TYPED_FUNC` macro call
## How
- Add `[[maybe_unused]]` attribute to `num_args` param
- Remove trailing semicolon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: discuss-archive-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: discuss-archive-unsubscribe@tvm.apache.org
For additional commands, e-mail: discuss-archive-help@tvm.apache.org
Re: [PR] chore: fix compiler warnings [tvm-ffi]
Posted by "guan404ming (via GitHub)" <gi...@apache.org>.
guan404ming commented on PR #378:
URL: https://github.com/apache/tvm-ffi/pull/378#issuecomment-3704805237
> here are quite a few TVM_FFI_DLL_EXPORT_TYPED_FUNCs in testing.cc, test_stl.cc, and many other places
Sure, I've removed them. Thanks!
> Does the warnings come from MSVC btw?
The warning is from GCC with -Wpedantic, not MSVC.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: discuss-archive-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: discuss-archive-unsubscribe@tvm.apache.org
For additional commands, e-mail: discuss-archive-help@tvm.apache.org
Re: [PR] chore: fix compiler warnings [tvm-ffi]
Posted by "gemini-code-assist[bot] (via GitHub)" <gi...@apache.org>.
gemini-code-assist[bot] commented on code in PR #378:
URL: https://github.com/apache/tvm-ffi/pull/378#discussion_r2657035818
##########
include/tvm/ffi/reflection/overload.h:
##########
@@ -145,7 +145,8 @@ struct TypedOverload : OverloadBase {
private:
template <std::size_t I>
- void GetMismatchMessageAux(std::ostringstream& os, const AnyView* args, int32_t num_args) {
+ void GetMismatchMessageAux(std::ostringstream& os, const AnyView* args,
+ [[maybe_unused]] int32_t num_args) {
Review Comment:

While `[[maybe_unused]]` correctly suppresses the compiler warning, a cleaner solution would be to remove the `num_args` parameter from `GetMismatchMessageAux` entirely, as it is not used. This would improve code clarity by removing the unneeded parameter and would require updating its call sites.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: discuss-archive-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: discuss-archive-unsubscribe@tvm.apache.org
For additional commands, e-mail: discuss-archive-help@tvm.apache.org
Re: [PR] chore: fix compiler warnings [tvm-ffi]
Posted by "junrushao (via GitHub)" <gi...@apache.org>.
junrushao merged PR #378:
URL: https://github.com/apache/tvm-ffi/pull/378
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: discuss-archive-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: discuss-archive-unsubscribe@tvm.apache.org
For additional commands, e-mail: discuss-archive-help@tvm.apache.org
Re: [PR] chore: fix compiler warnings [tvm-ffi]
Posted by "gemini-code-assist[bot] (via GitHub)" <gi...@apache.org>.
gemini-code-assist[bot] commented on PR #378:
URL: https://github.com/apache/tvm-ffi/pull/378#issuecomment-3704714262
## Summary of Changes
Hello @guan404ming, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on code hygiene by addressing minor compiler warnings. The changes involve marking an unused function parameter with `[[maybe_unused]]` and removing an extraneous semicolon after a macro call. These adjustments improve code quality and reduce compilation noise without altering functionality.
### Highlights
* **Unused Parameter Warning**: The `num_args` parameter in the `GetMismatchMessageAux` template function within `include/tvm/ffi/reflection/overload.h` has been marked with the `[[maybe_unused]]` attribute to suppress compiler warnings about its non-usage.
* **Extraneous Semicolon Warning**: An unnecessary trailing semicolon after the `TVM_FFI_DLL_EXPORT_TYPED_FUNC` macro call in `tests/cpp/test_function.cc` has been removed, resolving a compiler warning.
🧠**New Feature in Public Preview:** You can now enable **Memory** to help **Gemini Code Assist** learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. **Click [here](https://codeassist.google/code-review/login) to enable Memory in your admin console.**
<details>
<summary><b>Using Gemini Code Assist</b></summary>
<br>
The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips.
<b>Invoking Gemini</b>
You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page.
Feature | Command | Description
--- | --- | ---
Code Review | `/gemini review` | Performs a code review for the current pull request in its current state.
Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state.
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help | `/gemini help` | Displays a list of available commands.
<b>Customization</b>
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github).
<b>Limitations & Feedback</b>
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG).
<b>You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the [Gemini Code Assist IDE Extension](https://cloud.google.com/products/gemini/code-assist).</b>
</details>
[^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: discuss-archive-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: discuss-archive-unsubscribe@tvm.apache.org
For additional commands, e-mail: discuss-archive-help@tvm.apache.org
Re: [PR] chore: fix compiler warnings [tvm-ffi]
Posted by "junrushao (via GitHub)" <gi...@apache.org>.
junrushao commented on PR #378:
URL: https://github.com/apache/tvm-ffi/pull/378#issuecomment-3704774587
BTW, there are quite a few `TVM_FFI_DLL_EXPORT_TYPED_FUNC`s in `testing.cc`, `test_stl.cc`, and many other places, do you intend to remove all of them? Does the warnings come from MSVC btw?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: discuss-archive-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: discuss-archive-unsubscribe@tvm.apache.org
For additional commands, e-mail: discuss-archive-help@tvm.apache.org