[jira] [Comment Edited] (SQOOP-1589) Sqoop2: Create common constants, error codes, and queries

["Veena Basavaraj (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SQOOP-1589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14182829#comment-14182829 ] 

Veena Basavaraj edited comment on SQOOP-1589 at 10/24/14 2:24 PM:
------------------------------------------------------------------

I am +1 for sharing JDBC code. But as far as the queries go, they will have syntactic differences across different DB implementations, dont they? I would rather prefer having MSSQL/ POSTGRES/ DErBY queries separate.

A neat thing we can do is actually have a query file per entity we have, so that it is really neat and clean to scale. We wont end up in one big gigantic class where it is hard to follow.

Slightly Unrelated, should have posted in the postgres repo ticket, but nevertheless..
Second, we should really think hard on how we will do upgrade logic and its testing. The current Derby implementation is very brittle and as a newbie to SQOOP I found it really hard.

[~abec] himself agrees that this code is brittle, are we going to do do anything better for postgres?


was (Author: vybs):
I am +1 for sharing JSBC . But as far as the queries go, they will have syntactic differences across different DB implementations, dont they? I would rather prefer having MSSQL/ POSTGRES/ DErBY queries separate.

A neat thing we can do is actually have a query file per entity we have, so that it is really neat and clean to scale. We wont end up in one big gigantic class where it is hard to follow.

Second, we should really think hard on how we will do upgrade logic and its testing. The current Derby implementation is very brittle and as a newbie to SQOOP I found it really hard.

[~abec] himself agrees that this code is brittle, are we going to do do anything better for postgres?

> Sqoop2: Create common constants, error codes, and queries
> ---------------------------------------------------------
>
>                 Key: SQOOP-1589
>                 URL: https://issues.apache.org/jira/browse/SQOOP-1589
>             Project: Sqoop
>          Issue Type: Sub-task
>          Components: sqoop2-postgresql-repository
>            Reporter: Abraham Elmahrek
>            Assignee: Abraham Elmahrek
>         Attachments: SQOOP-1589.0.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)