You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "John Sisson (JIRA)" <de...@geronimo.apache.org> on 2005/07/06 06:09:12 UTC

[jira] Created: (GERONIMO-713) class loader server currently cannot run on Tomcat (requires Jetty)

class loader server currently cannot run on Tomcat (requires Jetty)
-------------------------------------------------------------------

         Key: GERONIMO-713
         URL: http://issues.apache.org/jira/browse/GERONIMO-713
     Project: Geronimo
        Type: Task
  Components: Tomcat  
    Reporter: John Sisson


The j2ee-remote-classloading-deployer-plan.xml is currently Jetty specific.  It specifes the class org.apache.geronimo.classloaderserver.http.HTTPClassLoaderServer, which uses Jetty classes.

It looks like a Tomcat version of the class loader server needs to be developed.

For a description of remote class loading, see http://svn.apache.org/viewcvs?view=rev&rev=158589

Once implemented, the wiki page http://wiki.apache.org/geronimo/Tomcat  needs to be updated.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Re: [jira] Created: (GERONIMO-713) class loader server currently cannot run on Tomcat (requires Jetty)

Posted by Jeff Genender <jg...@savoirtech.com>.
Yes...unless I fix it before hand.

We are going to need a unified HTTPClassLoaderServer. Its using some 
Jetty specific calls and objects (HTTPContext, addContext, etc).  I am 
looking to see what needs to be done to make this a bit more generic.

Jeff

sissonj@insession.com wrote:
> I think this issue would impact a Tomcat only build for M4. Agree?
> 
> John
> 
> Jeff Genender <jg...@savoirtech.com> wrote on 06/07/2005 03:01:00 PM:
> 
> 
>>I looked at this...it would be great to adapt this with interfaces or 
>>similar so we can reuse as much of the same code as possible...
>>
>>John Sisson (JIRA) wrote:
>>
>>>class loader server currently cannot run on Tomcat (requires Jetty)
>>>-------------------------------------------------------------------
>>>
>>>         Key: GERONIMO-713
>>>         URL: http://issues.apache.org/jira/browse/GERONIMO-713
>>>     Project: Geronimo
>>>        Type: Task
>>>  Components: Tomcat 
>>>    Reporter: John Sisson
>>>
>>>
>>>The j2ee-remote-classloading-deployer-plan.xml is currently Jetty 
>>
>>specific.  It specifes the class org.apache.geronimo.
>>classloaderserver.http.HTTPClassLoaderServer, which uses Jetty classes.
>>
>>>It looks like a Tomcat version of the class loader server needs to
>>
>>be developed.
>>
>>>For a description of remote class loading, see http://svn.apache.
>>
>>org/viewcvs?view=rev&rev=158589
>>
>>>Once implemented, the wiki page http://wiki.apache.org/geronimo/Tomcat
>>
>>needs to be updated.
>>

Re: [jira] Created: (GERONIMO-713) class loader server currently cannot run on Tomcat (requires Jetty)

Posted by si...@insession.com.
I think this issue would impact a Tomcat only build for M4. Agree?

John

Jeff Genender <jg...@savoirtech.com> wrote on 06/07/2005 03:01:00 PM:

> I looked at this...it would be great to adapt this with interfaces or 
> similar so we can reuse as much of the same code as possible...
> 
> John Sisson (JIRA) wrote:
> > class loader server currently cannot run on Tomcat (requires Jetty)
> > -------------------------------------------------------------------
> > 
> >          Key: GERONIMO-713
> >          URL: http://issues.apache.org/jira/browse/GERONIMO-713
> >      Project: Geronimo
> >         Type: Task
> >   Components: Tomcat 
> >     Reporter: John Sisson
> > 
> > 
> > The j2ee-remote-classloading-deployer-plan.xml is currently Jetty 
> specific.  It specifes the class org.apache.geronimo.
> classloaderserver.http.HTTPClassLoaderServer, which uses Jetty classes.
> > 
> > It looks like a Tomcat version of the class loader server needs to
> be developed.
> > 
> > For a description of remote class loading, see http://svn.apache.
> org/viewcvs?view=rev&rev=158589
> > 
> > Once implemented, the wiki page http://wiki.apache.org/geronimo/Tomcat
> needs to be updated.
> > 


Re: [jira] Created: (GERONIMO-713) class loader server currently cannot run on Tomcat (requires Jetty)

Posted by Jeff Genender <jg...@savoirtech.com>.
I looked at this...it would be great to adapt this with interfaces or 
similar so we can reuse as much of the same code as possible...

John Sisson (JIRA) wrote:
> class loader server currently cannot run on Tomcat (requires Jetty)
> -------------------------------------------------------------------
> 
>          Key: GERONIMO-713
>          URL: http://issues.apache.org/jira/browse/GERONIMO-713
>      Project: Geronimo
>         Type: Task
>   Components: Tomcat  
>     Reporter: John Sisson
> 
> 
> The j2ee-remote-classloading-deployer-plan.xml is currently Jetty specific.  It specifes the class org.apache.geronimo.classloaderserver.http.HTTPClassLoaderServer, which uses Jetty classes.
> 
> It looks like a Tomcat version of the class loader server needs to be developed.
> 
> For a description of remote class loading, see http://svn.apache.org/viewcvs?view=rev&rev=158589
> 
> Once implemented, the wiki page http://wiki.apache.org/geronimo/Tomcat  needs to be updated.
> 

[jira] Closed: (GERONIMO-713) class loader server currently cannot run on Tomcat (requires Jetty)

Posted by "David Jencks (JIRA)" <de...@geronimo.apache.org>.
     [ http://issues.apache.org/jira/browse/GERONIMO-713?page=all ]
     
David Jencks closed GERONIMO-713:
---------------------------------

    Fix Version: 1.0-M4
                 1.0-M5
     Resolution: Invalid

The HTTPClassLoaderServer is gone.

> class loader server currently cannot run on Tomcat (requires Jetty)
> -------------------------------------------------------------------
>
>          Key: GERONIMO-713
>          URL: http://issues.apache.org/jira/browse/GERONIMO-713
>      Project: Geronimo
>         Type: Task
>   Components: Tomcat
>     Reporter: John Sisson
>     Assignee: Gianny Damour
>      Fix For: 1.0-M4, 1.0-M5

>
> The j2ee-remote-classloading-deployer-plan.xml is currently Jetty specific.  It specifes the class org.apache.geronimo.classloaderserver.http.HTTPClassLoaderServer, which uses Jetty classes.
> It looks like a Tomcat version of the class loader server needs to be developed.
> For a description of remote class loading, see http://svn.apache.org/viewcvs?view=rev&rev=158589
> Once implemented, the wiki page http://wiki.apache.org/geronimo/Tomcat  needs to be updated.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (GERONIMO-713) class loader server currently cannot run on Tomcat (requires Jetty)

Posted by "Aaron Mulder (JIRA)" <de...@geronimo.apache.org>.
    [ http://issues.apache.org/jira/browse/GERONIMO-713?page=comments#action_12315424 ] 

Aaron Mulder commented on GERONIMO-713:
---------------------------------------

Actually, I just handled the "wrapping" for all DeploymentExceptions (see Deployer.java:82).  That should cover the majority of cases -- but we could do the same for RuntimeExceptions too if we like.  It actually more like "unwrapping" in that I create a new exception with no chained exception and the message from the DeploymentException and the first chained exception, which seems to be adequate.  It results in a deployer message like:

Error: Unable to distribute debug.war: xml problem caused by jar:file:/tmp/deployer7007.tmpdir/debug.war!/WEB-INF/geronimo-web.xml:12:33: error: The element type "context-rloot" must be terminated by the matching end-tag "</context-rloot>". 

> class loader server currently cannot run on Tomcat (requires Jetty)
> -------------------------------------------------------------------
>
>          Key: GERONIMO-713
>          URL: http://issues.apache.org/jira/browse/GERONIMO-713
>      Project: Geronimo
>         Type: Task
>   Components: Tomcat
>     Reporter: John Sisson
>     Assignee: Gianny Damour

>
> The j2ee-remote-classloading-deployer-plan.xml is currently Jetty specific.  It specifes the class org.apache.geronimo.classloaderserver.http.HTTPClassLoaderServer, which uses Jetty classes.
> It looks like a Tomcat version of the class loader server needs to be developed.
> For a description of remote class loading, see http://svn.apache.org/viewcvs?view=rev&rev=158589
> Once implemented, the wiki page http://wiki.apache.org/geronimo/Tomcat  needs to be updated.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


RE: [jira] Commented: (GERONIMO-713) class loader server currently cannot run on Tomcat (requires Jetty)

Posted by Jeff Genender <jg...@savoirtech.com>.
John,

Thanks a lot for following up this...I had the code under surgery...glad you
commented on this sooner.   

I would rather not muck with this...this is good.

Jeff

-----Original Message-----
From: John Sisson (JIRA) [mailto:dev@geronimo.apache.org] 
Sent: Saturday, July 09, 2005 9:55 PM
To: dev@geronimo.apache.org
Subject: [jira] Commented: (GERONIMO-713) class loader server currently
cannot run on Tomcat (requires Jetty)

    [
http://issues.apache.org/jira/browse/GERONIMO-713?page=comments#action_12315
422 ] 

John Sisson commented on GERONIMO-713:
--------------------------------------

According to the mail thread 'Re: Invoking the deploy tool under a security
manager and startup scripts' Gianny will be removing the classloader server
and enhance the server code to wrap any deployment exceptions in a way that
you don't need the remote classes on the client.  Once that is done, this
issue will be invalid.

> class loader server currently cannot run on Tomcat (requires Jetty)
> -------------------------------------------------------------------
>
>          Key: GERONIMO-713
>          URL: http://issues.apache.org/jira/browse/GERONIMO-713
>      Project: Geronimo
>         Type: Task
>   Components: Tomcat
>     Reporter: John Sisson

>
> The j2ee-remote-classloading-deployer-plan.xml is currently Jetty
specific.  It specifes the class
org.apache.geronimo.classloaderserver.http.HTTPClassLoaderServer, which uses
Jetty classes.
> It looks like a Tomcat version of the class loader server needs to be
developed.
> For a description of remote class loading, see 
> http://svn.apache.org/viewcvs?view=rev&rev=158589
> Once implemented, the wiki page http://wiki.apache.org/geronimo/Tomcat
needs to be updated.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Commented: (GERONIMO-713) class loader server currently cannot run on Tomcat (requires Jetty)

Posted by "John Sisson (JIRA)" <de...@geronimo.apache.org>.
    [ http://issues.apache.org/jira/browse/GERONIMO-713?page=comments#action_12315422 ] 

John Sisson commented on GERONIMO-713:
--------------------------------------

According to the mail thread 'Re: Invoking the deploy tool under a security manager and startup scripts' Gianny will be removing the classloader server and enhance the server code to wrap any deployment exceptions in a way that you don't need the remote classes on the client.  Once that is done, this issue will be invalid.

> class loader server currently cannot run on Tomcat (requires Jetty)
> -------------------------------------------------------------------
>
>          Key: GERONIMO-713
>          URL: http://issues.apache.org/jira/browse/GERONIMO-713
>      Project: Geronimo
>         Type: Task
>   Components: Tomcat
>     Reporter: John Sisson

>
> The j2ee-remote-classloading-deployer-plan.xml is currently Jetty specific.  It specifes the class org.apache.geronimo.classloaderserver.http.HTTPClassLoaderServer, which uses Jetty classes.
> It looks like a Tomcat version of the class loader server needs to be developed.
> For a description of remote class loading, see http://svn.apache.org/viewcvs?view=rev&rev=158589
> Once implemented, the wiki page http://wiki.apache.org/geronimo/Tomcat  needs to be updated.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Assigned: (GERONIMO-713) class loader server currently cannot run on Tomcat (requires Jetty)

Posted by "John Sisson (JIRA)" <de...@geronimo.apache.org>.
     [ http://issues.apache.org/jira/browse/GERONIMO-713?page=all ]

John Sisson reassigned GERONIMO-713:
------------------------------------

    Assign To: Gianny Damour

> class loader server currently cannot run on Tomcat (requires Jetty)
> -------------------------------------------------------------------
>
>          Key: GERONIMO-713
>          URL: http://issues.apache.org/jira/browse/GERONIMO-713
>      Project: Geronimo
>         Type: Task
>   Components: Tomcat
>     Reporter: John Sisson
>     Assignee: Gianny Damour

>
> The j2ee-remote-classloading-deployer-plan.xml is currently Jetty specific.  It specifes the class org.apache.geronimo.classloaderserver.http.HTTPClassLoaderServer, which uses Jetty classes.
> It looks like a Tomcat version of the class loader server needs to be developed.
> For a description of remote class loading, see http://svn.apache.org/viewcvs?view=rev&rev=158589
> Once implemented, the wiki page http://wiki.apache.org/geronimo/Tomcat  needs to be updated.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira