You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/06/28 16:19:43 UTC

[GitHub] [bookkeeper] dlg99 commented on a diff in pull request #3366: BP-47 (task7): DbLedgerStorage add direct entry logger support

dlg99 commented on code in PR #3366:
URL: https://github.com/apache/bookkeeper/pull/3366#discussion_r908657094


##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/storage/ldb/DbLedgerStorage.java:
##########
@@ -91,6 +106,16 @@ public class DbLedgerStorage implements LedgerStorage {
     static final String READ_AHEAD_CACHE_BATCH_SIZE = "dbStorage_readAheadCacheBatchSize";
     private static final int DEFAULT_READ_AHEAD_CACHE_BATCH_SIZE = 100;
 
+    private static final long DEFAULT_DIRECT_IO_TOTAL_WRITEBUFFER_SIZE_MB =
+        (long) (0.125 * PlatformDependent.maxDirectMemory())

Review Comment:
   PlatformDependent.estimateMaxDirectMemory()
   
   See https://github.com/apache/bookkeeper/pull/2989



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org