You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/07/08 04:05:55 UTC

[GitHub] [airflow] vlasvlasvlas opened a new pull request #9715: create CODE_OF_CONDUCT.md

vlasvlasvlas opened a new pull request #9715:
URL: https://github.com/apache/airflow/pull/9715


   hope we can get a code of conduct for issues! thanks :D
   
   ---
   Make sure to mark the boxes below before creating PR: [x]
   
   - [ ] Description above provides context of the change
   - [ ] Unit tests coverage for changes (not needed for documentation changes)
   - [ ] Target Github ISSUE in description if exists
   - [ ] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [ ] Relevant documentation is updated including usage instructions.
   - [ ] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] turbaszek commented on pull request #9715: create CODE_OF_CONDUCT.md

Posted by GitBox <gi...@apache.org>.

turbaszek commented on pull request #9715:
URL: https://github.com/apache/airflow/pull/9715#issuecomment-656210721


   I agree with @Fokko let's link to ASF CoC


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] Fokko commented on pull request #9715: create CODE_OF_CONDUCT.md

Posted by GitBox <gi...@apache.org>.

Fokko commented on pull request #9715:
URL: https://github.com/apache/airflow/pull/9715#issuecomment-662259715


   @vlasvlasvlas Great suggestion, all for it!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] turbaszek commented on a change in pull request #9715: create CODE_OF_CONDUCT.md

Posted by GitBox <gi...@apache.org>.

turbaszek commented on a change in pull request #9715:
URL: https://github.com/apache/airflow/pull/9715#discussion_r465544528



##########
File path: CODE_OF_CONDUCT.md
##########
@@ -0,0 +1,5 @@
+# Contributor Covenant Code of Conduct
+
+The Apache Airflow project follows the [Apache Software Foundation code of conduct](http://www.apache.org/foundation/policies/conduct.html).

Review comment:
       ```suggestion
   The Apache Airflow project follows the [Apache Software Foundation code of conduct](https://www.apache.org/foundation/policies/conduct.html).
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] turbaszek commented on a change in pull request #9715: create CODE_OF_CONDUCT.md

Posted by GitBox <gi...@apache.org>.

turbaszek commented on a change in pull request #9715:
URL: https://github.com/apache/airflow/pull/9715#discussion_r465544333



##########
File path: CODE_OF_CONDUCT.md
##########
@@ -0,0 +1,5 @@
+# Contributor Covenant Code of Conduct

Review comment:
       ```suggestion
   <!--
    Licensed to the Apache Software Foundation (ASF) under one
    or more contributor license agreements.  See the NOTICE file
    distributed with this work for additional information
    regarding copyright ownership.  The ASF licenses this file
    to you under the Apache License, Version 2.0 (the
    "License"); you may not use this file except in compliance
    with the License.  You may obtain a copy of the License at
   
      http://www.apache.org/licenses/LICENSE-2.0
   
    Unless required by applicable law or agreed to in writing,
    software distributed under the License is distributed on an
    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    KIND, either express or implied.  See the License for the
    specific language governing permissions and limitations
    under the License.
   -->
   
   # Contributor Covenant Code of Conduct
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] codecov-commenter edited a comment on pull request #9715: create CODE_OF_CONDUCT.md

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #9715:
URL: https://github.com/apache/airflow/pull/9715#issuecomment-669184106


   # [Codecov](https://codecov.io/gh/apache/airflow/pull/9715?src=pr&el=h1) Report
   > Merging [#9715](https://codecov.io/gh/apache/airflow/pull/9715?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/4054663769e3a3861773469469dd3efa7b383df8&el=desc) will **increase** coverage by `29.59%`.
   > The diff coverage is `48.56%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/9715/graphs/tree.svg?width=650&height=150&src=pr&token=WdLKlKHOAU)](https://codecov.io/gh/apache/airflow/pull/9715?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master    #9715       +/-   ##
   ===========================================
   + Coverage    6.22%   35.82%   +29.59%     
   ===========================================
     Files         946     1037       +91     
     Lines       45695    49923     +4228     
   ===========================================
   + Hits         2846    17886    +15040     
   + Misses      42849    32037    -10812     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #kubernetes-tests-image-3.6-v1.16.9 | `5.77% <1.65%> (?)` | |
   | #kubernetes-tests-image-3.6-v1.18.6 | `5.77% <1.65%> (?)` | |
   | #postgres-tests-Integration-3.6-9.6 | `34.76% <47.61%> (?)` | |
   | #postgres-tests-Integration-3.7-10 | `34.76% <47.61%> (?)` | |
   | #sqlite-tests-Integration-3.8 | `34.47% <43.49%> (?)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/9715?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/cli/commands/dag\_command.py](https://codecov.io/gh/apache/airflow/pull/9715/diff?src=pr&el=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvZGFnX2NvbW1hbmQucHk=) | `26.08% <0.00%> (+26.08%)` | :arrow_up: |
   | [airflow/cli/commands/db\_command.py](https://codecov.io/gh/apache/airflow/pull/9715/diff?src=pr&el=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvZGJfY29tbWFuZC5weQ==) | `36.17% <ø> (+36.17%)` | :arrow_up: |
   | [airflow/cli/commands/info\_command.py](https://codecov.io/gh/apache/airflow/pull/9715/diff?src=pr&el=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvaW5mb19jb21tYW5kLnB5) | `35.67% <ø> (+35.67%)` | :arrow_up: |
   | [airflow/cli/commands/task\_command.py](https://codecov.io/gh/apache/airflow/pull/9715/diff?src=pr&el=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvdGFza19jb21tYW5kLnB5) | `23.71% <0.00%> (+23.71%)` | :arrow_up: |
   | [airflow/config\_templates/airflow\_local\_settings.py](https://codecov.io/gh/apache/airflow/pull/9715/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb25maWdfdGVtcGxhdGVzL2FpcmZsb3dfbG9jYWxfc2V0dGluZ3MucHk=) | `40.98% <0.00%> (-0.09%)` | :arrow_down: |
   | [airflow/config\_templates/default\_celery.py](https://codecov.io/gh/apache/airflow/pull/9715/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb25maWdfdGVtcGxhdGVzL2RlZmF1bHRfY2VsZXJ5LnB5) | `52.94% <ø> (+52.94%)` | :arrow_up: |
   | [...rflow/config\_templates/default\_webserver\_config.py](https://codecov.io/gh/apache/airflow/pull/9715/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb25maWdfdGVtcGxhdGVzL2RlZmF1bHRfd2Vic2VydmVyX2NvbmZpZy5weQ==) | `0.00% <0.00%> (ø)` | |
   | [airflow/contrib/\_\_init\_\_.py](https://codecov.io/gh/apache/airflow/pull/9715/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL19faW5pdF9fLnB5) | `0.00% <0.00%> (ø)` | |
   | [...low/contrib/hooks/azure\_container\_instance\_hook.py](https://codecov.io/gh/apache/airflow/pull/9715/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2F6dXJlX2NvbnRhaW5lcl9pbnN0YW5jZV9ob29rLnB5) | `0.00% <ø> (ø)` | |
   | [airflow/contrib/operators/adls\_to\_gcs.py](https://codecov.io/gh/apache/airflow/pull/9715/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9hZGxzX3RvX2djcy5weQ==) | `0.00% <0.00%> (ø)` | |
   | ... and [960 more](https://codecov.io/gh/apache/airflow/pull/9715/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/9715?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/9715?src=pr&el=footer). Last update [6c15885...57add1a](https://codecov.io/gh/apache/airflow/pull/9715?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] codecov-commenter edited a comment on pull request #9715: create CODE_OF_CONDUCT.md

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #9715:
URL: https://github.com/apache/airflow/pull/9715#issuecomment-669184106


   # [Codecov](https://codecov.io/gh/apache/airflow/pull/9715?src=pr&el=h1) Report
   > Merging [#9715](https://codecov.io/gh/apache/airflow/pull/9715?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/4054663769e3a3861773469469dd3efa7b383df8&el=desc) will **increase** coverage by `29.20%`.
   > The diff coverage is `47.48%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/9715/graphs/tree.svg?width=650&height=150&src=pr&token=WdLKlKHOAU)](https://codecov.io/gh/apache/airflow/pull/9715?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master    #9715       +/-   ##
   ===========================================
   + Coverage    6.22%   35.43%   +29.20%     
   ===========================================
     Files         946     1037       +91     
     Lines       45695    49923     +4228     
   ===========================================
   + Hits         2846    17691    +14845     
   + Misses      42849    32232    -10617     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #kubernetes-tests-image-3.6-v1.16.9 | `5.77% <1.65%> (?)` | |
   | #kubernetes-tests-image-3.6-v1.18.6 | `5.77% <1.65%> (?)` | |
   | #postgres-tests-Integration-3.6-9.6 | `34.76% <47.61%> (?)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/9715?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/cli/commands/dag\_command.py](https://codecov.io/gh/apache/airflow/pull/9715/diff?src=pr&el=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvZGFnX2NvbW1hbmQucHk=) | `22.22% <0.00%> (+22.22%)` | :arrow_up: |
   | [airflow/cli/commands/db\_command.py](https://codecov.io/gh/apache/airflow/pull/9715/diff?src=pr&el=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvZGJfY29tbWFuZC5weQ==) | `29.78% <ø> (+29.78%)` | :arrow_up: |
   | [airflow/cli/commands/info\_command.py](https://codecov.io/gh/apache/airflow/pull/9715/diff?src=pr&el=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvaW5mb19jb21tYW5kLnB5) | `34.59% <ø> (+34.59%)` | :arrow_up: |
   | [airflow/cli/commands/task\_command.py](https://codecov.io/gh/apache/airflow/pull/9715/diff?src=pr&el=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvdGFza19jb21tYW5kLnB5) | `21.13% <0.00%> (+21.13%)` | :arrow_up: |
   | [airflow/config\_templates/airflow\_local\_settings.py](https://codecov.io/gh/apache/airflow/pull/9715/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb25maWdfdGVtcGxhdGVzL2FpcmZsb3dfbG9jYWxfc2V0dGluZ3MucHk=) | `40.98% <0.00%> (-0.09%)` | :arrow_down: |
   | [airflow/config\_templates/default\_celery.py](https://codecov.io/gh/apache/airflow/pull/9715/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb25maWdfdGVtcGxhdGVzL2RlZmF1bHRfY2VsZXJ5LnB5) | `52.94% <ø> (+52.94%)` | :arrow_up: |
   | [...rflow/config\_templates/default\_webserver\_config.py](https://codecov.io/gh/apache/airflow/pull/9715/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb25maWdfdGVtcGxhdGVzL2RlZmF1bHRfd2Vic2VydmVyX2NvbmZpZy5weQ==) | `0.00% <0.00%> (ø)` | |
   | [airflow/contrib/\_\_init\_\_.py](https://codecov.io/gh/apache/airflow/pull/9715/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL19faW5pdF9fLnB5) | `0.00% <0.00%> (ø)` | |
   | [...low/contrib/hooks/azure\_container\_instance\_hook.py](https://codecov.io/gh/apache/airflow/pull/9715/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2F6dXJlX2NvbnRhaW5lcl9pbnN0YW5jZV9ob29rLnB5) | `0.00% <ø> (ø)` | |
   | [airflow/contrib/operators/adls\_to\_gcs.py](https://codecov.io/gh/apache/airflow/pull/9715/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9hZGxzX3RvX2djcy5weQ==) | `0.00% <0.00%> (ø)` | |
   | ... and [960 more](https://codecov.io/gh/apache/airflow/pull/9715/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/9715?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/9715?src=pr&el=footer). Last update [6c15885...57add1a](https://codecov.io/gh/apache/airflow/pull/9715?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #9715: create CODE_OF_CONDUCT.md

Posted by GitBox <gi...@apache.org>.

potiuk commented on pull request #9715:
URL: https://github.com/apache/airflow/pull/9715#issuecomment-655273339


   cc: @ashb -> we were discussing that we want to add explicit COC indeed. For now we are all bound by the Apache COC http://www.apache.org/foundation/policies/conduct.html  and I was wondering what wording will be best :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #9715: create CODE_OF_CONDUCT.md

Posted by GitBox <gi...@apache.org>.

potiuk commented on pull request #9715:
URL: https://github.com/apache/airflow/pull/9715#issuecomment-656670364


   Yeah. What @turbaszek proposed is good for me.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] turbaszek commented on pull request #9715: create CODE_OF_CONDUCT.md

Posted by GitBox <gi...@apache.org>.

turbaszek commented on pull request #9715:
URL: https://github.com/apache/airflow/pull/9715#issuecomment-662256645


   > > 
   > 
   > > 
   > 
   > > Should something like this be ok?
   > 
   > > 
   > 
   > > ```gfm
   > 
   > > The Apache Airflow project follows the [Apache Software Foundation code of conduct](http://www.apache.org/foundation/policies/conduct.html).
   > 
   > > 
   > 
   > >  If you observe behavior that violates those rules please follow the [ASF reporting guidelines](https://www.apache.org/foundation/policies/conduct#reporting-guidelines). 
   > 
   > > ```
   > 
   > 
   > 
   > this as a replace within the content of the whole file code of conduct?
   
   Yes


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] Fokko commented on pull request #9715: create CODE_OF_CONDUCT.md

Posted by GitBox <gi...@apache.org>.

Fokko commented on pull request #9715:
URL: https://github.com/apache/airflow/pull/9715#issuecomment-655912419


   I'm not against it, but why have another CoC next to the Apache one. I would suggest that we also refer to the Apache one.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] codecov-commenter commented on pull request #9715: create CODE_OF_CONDUCT.md

Posted by GitBox <gi...@apache.org>.

codecov-commenter commented on pull request #9715:
URL: https://github.com/apache/airflow/pull/9715#issuecomment-669184106


   # [Codecov](https://codecov.io/gh/apache/airflow/pull/9715?src=pr&el=h1) Report
   > Merging [#9715](https://codecov.io/gh/apache/airflow/pull/9715?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/4054663769e3a3861773469469dd3efa7b383df8&el=desc) will **increase** coverage by `28.53%`.
   > The diff coverage is `47.61%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/9715/graphs/tree.svg?width=650&height=150&src=pr&token=WdLKlKHOAU)](https://codecov.io/gh/apache/airflow/pull/9715?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master    #9715       +/-   ##
   ===========================================
   + Coverage    6.22%   34.76%   +28.53%     
   ===========================================
     Files         946     1037       +91     
     Lines       45695    49631     +3936     
   ===========================================
   + Hits         2846    17252    +14406     
   + Misses      42849    32379    -10470     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #postgres-tests-Integration-3.6-9.6 | `34.76% <47.61%> (?)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/9715?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/cli/commands/dag\_command.py](https://codecov.io/gh/apache/airflow/pull/9715/diff?src=pr&el=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvZGFnX2NvbW1hbmQucHk=) | `23.11% <0.00%> (+23.11%)` | :arrow_up: |
   | [airflow/cli/commands/db\_command.py](https://codecov.io/gh/apache/airflow/pull/9715/diff?src=pr&el=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvZGJfY29tbWFuZC5weQ==) | `31.81% <ø> (+31.81%)` | :arrow_up: |
   | [airflow/cli/commands/info\_command.py](https://codecov.io/gh/apache/airflow/pull/9715/diff?src=pr&el=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvaW5mb19jb21tYW5kLnB5) | `34.97% <ø> (+34.97%)` | :arrow_up: |
   | [airflow/cli/commands/task\_command.py](https://codecov.io/gh/apache/airflow/pull/9715/diff?src=pr&el=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvdGFza19jb21tYW5kLnB5) | `21.69% <0.00%> (+21.69%)` | :arrow_up: |
   | [airflow/config\_templates/airflow\_local\_settings.py](https://codecov.io/gh/apache/airflow/pull/9715/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb25maWdfdGVtcGxhdGVzL2FpcmZsb3dfbG9jYWxfc2V0dGluZ3MucHk=) | `40.98% <0.00%> (-0.09%)` | :arrow_down: |
   | [airflow/config\_templates/default\_celery.py](https://codecov.io/gh/apache/airflow/pull/9715/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb25maWdfdGVtcGxhdGVzL2RlZmF1bHRfY2VsZXJ5LnB5) | `52.94% <ø> (+52.94%)` | :arrow_up: |
   | [...rflow/config\_templates/default\_webserver\_config.py](https://codecov.io/gh/apache/airflow/pull/9715/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb25maWdfdGVtcGxhdGVzL2RlZmF1bHRfd2Vic2VydmVyX2NvbmZpZy5weQ==) | `0.00% <0.00%> (ø)` | |
   | [airflow/contrib/\_\_init\_\_.py](https://codecov.io/gh/apache/airflow/pull/9715/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL19faW5pdF9fLnB5) | `0.00% <0.00%> (ø)` | |
   | [...low/contrib/hooks/azure\_container\_instance\_hook.py](https://codecov.io/gh/apache/airflow/pull/9715/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2F6dXJlX2NvbnRhaW5lcl9pbnN0YW5jZV9ob29rLnB5) | `0.00% <ø> (ø)` | |
   | [airflow/contrib/operators/adls\_to\_gcs.py](https://codecov.io/gh/apache/airflow/pull/9715/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9hZGxzX3RvX2djcy5weQ==) | `0.00% <0.00%> (ø)` | |
   | ... and [950 more](https://codecov.io/gh/apache/airflow/pull/9715/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/9715?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/9715?src=pr&el=footer). Last update [6c15885...57add1a](https://codecov.io/gh/apache/airflow/pull/9715?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #9715: create CODE_OF_CONDUCT.md

Posted by GitBox <gi...@apache.org>.

boring-cyborg[bot] commented on pull request #9715:
URL: https://github.com/apache/airflow/pull/9715#issuecomment-655270213

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://apache-airflow-slack.herokuapp.com/

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #9715: create CODE_OF_CONDUCT.md

Posted by GitBox <gi...@apache.org>.

potiuk commented on pull request #9715:
URL: https://github.com/apache/airflow/pull/9715#issuecomment-656122639


   Yeah. Linking to the ASF CoC is a better idea, Otherwise it might be somewhat conflict at times.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] codecov-commenter edited a comment on pull request #9715: create CODE_OF_CONDUCT.md

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #9715:
URL: https://github.com/apache/airflow/pull/9715#issuecomment-669184106


   # [Codecov](https://codecov.io/gh/apache/airflow/pull/9715?src=pr&el=h1) Report
   > Merging [#9715](https://codecov.io/gh/apache/airflow/pull/9715?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/4054663769e3a3861773469469dd3efa7b383df8&el=desc) will **increase** coverage by `29.20%`.
   > The diff coverage is `47.48%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/9715/graphs/tree.svg?width=650&height=150&src=pr&token=WdLKlKHOAU)](https://codecov.io/gh/apache/airflow/pull/9715?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master    #9715       +/-   ##
   ===========================================
   + Coverage    6.22%   35.43%   +29.20%     
   ===========================================
     Files         946     1037       +91     
     Lines       45695    49923     +4228     
   ===========================================
   + Hits         2846    17691    +14845     
   + Misses      42849    32232    -10617     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #kubernetes-tests-image-3.6-v1.18.6 | `5.77% <1.65%> (?)` | |
   | #postgres-tests-Integration-3.6-9.6 | `34.76% <47.61%> (?)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/9715?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/cli/commands/dag\_command.py](https://codecov.io/gh/apache/airflow/pull/9715/diff?src=pr&el=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvZGFnX2NvbW1hbmQucHk=) | `22.22% <0.00%> (+22.22%)` | :arrow_up: |
   | [airflow/cli/commands/db\_command.py](https://codecov.io/gh/apache/airflow/pull/9715/diff?src=pr&el=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvZGJfY29tbWFuZC5weQ==) | `29.78% <ø> (+29.78%)` | :arrow_up: |
   | [airflow/cli/commands/info\_command.py](https://codecov.io/gh/apache/airflow/pull/9715/diff?src=pr&el=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvaW5mb19jb21tYW5kLnB5) | `34.59% <ø> (+34.59%)` | :arrow_up: |
   | [airflow/cli/commands/task\_command.py](https://codecov.io/gh/apache/airflow/pull/9715/diff?src=pr&el=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvdGFza19jb21tYW5kLnB5) | `21.13% <0.00%> (+21.13%)` | :arrow_up: |
   | [airflow/config\_templates/airflow\_local\_settings.py](https://codecov.io/gh/apache/airflow/pull/9715/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb25maWdfdGVtcGxhdGVzL2FpcmZsb3dfbG9jYWxfc2V0dGluZ3MucHk=) | `40.98% <0.00%> (-0.09%)` | :arrow_down: |
   | [airflow/config\_templates/default\_celery.py](https://codecov.io/gh/apache/airflow/pull/9715/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb25maWdfdGVtcGxhdGVzL2RlZmF1bHRfY2VsZXJ5LnB5) | `52.94% <ø> (+52.94%)` | :arrow_up: |
   | [...rflow/config\_templates/default\_webserver\_config.py](https://codecov.io/gh/apache/airflow/pull/9715/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb25maWdfdGVtcGxhdGVzL2RlZmF1bHRfd2Vic2VydmVyX2NvbmZpZy5weQ==) | `0.00% <0.00%> (ø)` | |
   | [airflow/contrib/\_\_init\_\_.py](https://codecov.io/gh/apache/airflow/pull/9715/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL19faW5pdF9fLnB5) | `0.00% <0.00%> (ø)` | |
   | [...low/contrib/hooks/azure\_container\_instance\_hook.py](https://codecov.io/gh/apache/airflow/pull/9715/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2F6dXJlX2NvbnRhaW5lcl9pbnN0YW5jZV9ob29rLnB5) | `0.00% <ø> (ø)` | |
   | [airflow/contrib/operators/adls\_to\_gcs.py](https://codecov.io/gh/apache/airflow/pull/9715/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9hZGxzX3RvX2djcy5weQ==) | `0.00% <0.00%> (ø)` | |
   | ... and [960 more](https://codecov.io/gh/apache/airflow/pull/9715/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/9715?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/9715?src=pr&el=footer). Last update [6c15885...57add1a](https://codecov.io/gh/apache/airflow/pull/9715?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] turbaszek commented on pull request #9715: create CODE_OF_CONDUCT.md

Posted by GitBox <gi...@apache.org>.

turbaszek commented on pull request #9715:
URL: https://github.com/apache/airflow/pull/9715#issuecomment-656490305


   Should something like this be ok?
   ```markdown
   The Apache Airflow project follows the [Apache Software Foundation code of conduct](http://www.apache.org/foundation/policies/conduct.html).
   
    If you observe behavior that violates those rules please follow the [ASF reporting guidelines](https://www.apache.org/foundation/policies/conduct#reporting-guidelines). 
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] vlasvlasvlas commented on pull request #9715: create CODE_OF_CONDUCT.md

Posted by GitBox <gi...@apache.org>.

vlasvlasvlas commented on pull request #9715:
URL: https://github.com/apache/airflow/pull/9715#issuecomment-662225435


   > 
   > 
   > Should something like this be ok?
   > 
   > ```gfm
   > The Apache Airflow project follows the [Apache Software Foundation code of conduct](http://www.apache.org/foundation/policies/conduct.html).
   > 
   >  If you observe behavior that violates those rules please follow the [ASF reporting guidelines](https://www.apache.org/foundation/policies/conduct#reporting-guidelines). 
   > ```
   
   this as a replace within the content of the whole file code of conduct?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] vlasvlasvlas commented on pull request #9715: create CODE_OF_CONDUCT.md

Posted by GitBox <gi...@apache.org>.

vlasvlasvlas commented on pull request #9715:
URL: https://github.com/apache/airflow/pull/9715#issuecomment-656359252


   nice, so how do we link to the Apache CoC?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #9715: create CODE_OF_CONDUCT.md

Posted by GitBox <gi...@apache.org>.

potiuk commented on pull request #9715:
URL: https://github.com/apache/airflow/pull/9715#issuecomment-662275231


   Yep. All for it!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] vlasvlasvlas commented on pull request #9715: create CODE_OF_CONDUCT.md

Posted by GitBox <gi...@apache.org>.

vlasvlasvlas commented on pull request #9715:
URL: https://github.com/apache/airflow/pull/9715#issuecomment-672185359


   yeayyy! :) 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] zhongjiajie commented on pull request #9715: create CODE_OF_CONDUCT.md

Posted by GitBox <gi...@apache.org>.

zhongjiajie commented on pull request #9715:
URL: https://github.com/apache/airflow/pull/9715#issuecomment-656667699


   Agree that we should linking to apache COC


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] turbaszek merged pull request #9715: create CODE_OF_CONDUCT.md

Posted by GitBox <gi...@apache.org>.

turbaszek merged pull request #9715:
URL: https://github.com/apache/airflow/pull/9715


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] Fokko commented on a change in pull request #9715: create CODE_OF_CONDUCT.md

Posted by GitBox <gi...@apache.org>.

Fokko commented on a change in pull request #9715:
URL: https://github.com/apache/airflow/pull/9715#discussion_r459309752



##########
File path: CODE_OF_CONDUCT.md
##########
@@ -0,0 +1,5 @@
+# Contributor Covenant Code of Conduct
+
+The Apache Airflow project follows the [Apache Software Foundation code of conduct](http://www.apache.org/foundation/policies/conduct.html).

Review comment:
       Minor, could we make this http**s**?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] vlasvlasvlas commented on pull request #9715: create CODE_OF_CONDUCT.md

Posted by GitBox <gi...@apache.org>.

vlasvlasvlas commented on pull request #9715:
URL: https://github.com/apache/airflow/pull/9715#issuecomment-656359846


   > 
   > 
   > The only thing I see missing in this PR's COC is section around Reporting Guidelines which ASF COC covers (https://www.apache.org/foundation/policies/conduct#reporting-guidelines)
   
   and i think this is also important. can we include the reporting guidelines also?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] turbaszek commented on a change in pull request #9715: create CODE_OF_CONDUCT.md

Posted by GitBox <gi...@apache.org>.

turbaszek commented on a change in pull request #9715:
URL: https://github.com/apache/airflow/pull/9715#discussion_r462115122



##########
File path: CODE_OF_CONDUCT.md
##########
@@ -0,0 +1,5 @@
+# Contributor Covenant Code of Conduct
+
+The Apache Airflow project follows the [Apache Software Foundation code of conduct](http://www.apache.org/foundation/policies/conduct.html).
+
+If you observe behavior that violates those rules please follow the [ASF reporting guidelines](https://www.apache.org/foundation/policies/conduct#reporting-guidelines). 

Review comment:
       ```suggestion
   If you observe behavior that violates those rules please follow the [ASF reporting guidelines](https://www.apache.org/foundation/policies/conduct#reporting-guidelines).
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] kaxil commented on pull request #9715: create CODE_OF_CONDUCT.md

Posted by GitBox <gi...@apache.org>.

kaxil commented on pull request #9715:
URL: https://github.com/apache/airflow/pull/9715#issuecomment-655791145


   The only thing I see missing in this PR's COC is section around Reporting Guidelines which ASF COC covers (https://www.apache.org/foundation/policies/conduct#reporting-guidelines)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] vlasvlasvlas commented on a change in pull request #9715: create CODE_OF_CONDUCT.md

Posted by GitBox <gi...@apache.org>.

vlasvlasvlas commented on a change in pull request #9715:
URL: https://github.com/apache/airflow/pull/9715#discussion_r462003148



##########
File path: CODE_OF_CONDUCT.md
##########
@@ -0,0 +1,5 @@
+# Contributor Covenant Code of Conduct
+
+The Apache Airflow project follows the [Apache Software Foundation code of conduct](http://www.apache.org/foundation/policies/conduct.html).

Review comment:
       sorry for the delay, ill change that




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] vlasvlasvlas commented on pull request #9715: create CODE_OF_CONDUCT.md

Posted by GitBox <gi...@apache.org>.

vlasvlasvlas commented on pull request #9715:
URL: https://github.com/apache/airflow/pull/9715#issuecomment-662681122


   ok! thanks :) 
   
   done!
   https://github.com/vlasvlasvlas/airflow/blob/patch-3/CODE_OF_CONDUCT.md
   its now ok? 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk edited a comment on pull request #9715: create CODE_OF_CONDUCT.md

Posted by GitBox <gi...@apache.org>.

potiuk edited a comment on pull request #9715:
URL: https://github.com/apache/airflow/pull/9715#issuecomment-655273339


   cc:  @msumit  @arthur @Fokko @jghoman @aoen @KevinYang21 @alexvanboxel @ashb @aijamalnk @feng-tao @kaxil @bolkedebruin @criccomini  @mistercrunch @hiteshs @saguziel @jgao54 @r39132  @jlowin  @mik-laj @milton0825 @feluelle @BasPH @jmcarp @XD-DENG @patrickleotardif @dimberman @zhongjiajie @houqp @turbaszek   -> we were discussing that we want to add explicit COC indeed. For now we are all bound by the Apache COC http://www.apache.org/foundation/policies/conduct.html  and I was wondering what wording will be best :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #9715: create CODE_OF_CONDUCT.md

Posted by GitBox <gi...@apache.org>.

boring-cyborg[bot] commented on pull request #9715:
URL: https://github.com/apache/airflow/pull/9715#issuecomment-669211720


   Awesome work, congrats on your first merged pull request!
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] vlasvlasvlas edited a comment on pull request #9715: create CODE_OF_CONDUCT.md

Posted by GitBox <gi...@apache.org>.

vlasvlasvlas edited a comment on pull request #9715:
URL: https://github.com/apache/airflow/pull/9715#issuecomment-662681122


   ok! thanks :) 
   
   done!
   https://github.com/vlasvlasvlas/airflow/blob/patch-3/CODE_OF_CONDUCT.md
   its that ok?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org