[jira] [Commented] (HADOOP-11647) Reed-Solomon ErasureCoder

["Uma Maheswara Rao G (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-11647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14357023#comment-14357023 ] 

Uma Maheswara Rao G commented on HADOOP-11647:
----------------------------------------------

Thanks Kai for the patch. I just had a quick look on the patch. Following is my feedback on patch.

{code}
private boolean useXorWhenPossible = true; // Will be configurable
{code}

Seems like you did not load this item from configuration.

{code}
protected ErasureCodingStep performDecoding(final ECBlockGroup blockGroup) {
{code}
I have a question here. Seems like this is not really doing decoding stuff in this API implementation. It is just building ErasureCodingStep object and returning. So, why do we name this API as performDecoding?

useXorWhenPossible: this optimization does not apply for encoding case?

Nit:
{code}
 //Release resources
+    encoder.release();
+    decoder.release();
{code}
May be you can release then and there when encoding/decoding done respectively?
Same comment for TestRawCoderBase

{code}
/**
+ * Test ReedSolomon encoding and decoding.
+ */
{code}
change to Reed-Solomon

> Reed-Solomon ErasureCoder
> -------------------------
>
>                 Key: HADOOP-11647
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11647
>             Project: Hadoop Common
>          Issue Type: Sub-task
>            Reporter: Kai Zheng
>            Assignee: Kai Zheng
>         Attachments: HADOOP-11647-v2.patch, HDFS-7664-v1.patch
>
>
> This is to implement Reed-Solomon ErasureCoder using the API defined in HADOOP-11646. It supports to plugin via configuration for concrete RawErasureCoder, using either JRSErasureCoder added in HDFS-7418 or IsaRSErasureCoder added in HDFS-7338.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)