[jira] [Comment Edited] (MJAVADOC-469) javadoc-plugin does not double backslashes in argument file

["Michael Osipov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MJAVADOC-469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16729208#comment-16729208 ] 

Michael Osipov edited comment on MJAVADOC-469 at 12/26/18 10:58 PM:
--------------------------------------------------------------------

[~tschoening], I have pushed a new branch with a naive implementation. Please test.

The solution will make invalid options truly invalid:

{code}
<additionalOptions>-stylesheetfile ${project.basedir}\nope\stylesheet.css"</additionalOptions>
{code}

must actually be two {{additionalOptions}}, pretty much {{ProcessBuilder}} would expect it.


was (Author: michael-o):
[~tschoening], I have pushed a new branch with a naive implementation. Please test.

> javadoc-plugin does not double backslashes in argument file
> -----------------------------------------------------------
>
>                 Key: MJAVADOC-469
>                 URL: https://issues.apache.org/jira/browse/MJAVADOC-469
>             Project: Maven Javadoc Plugin
>          Issue Type: Bug
>          Components: javadoc
>    Affects Versions: 2.10.4
>            Reporter: Ilya Basin
>            Assignee: Michael Osipov
>            Priority: Major
>
> On Windows `generate-rest-docs` goal of `maven-jira-plugin` calls `maven-javadoc-plugin` with:
>     {code}additionalparam: -output "C:\path\to\target\classes\resourcedoc.xml"{code}
> If this argument was passed to `javadoc.exe` directly, I'm pretty sure this would work. However, the javadoc plugin generates an argument file[1] named "options" and executes:
>     {code}javadoc.exe ... @options{code}
> The file contains all arguments with unescaped backslashes, although javadoc command documentation[2] suggests:
> {quote}If a filename contains embedded spaces, put the whole filename in double quotes, and double each backslash ("My Files\\Stuff.java"){quote}
> javadoc plugin version "2.4" is hardcoded in jira plugin, but I see no related changes in "2.10.4" in AbstractJavadocMojo.addCommandLineOptions() .
>   [1]: https://maven.apache.org/plugins/maven-javadoc-plugin/
>   [2]: http://docs.oracle.com/javase/7/docs/technotes/tools/windows/javadoc.html#argumentfiles



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)