You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by "John Fallows (JIRA)" <ji...@codehaus.org> on 2005/07/19 01:29:57 UTC
[jira] Created: (MNG-609) Filtered resources should support ${pom.*} and ${project.*} syntax only, not ${*}, for POM properties
Filtered resources should support ${pom.*} and ${project.*} syntax only, not ${*}, for POM properties
-----------------------------------------------------------------------------------------------------
Key: MNG-609
URL: http://jira.codehaus.org/browse/MNG-609
Project: Maven 2
Type: Bug
Versions: 2.0-alpha-3
Environment: Maven 2.0-alpha-3, WinXP SP2, Java 1.5.0_02
Reporter: John Fallows
I noticed that the latest code on the trunk adds support for filtered resources, including the ability to refer to pom properties, in addition to any filter properties defined in filter.properties.
For example:
src/main/resources/my-resource.txt
with contents
${version}
It seems that each property of the POM is exposed as an independent top-level variable.
I was expecting the filtered resource file syntax to be...
${project.version}
...since that would be consistent with expressions used in the pom.xml file, such as:
<sourceDirectory>${project.basedir}/src/main/java</sourceDirectory>
This has the added benefit of reduced collision space for top-level variables in filtered resource files.
Recommend that top level variables, such as ${version} are _not_ supported as implicit filter variables, only ${pom} and ${project}.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Updated: (MNG-609) Filtered resources should support ${pom.*} and ${project.*} syntax only, not ${*}, for POM properties
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-609?page=all ]
Brett Porter updated MNG-609:
-----------------------------
Assign To: (was: John Casey)
Remaining Estimate: (was: 3 hours)
Original Estimate: (was: 10800)
> Filtered resources should support ${pom.*} and ${project.*} syntax only, not ${*}, for POM properties
> -----------------------------------------------------------------------------------------------------
>
> Key: MNG-609
> URL: http://jira.codehaus.org/browse/MNG-609
> Project: Maven 2
> Type: Bug
> Versions: 2.0-alpha-3
> Environment: Maven 2.0-alpha-3, WinXP SP2, Java 1.5.0_02
> Reporter: John Fallows
> Fix For: 2.0-beta-1
>
>
> I noticed that the latest code on the trunk adds support for filtered resources, including the ability to refer to pom properties, in addition to any filter properties defined in filter.properties.
> For example:
> src/main/resources/my-resource.txt
> with contents
> ${version}
> It seems that each property of the POM is exposed as an independent top-level variable.
> I was expecting the filtered resource file syntax to be...
> ${project.version}
> ...since that would be consistent with expressions used in the pom.xml file, such as:
> <sourceDirectory>${project.basedir}/src/main/java</sourceDirectory>
> This has the added benefit of reduced collision space for top-level variables in filtered resource files.
> Recommend that top level variables, such as ${version} are _not_ supported as implicit filter variables, only ${pom} and ${project}.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-609) Filtered resources should support ${pom.*} and ${project.*} syntax only, not ${*}, for POM properties
Posted by "John Fallows (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-609?page=comments#action_45958 ]
John Fallows commented on MNG-609:
----------------------------------
In what sense is this a backwards compatibility issue?
I thought that the pom-variables-resolved-during-resource-filtering feature was added to the trunk since the m2 alpha-3 release. Perhaps not.
> Filtered resources should support ${pom.*} and ${project.*} syntax only, not ${*}, for POM properties
> -----------------------------------------------------------------------------------------------------
>
> Key: MNG-609
> URL: http://jira.codehaus.org/browse/MNG-609
> Project: Maven 2
> Type: Bug
> Versions: 2.0-alpha-3
> Environment: Maven 2.0-alpha-3, WinXP SP2, Java 1.5.0_02
> Reporter: John Fallows
> Assignee: Brett Porter
>
>
> I noticed that the latest code on the trunk adds support for filtered resources, including the ability to refer to pom properties, in addition to any filter properties defined in filter.properties.
> For example:
> src/main/resources/my-resource.txt
> with contents
> ${version}
> It seems that each property of the POM is exposed as an independent top-level variable.
> I was expecting the filtered resource file syntax to be...
> ${project.version}
> ...since that would be consistent with expressions used in the pom.xml file, such as:
> <sourceDirectory>${project.basedir}/src/main/java</sourceDirectory>
> This has the added benefit of reduced collision space for top-level variables in filtered resource files.
> Recommend that top level variables, such as ${version} are _not_ supported as implicit filter variables, only ${pom} and ${project}.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Updated: (MNG-609) Filtered resources should support ${pom.*} and ${project.*} syntax only, not ${*}, for POM properties
Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-609?page=all ]
John Casey updated MNG-609:
---------------------------
Complexity: Expert
Remaining Estimate: 3 hours
Original Estimate: 10800
> Filtered resources should support ${pom.*} and ${project.*} syntax only, not ${*}, for POM properties
> -----------------------------------------------------------------------------------------------------
>
> Key: MNG-609
> URL: http://jira.codehaus.org/browse/MNG-609
> Project: Maven 2
> Type: Bug
> Versions: 2.0-alpha-3
> Environment: Maven 2.0-alpha-3, WinXP SP2, Java 1.5.0_02
> Reporter: John Fallows
> Assignee: John Casey
> Fix For: 2.0-beta-1
>
> Original Estimate: 3 hours
> Remaining: 3 hours
>
> I noticed that the latest code on the trunk adds support for filtered resources, including the ability to refer to pom properties, in addition to any filter properties defined in filter.properties.
> For example:
> src/main/resources/my-resource.txt
> with contents
> ${version}
> It seems that each property of the POM is exposed as an independent top-level variable.
> I was expecting the filtered resource file syntax to be...
> ${project.version}
> ...since that would be consistent with expressions used in the pom.xml file, such as:
> <sourceDirectory>${project.basedir}/src/main/java</sourceDirectory>
> This has the added benefit of reduced collision space for top-level variables in filtered resource files.
> Recommend that top level variables, such as ${version} are _not_ supported as implicit filter variables, only ${pom} and ${project}.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Updated: (MNG-609) Filtered resources should support ${pom.*} and ${project.*} syntax only, not ${*}, for POM properties
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-609?page=all ]
Brett Porter updated MNG-609:
-----------------------------
Fix Version: 2.0-beta-1
> Filtered resources should support ${pom.*} and ${project.*} syntax only, not ${*}, for POM properties
> -----------------------------------------------------------------------------------------------------
>
> Key: MNG-609
> URL: http://jira.codehaus.org/browse/MNG-609
> Project: Maven 2
> Type: Bug
> Versions: 2.0-alpha-3
> Environment: Maven 2.0-alpha-3, WinXP SP2, Java 1.5.0_02
> Reporter: John Fallows
> Fix For: 2.0-beta-1
>
>
> I noticed that the latest code on the trunk adds support for filtered resources, including the ability to refer to pom properties, in addition to any filter properties defined in filter.properties.
> For example:
> src/main/resources/my-resource.txt
> with contents
> ${version}
> It seems that each property of the POM is exposed as an independent top-level variable.
> I was expecting the filtered resource file syntax to be...
> ${project.version}
> ...since that would be consistent with expressions used in the pom.xml file, such as:
> <sourceDirectory>${project.basedir}/src/main/java</sourceDirectory>
> This has the added benefit of reduced collision space for top-level variables in filtered resource files.
> Recommend that top level variables, such as ${version} are _not_ supported as implicit filter variables, only ${pom} and ${project}.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Updated: (MNG-609) Filtered resources should support ${pom.*} and ${project.*} syntax only, not ${*}, for POM properties
Posted by "Kenney Westerhof (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-609?page=all ]
Kenney Westerhof updated MNG-609:
---------------------------------
Complexity: Novice (was: Expert)
It's really just a matter of having an if statement in ReflectionProperties.java,
stripping of the leading "project." and returning null otherwise.
I wanted to do this but didn't because it'll break existing builds. Any thoughts on
backwards compatibility or isn't that an issue?
> Filtered resources should support ${pom.*} and ${project.*} syntax only, not ${*}, for POM properties
> -----------------------------------------------------------------------------------------------------
>
> Key: MNG-609
> URL: http://jira.codehaus.org/browse/MNG-609
> Project: Maven 2
> Type: Bug
> Versions: 2.0-alpha-3
> Environment: Maven 2.0-alpha-3, WinXP SP2, Java 1.5.0_02
> Reporter: John Fallows
> Assignee: John Casey
> Fix For: 2.0-beta-1
>
> Original Estimate: 3 hours
> Remaining: 3 hours
>
> I noticed that the latest code on the trunk adds support for filtered resources, including the ability to refer to pom properties, in addition to any filter properties defined in filter.properties.
> For example:
> src/main/resources/my-resource.txt
> with contents
> ${version}
> It seems that each property of the POM is exposed as an independent top-level variable.
> I was expecting the filtered resource file syntax to be...
> ${project.version}
> ...since that would be consistent with expressions used in the pom.xml file, such as:
> <sourceDirectory>${project.basedir}/src/main/java</sourceDirectory>
> This has the added benefit of reduced collision space for top-level variables in filtered resource files.
> Recommend that top level variables, such as ${version} are _not_ supported as implicit filter variables, only ${pom} and ${project}.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Closed: (MNG-609) Filtered resources should support ${pom.*} and ${project.*} syntax only, not ${*}, for POM properties
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-609?page=all ]
Brett Porter closed MNG-609:
----------------------------
Assign To: Brett Porter
Resolution: Won't Fix
Fix Version: (was: 2.0-beta-1)
no, let's retain backwards compat. In the event of a conflict then the properties/tokens should take precedence over the pom variables (which can be filed separately if that is shown not to be the case)
> Filtered resources should support ${pom.*} and ${project.*} syntax only, not ${*}, for POM properties
> -----------------------------------------------------------------------------------------------------
>
> Key: MNG-609
> URL: http://jira.codehaus.org/browse/MNG-609
> Project: Maven 2
> Type: Bug
> Versions: 2.0-alpha-3
> Environment: Maven 2.0-alpha-3, WinXP SP2, Java 1.5.0_02
> Reporter: John Fallows
> Assignee: Brett Porter
>
>
> I noticed that the latest code on the trunk adds support for filtered resources, including the ability to refer to pom properties, in addition to any filter properties defined in filter.properties.
> For example:
> src/main/resources/my-resource.txt
> with contents
> ${version}
> It seems that each property of the POM is exposed as an independent top-level variable.
> I was expecting the filtered resource file syntax to be...
> ${project.version}
> ...since that would be consistent with expressions used in the pom.xml file, such as:
> <sourceDirectory>${project.basedir}/src/main/java</sourceDirectory>
> This has the added benefit of reduced collision space for top-level variables in filtered resource files.
> Recommend that top level variables, such as ${version} are _not_ supported as implicit filter variables, only ${pom} and ${project}.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org