You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by spasam <gi...@git.apache.org> on 2017/06/07 18:37:02 UTC
[GitHub] orc pull request #130: Fix timestamp pattern and added new test
GitHub user spasam opened a pull request:
https://github.com/apache/orc/pull/130
Fix timestamp pattern and added new test
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/spasam/orc master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/orc/pull/130.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #130
----
commit c91c5129e7887c62d4e76fed508e2eb6d624548a
Author: Seshu Pasam <sp...@uptycs.com>
Date: 2017-06-07T18:35:47Z
Fix timestamp pattern and added new test
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] orc pull request #130: ORC-212 ORC-213 Fix timestamp pattern and added new t...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/orc/pull/130
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] orc pull request #130: Fix timestamp pattern and added new test
Posted by spasam <gi...@git.apache.org>.
Github user spasam commented on a diff in the pull request:
https://github.com/apache/orc/pull/130#discussion_r123337668
--- Diff: java/tools/src/java/org/apache/orc/tools/json/JsonSchemaFinder.java ---
@@ -58,7 +58,7 @@
private static final Pattern TIMESTAMP_PATTERN =
Pattern.compile("^[\"]?([0-9]{4}[-/][0-9]{2}[-/][0-9]{2})[T ]" +
"([0-9]{2}:[0-9]{2}:[0-9]{2})" +
- "(([ ][-+]?[0-9]{2}([:][0-9]{2})?)|Z)?[\"]?$");
+ "(([ ]?[-+]?[0-9]{2}([:][0-9]{2})?)|Z)?[\"]?$");
--- End diff --
@omalley Good catch. Let me tweak this!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] orc issue #130: Fix timestamp pattern and added new test
Posted by omalley <gi...@git.apache.org>.
Github user omalley commented on the issue:
https://github.com/apache/orc/pull/130
Can you please create a jira for this issue? Thanks! http://orc.apache.org/bugs
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] orc pull request #130: Fix timestamp pattern and added new test
Posted by omalley <gi...@git.apache.org>.
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/130#discussion_r122857568
--- Diff: java/tools/src/java/org/apache/orc/tools/json/JsonSchemaFinder.java ---
@@ -58,7 +58,7 @@
private static final Pattern TIMESTAMP_PATTERN =
Pattern.compile("^[\"]?([0-9]{4}[-/][0-9]{2}[-/][0-9]{2})[T ]" +
"([0-9]{2}:[0-9]{2}:[0-9]{2})" +
- "(([ ][-+]?[0-9]{2}([:][0-9]{2})?)|Z)?[\"]?$");
+ "(([ ]?[-+]?[0-9]{2}([:][0-9]{2})?)|Z)?[\"]?$");
--- End diff --
I'd propose that this should be "( [-+]?|[-+])" instead of "[ ]?[-+]?". It doesn't seem right to accept
"2016-12-30T12:34:5608"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---