You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/10/24 05:09:22 UTC
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7402: drivers/modem/alt1250: Fix poll function
pkarashchenko commented on code in PR #7402:
URL: https://github.com/apache/incubator-nuttx/pull/7402#discussion_r1002886204
##########
drivers/modem/alt1250/alt1250.c:
##########
@@ -279,6 +279,25 @@ static void write_evtbitmapwithlist(FAR struct alt1250_dev_s *dev,
nxmutex_unlock(&dev->evtmaplock);
}
+/****************************************************************************
+ * Name: is_evtbitmap_avail
+ ****************************************************************************/
+
+static int is_evtbitmap_avail(FAR struct alt1250_dev_s *dev)
Review Comment:
```suggestion
static bool is_evtbitmap_avail(FAR struct alt1250_dev_s *dev)
```
##########
drivers/modem/alt1250/alt1250.c:
##########
@@ -279,6 +279,25 @@ static void write_evtbitmapwithlist(FAR struct alt1250_dev_s *dev,
nxmutex_unlock(&dev->evtmaplock);
}
+/****************************************************************************
+ * Name: is_evtbitmap_avail
+ ****************************************************************************/
+
+static int is_evtbitmap_avail(FAR struct alt1250_dev_s *dev)
+{
+ int ret;
Review Comment:
```suggestion
bool ret;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org