You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "dkrat7 (via GitHub)" <gi...@apache.org> on 2023/04/28 20:38:38 UTC

[GitHub] [superset] dkrat7 opened a new pull request, #23873: chore: Slovenian translation update (2.1.0)

dkrat7 opened a new pull request, #23873:
URL: https://github.com/apache/superset/pull/23873

   ### SUMMARY
   This PR updates the Slovenian translation files:
   - translation strings updated/inserted (new v2.1.0 features are translated)
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   ![Screenshot from 2023-02-25 23-53-18](https://user-images.githubusercontent.com/9586713/221400442-3f752163-8cbb-4ba5-80c2-98dd1003276d.png)
   
   
   ### TESTING INSTRUCTIONS
   Change language settings to Slovenian, check translations.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] dkrat7 commented on a diff in pull request #23873: chore: Slovenian translation update (2.1.0)

Posted by "dkrat7 (via GitHub)" <gi...@apache.org>.
dkrat7 commented on code in PR #23873:
URL: https://github.com/apache/superset/pull/23873#discussion_r1184341549


##########
superset/translations/sl/LC_MESSAGES/messages.json:
##########
@@ -81,75 +111,114 @@
       "(optional) default value for the filter, when using the multiple option, you can use a semicolon-delimited list of options.": [
         "(opcijsko) privzeta vrednost za filter, če uporabite opcijo izbire večih , lahko uporabite seznam nastavitev ločen s podpičji."
       ],
-      "), and they become available in your SQL (example:": [""],
+      "), and they become available in your SQL (example:": [
+        "), s čimer bodo na razpolago v sklopu SQL-poizvedbe (primer:"
+      ],
       "*%(name)s*\n\n%(description)s\n\n<%(url)s|Explore in Superset>\n\n%(table)s\n": [
         "*%(name)s*\n\n%(description)s\n\n<%(url)s|Razišči v Supersetu>\n\n%(table)s\n"
       ],
       "*%(name)s*\n\n%(description)s\n\nError: %(text)s\n": [
         "*%(name)s*\n\n%(description)s\n\nnapaka: %(text)s\n"
       ],
-      "+ %s more": [""],
-      ",": [""],
+      "+ %s more": ["+ %s več"],
+      ",": [","],
       "-- Note: Unless you save your query, these tabs will NOT persist if you clear your cookies or change browsers.\n\n": [
         "-- Opomba: Če ne shranite poizvedbe, se ti zavihki NE bodo ohranili, ko boste počistili piškote ali zamenjali brskalnik.\n\n"
       ],
-      ".": [""],
-      "0 Selected": ["Izbranih: 0"],
-      "1 calendar day frequency": [""],
-      "1 day ago": [""],
+      ".": ["."],
+      "0 Selected": ["0 izbranih"],
+      "1 calendar day frequency": ["frekvenca: 1 koledarski dan"],
+      "1 day": ["1 dan"],
+      "1 day ago": ["1 day ago"],
       "1 hour": ["1 ura"],
+      "1 hourly frequency": ["frekvenca: 1 ura"],
       "1 minute": ["1 minuta"],
-      "1 minutely frequency": [""],
-      "1 month end frequency": [""],
-      "1 month start frequency": [""],
-      "1 week ago": [""],
-      "1 year ago": [""],
-      "10 minute": ["10 minut"],
-      "104 weeks ago": [""],
-      "15 minute": ["15 minut"],
-      "156 weeks ago": [""],
-      "1AS": [""],
-      "1D": [""],
-      "1H": [""],
-      "1M": [""],
-      "1T": [""],
-      "2 years ago": [""],
-      "2/98 percentiles": [""],
-      "28 days ago": [""],
+      "1 minutely frequency": ["frekvenca: 1 minuta"],
+      "1 month end frequency": ["frekvenca: 1 mesec - konec"],
+      "1 month start frequency": ["frekvenca: 1 mesec - začetek"],
+      "1 week": ["1 week"],
+      "1 week ago": ["1 week ago"],
+      "1 week starting Monday (freq=W-MON)": [
+        "1 teden z začetkom v ponedeljek (freq=W-MON)"
+      ],
+      "1 week starting Sunday (freq=W-SUN)": [
+        "1 teden z začetkom v nedeljo (freq=W-SUN)"
+      ],
+      "1 year": ["1 year"],
+      "1 year ago": ["1 year ago"],
+      "1 year end frequency": ["frekvenca: 1 leto - konec"],
+      "1 year start frequency": ["frekvenca: 1 leto - začetek"],
+      "10 minute": ["10 minute"],
+      "104 weeks": ["104 weeks"],
+      "104 weeks ago": ["104 weeks ago"],
+      "15 minute": ["15 minute"],
+      "156 weeks": ["156 weeks"],
+      "156 weeks ago": ["156 weeks ago"],
+      "1AS": ["1AS"],
+      "1D": ["1D"],
+      "1H": ["1H"],
+      "1M": ["1M"],
+      "1T": ["1T"],
+      "2 years": ["2 years"],
+      "2 years ago": ["2 years ago"],
+      "2/98 percentiles": ["2/98 percentil"],
+      "28 days": ["28 days"],
+      "28 days ago": ["28 days ago"],
       "2D": ["2D"],
       "3 letter code of the country": ["Tričrkovna oznaka države"],
-      "3 years ago": [""],
+      "3 years": ["3 years"],
+      "3 years ago": ["3 years ago"],
       "30 days": ["30 dni"],
+      "30 days ago": ["30 days ago"],
       "30 minute": ["30 minut"],
-      "30 minutes": ["30 minut"],
-      "30 second": ["30 sekund"],
-      "30 seconds": ["30 sekund"],
+      "30 minutes": ["30 minutes"],
+      "30 second": ["30 second"],
+      "30 seconds": ["30 seconds"],
       "3D": ["3D"],
-      "4 weeks (freq=4W-MON)": [""],
-      "5 minute": ["5 minut"],
-      "5 minutes": ["5 minut"],
-      "5 second": ["5 sekund"],
-      "52 weeks ago": [""],
-      "6 hour": ["6 ur"],
-      "60 days": ["60 dni"],
-      "7 calendar day frequency": [""],
-      "7D": [""],
-      "9/91 percentiles": [""],
-      "90 days": ["90 dni"],
+      "4 weeks (freq=4W-MON)": ["4 tedni (freq=4W-MON)"],
+      "5 minute": ["5 minute"],
+      "5 minutes": ["5 minutes"],
+      "5 second": ["5 second"],
+      "5 seconds": ["5 seconds"],

Review Comment:
   Correct me if I'm wrong, but these are mostly time deltas for chart Advanced analytics which supports natural language (ISO 8601 durations) and time filter granularities which support natural language also.
   
   I thought it would be confusing for users if these are translated, because natural language input has to be in English and these strings also serve as input examples. That's is why I translated those back in English (I didn't want to leave the fields empty because in the future I (or somebody else) could forget about this and translate it.
   
   (Maybe I made some mistakes also. Sometimes it is hard to find translation string context, there are almost 4 thousand strings)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] dkrat7 commented on pull request #23873: chore: Slovenian translation update

Posted by "dkrat7 (via GitHub)" <gi...@apache.org>.
dkrat7 commented on PR #23873:
URL: https://github.com/apache/superset/pull/23873#issuecomment-1656870144

   I updated translations with the latest master. Is there any chance this PR is merged?
   If there are any technical issues left I can try to fix them.
   I suppose another problem is lack of reviewers familiar with the Slovenian language in the Superset team.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] chore: Slovenian translation update [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #23873:
URL: https://github.com/apache/superset/pull/23873


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] commented on pull request #23873: chore: Slovenian translation update (2.1.0)

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #23873:
URL: https://github.com/apache/superset/pull/23873#issuecomment-1528078559

   ## [Codecov](https://codecov.io/gh/apache/superset/pull/23873?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#23873](https://codecov.io/gh/apache/superset/pull/23873?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (670bb25) into [master](https://codecov.io/gh/apache/superset/commit/594d3e0e0c4add06c1216490c63cdc6ac43e2f5a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (594d3e0) will **decrease** coverage by `11.25%`.
   > The diff coverage is `n/a`.
   
   > :exclamation: Current head 670bb25 differs from pull request most recent head e515c49. Consider uploading reports for the commit e515c49 to get more accurate results
   
   ```diff
   @@             Coverage Diff             @@
   ##           master   #23873       +/-   ##
   ===========================================
   - Coverage   68.11%   56.86%   -11.25%     
   ===========================================
     Files        1938     1938               
     Lines       74972    74972               
     Branches     8141     8141               
   ===========================================
   - Hits        51067    42633     -8434     
   - Misses      21826    30260     +8434     
     Partials     2079     2079               
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | hive | `53.01% <ø> (ø)` | |
   | mysql | `?` | |
   | postgres | `?` | |
   | presto | `52.93% <ø> (ø)` | |
   | python | `59.41% <ø> (-23.26%)` | :arrow_down: |
   | sqlite | `?` | |
   | unit | `52.81% <ø> (ø)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   [see 307 files with indirect coverage changes](https://codecov.io/gh/apache/superset/pull/23873/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] dkrat7 commented on a diff in pull request #23873: chore: Slovenian translation update (2.1.0)

Posted by "dkrat7 (via GitHub)" <gi...@apache.org>.
dkrat7 commented on code in PR #23873:
URL: https://github.com/apache/superset/pull/23873#discussion_r1184349629


##########
superset/translations/sl/LC_MESSAGES/messages.json:
##########
@@ -81,75 +111,114 @@
       "(optional) default value for the filter, when using the multiple option, you can use a semicolon-delimited list of options.": [
         "(opcijsko) privzeta vrednost za filter, če uporabite opcijo izbire večih , lahko uporabite seznam nastavitev ločen s podpičji."
       ],
-      "), and they become available in your SQL (example:": [""],
+      "), and they become available in your SQL (example:": [
+        "), s čimer bodo na razpolago v sklopu SQL-poizvedbe (primer:"
+      ],
       "*%(name)s*\n\n%(description)s\n\n<%(url)s|Explore in Superset>\n\n%(table)s\n": [
         "*%(name)s*\n\n%(description)s\n\n<%(url)s|Razišči v Supersetu>\n\n%(table)s\n"
       ],
       "*%(name)s*\n\n%(description)s\n\nError: %(text)s\n": [
         "*%(name)s*\n\n%(description)s\n\nnapaka: %(text)s\n"
       ],
-      "+ %s more": [""],
-      ",": [""],
+      "+ %s more": ["+ %s več"],
+      ",": [","],
       "-- Note: Unless you save your query, these tabs will NOT persist if you clear your cookies or change browsers.\n\n": [
         "-- Opomba: Če ne shranite poizvedbe, se ti zavihki NE bodo ohranili, ko boste počistili piškote ali zamenjali brskalnik.\n\n"
       ],
-      ".": [""],
-      "0 Selected": ["Izbranih: 0"],
-      "1 calendar day frequency": [""],
-      "1 day ago": [""],
+      ".": ["."],
+      "0 Selected": ["0 izbranih"],
+      "1 calendar day frequency": ["frekvenca: 1 koledarski dan"],
+      "1 day": ["1 dan"],
+      "1 day ago": ["1 day ago"],
       "1 hour": ["1 ura"],
+      "1 hourly frequency": ["frekvenca: 1 ura"],
       "1 minute": ["1 minuta"],
-      "1 minutely frequency": [""],
-      "1 month end frequency": [""],
-      "1 month start frequency": [""],
-      "1 week ago": [""],
-      "1 year ago": [""],
-      "10 minute": ["10 minut"],
-      "104 weeks ago": [""],
-      "15 minute": ["15 minut"],
-      "156 weeks ago": [""],
-      "1AS": [""],
-      "1D": [""],
-      "1H": [""],
-      "1M": [""],
-      "1T": [""],
-      "2 years ago": [""],
-      "2/98 percentiles": [""],
-      "28 days ago": [""],
+      "1 minutely frequency": ["frekvenca: 1 minuta"],
+      "1 month end frequency": ["frekvenca: 1 mesec - konec"],
+      "1 month start frequency": ["frekvenca: 1 mesec - začetek"],
+      "1 week": ["1 week"],
+      "1 week ago": ["1 week ago"],
+      "1 week starting Monday (freq=W-MON)": [
+        "1 teden z začetkom v ponedeljek (freq=W-MON)"
+      ],
+      "1 week starting Sunday (freq=W-SUN)": [
+        "1 teden z začetkom v nedeljo (freq=W-SUN)"
+      ],
+      "1 year": ["1 year"],
+      "1 year ago": ["1 year ago"],
+      "1 year end frequency": ["frekvenca: 1 leto - konec"],
+      "1 year start frequency": ["frekvenca: 1 leto - začetek"],
+      "10 minute": ["10 minute"],
+      "104 weeks": ["104 weeks"],
+      "104 weeks ago": ["104 weeks ago"],
+      "15 minute": ["15 minute"],
+      "156 weeks": ["156 weeks"],
+      "156 weeks ago": ["156 weeks ago"],
+      "1AS": ["1AS"],
+      "1D": ["1D"],
+      "1H": ["1H"],
+      "1M": ["1M"],
+      "1T": ["1T"],
+      "2 years": ["2 years"],
+      "2 years ago": ["2 years ago"],
+      "2/98 percentiles": ["2/98 percentil"],
+      "28 days": ["28 days"],
+      "28 days ago": ["28 days ago"],
       "2D": ["2D"],
       "3 letter code of the country": ["Tričrkovna oznaka države"],
-      "3 years ago": [""],
+      "3 years": ["3 years"],
+      "3 years ago": ["3 years ago"],
       "30 days": ["30 dni"],
+      "30 days ago": ["30 days ago"],
       "30 minute": ["30 minut"],
-      "30 minutes": ["30 minut"],
-      "30 second": ["30 sekund"],
-      "30 seconds": ["30 sekund"],
+      "30 minutes": ["30 minutes"],
+      "30 second": ["30 second"],
+      "30 seconds": ["30 seconds"],
       "3D": ["3D"],
-      "4 weeks (freq=4W-MON)": [""],
-      "5 minute": ["5 minut"],
-      "5 minutes": ["5 minut"],
-      "5 second": ["5 sekund"],
-      "52 weeks ago": [""],
-      "6 hour": ["6 ur"],
-      "60 days": ["60 dni"],
-      "7 calendar day frequency": [""],
-      "7D": [""],
-      "9/91 percentiles": [""],
-      "90 days": ["90 dni"],
+      "4 weeks (freq=4W-MON)": ["4 tedni (freq=4W-MON)"],
+      "5 minute": ["5 minute"],
+      "5 minutes": ["5 minutes"],
+      "5 second": ["5 second"],
+      "5 seconds": ["5 seconds"],

Review Comment:
   ![Screenshot from 2023-05-04 00-15-13](https://user-images.githubusercontent.com/9586713/236061826-2bb3b457-744f-4108-8bae-be0d6ceb5943.png)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] dkrat7 commented on a diff in pull request #23873: chore: Slovenian translation update (2.1.0)

Posted by "dkrat7 (via GitHub)" <gi...@apache.org>.
dkrat7 commented on code in PR #23873:
URL: https://github.com/apache/superset/pull/23873#discussion_r1184341549


##########
superset/translations/sl/LC_MESSAGES/messages.json:
##########
@@ -81,75 +111,114 @@
       "(optional) default value for the filter, when using the multiple option, you can use a semicolon-delimited list of options.": [
         "(opcijsko) privzeta vrednost za filter, če uporabite opcijo izbire večih , lahko uporabite seznam nastavitev ločen s podpičji."
       ],
-      "), and they become available in your SQL (example:": [""],
+      "), and they become available in your SQL (example:": [
+        "), s čimer bodo na razpolago v sklopu SQL-poizvedbe (primer:"
+      ],
       "*%(name)s*\n\n%(description)s\n\n<%(url)s|Explore in Superset>\n\n%(table)s\n": [
         "*%(name)s*\n\n%(description)s\n\n<%(url)s|Razišči v Supersetu>\n\n%(table)s\n"
       ],
       "*%(name)s*\n\n%(description)s\n\nError: %(text)s\n": [
         "*%(name)s*\n\n%(description)s\n\nnapaka: %(text)s\n"
       ],
-      "+ %s more": [""],
-      ",": [""],
+      "+ %s more": ["+ %s več"],
+      ",": [","],
       "-- Note: Unless you save your query, these tabs will NOT persist if you clear your cookies or change browsers.\n\n": [
         "-- Opomba: Če ne shranite poizvedbe, se ti zavihki NE bodo ohranili, ko boste počistili piškote ali zamenjali brskalnik.\n\n"
       ],
-      ".": [""],
-      "0 Selected": ["Izbranih: 0"],
-      "1 calendar day frequency": [""],
-      "1 day ago": [""],
+      ".": ["."],
+      "0 Selected": ["0 izbranih"],
+      "1 calendar day frequency": ["frekvenca: 1 koledarski dan"],
+      "1 day": ["1 dan"],
+      "1 day ago": ["1 day ago"],
       "1 hour": ["1 ura"],
+      "1 hourly frequency": ["frekvenca: 1 ura"],
       "1 minute": ["1 minuta"],
-      "1 minutely frequency": [""],
-      "1 month end frequency": [""],
-      "1 month start frequency": [""],
-      "1 week ago": [""],
-      "1 year ago": [""],
-      "10 minute": ["10 minut"],
-      "104 weeks ago": [""],
-      "15 minute": ["15 minut"],
-      "156 weeks ago": [""],
-      "1AS": [""],
-      "1D": [""],
-      "1H": [""],
-      "1M": [""],
-      "1T": [""],
-      "2 years ago": [""],
-      "2/98 percentiles": [""],
-      "28 days ago": [""],
+      "1 minutely frequency": ["frekvenca: 1 minuta"],
+      "1 month end frequency": ["frekvenca: 1 mesec - konec"],
+      "1 month start frequency": ["frekvenca: 1 mesec - začetek"],
+      "1 week": ["1 week"],
+      "1 week ago": ["1 week ago"],
+      "1 week starting Monday (freq=W-MON)": [
+        "1 teden z začetkom v ponedeljek (freq=W-MON)"
+      ],
+      "1 week starting Sunday (freq=W-SUN)": [
+        "1 teden z začetkom v nedeljo (freq=W-SUN)"
+      ],
+      "1 year": ["1 year"],
+      "1 year ago": ["1 year ago"],
+      "1 year end frequency": ["frekvenca: 1 leto - konec"],
+      "1 year start frequency": ["frekvenca: 1 leto - začetek"],
+      "10 minute": ["10 minute"],
+      "104 weeks": ["104 weeks"],
+      "104 weeks ago": ["104 weeks ago"],
+      "15 minute": ["15 minute"],
+      "156 weeks": ["156 weeks"],
+      "156 weeks ago": ["156 weeks ago"],
+      "1AS": ["1AS"],
+      "1D": ["1D"],
+      "1H": ["1H"],
+      "1M": ["1M"],
+      "1T": ["1T"],
+      "2 years": ["2 years"],
+      "2 years ago": ["2 years ago"],
+      "2/98 percentiles": ["2/98 percentil"],
+      "28 days": ["28 days"],
+      "28 days ago": ["28 days ago"],
       "2D": ["2D"],
       "3 letter code of the country": ["Tričrkovna oznaka države"],
-      "3 years ago": [""],
+      "3 years": ["3 years"],
+      "3 years ago": ["3 years ago"],
       "30 days": ["30 dni"],
+      "30 days ago": ["30 days ago"],
       "30 minute": ["30 minut"],
-      "30 minutes": ["30 minut"],
-      "30 second": ["30 sekund"],
-      "30 seconds": ["30 sekund"],
+      "30 minutes": ["30 minutes"],
+      "30 second": ["30 second"],
+      "30 seconds": ["30 seconds"],
       "3D": ["3D"],
-      "4 weeks (freq=4W-MON)": [""],
-      "5 minute": ["5 minut"],
-      "5 minutes": ["5 minut"],
-      "5 second": ["5 sekund"],
-      "52 weeks ago": [""],
-      "6 hour": ["6 ur"],
-      "60 days": ["60 dni"],
-      "7 calendar day frequency": [""],
-      "7D": [""],
-      "9/91 percentiles": [""],
-      "90 days": ["90 dni"],
+      "4 weeks (freq=4W-MON)": ["4 tedni (freq=4W-MON)"],
+      "5 minute": ["5 minute"],
+      "5 minutes": ["5 minutes"],
+      "5 second": ["5 second"],
+      "5 seconds": ["5 seconds"],

Review Comment:
   Correct me if I'm wrong, but these are mostly time deltas for chart Advanced analytics which supports natural language (ISO 8601 durations) and time filter granularities which support natural language also.
   
   I thought it would be confusing for users if these are translated, because natural language input has to be in English and these strings also serve as input examples. That's why I left those in English.
   
   (Maybe I made some mistakes also. Sometimes it is hard to find translation string context, there are almost 4 thousand strings)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] rusackas commented on a diff in pull request #23873: chore: Slovenian translation update (2.1.0)

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on code in PR #23873:
URL: https://github.com/apache/superset/pull/23873#discussion_r1184126757


##########
superset/translations/sl/LC_MESSAGES/messages.json:
##########
@@ -81,75 +111,114 @@
       "(optional) default value for the filter, when using the multiple option, you can use a semicolon-delimited list of options.": [
         "(opcijsko) privzeta vrednost za filter, če uporabite opcijo izbire večih , lahko uporabite seznam nastavitev ločen s podpičji."
       ],
-      "), and they become available in your SQL (example:": [""],
+      "), and they become available in your SQL (example:": [
+        "), s čimer bodo na razpolago v sklopu SQL-poizvedbe (primer:"
+      ],
       "*%(name)s*\n\n%(description)s\n\n<%(url)s|Explore in Superset>\n\n%(table)s\n": [
         "*%(name)s*\n\n%(description)s\n\n<%(url)s|Razišči v Supersetu>\n\n%(table)s\n"
       ],
       "*%(name)s*\n\n%(description)s\n\nError: %(text)s\n": [
         "*%(name)s*\n\n%(description)s\n\nnapaka: %(text)s\n"
       ],
-      "+ %s more": [""],
-      ",": [""],
+      "+ %s more": ["+ %s več"],
+      ",": [","],
       "-- Note: Unless you save your query, these tabs will NOT persist if you clear your cookies or change browsers.\n\n": [
         "-- Opomba: Če ne shranite poizvedbe, se ti zavihki NE bodo ohranili, ko boste počistili piškote ali zamenjali brskalnik.\n\n"
       ],
-      ".": [""],
-      "0 Selected": ["Izbranih: 0"],
-      "1 calendar day frequency": [""],
-      "1 day ago": [""],
+      ".": ["."],
+      "0 Selected": ["0 izbranih"],
+      "1 calendar day frequency": ["frekvenca: 1 koledarski dan"],
+      "1 day": ["1 dan"],
+      "1 day ago": ["1 day ago"],
       "1 hour": ["1 ura"],
+      "1 hourly frequency": ["frekvenca: 1 ura"],
       "1 minute": ["1 minuta"],
-      "1 minutely frequency": [""],
-      "1 month end frequency": [""],
-      "1 month start frequency": [""],
-      "1 week ago": [""],
-      "1 year ago": [""],
-      "10 minute": ["10 minut"],
-      "104 weeks ago": [""],
-      "15 minute": ["15 minut"],
-      "156 weeks ago": [""],
-      "1AS": [""],
-      "1D": [""],
-      "1H": [""],
-      "1M": [""],
-      "1T": [""],
-      "2 years ago": [""],
-      "2/98 percentiles": [""],
-      "28 days ago": [""],
+      "1 minutely frequency": ["frekvenca: 1 minuta"],
+      "1 month end frequency": ["frekvenca: 1 mesec - konec"],
+      "1 month start frequency": ["frekvenca: 1 mesec - začetek"],
+      "1 week": ["1 week"],
+      "1 week ago": ["1 week ago"],
+      "1 week starting Monday (freq=W-MON)": [
+        "1 teden z začetkom v ponedeljek (freq=W-MON)"
+      ],
+      "1 week starting Sunday (freq=W-SUN)": [
+        "1 teden z začetkom v nedeljo (freq=W-SUN)"
+      ],
+      "1 year": ["1 year"],
+      "1 year ago": ["1 year ago"],
+      "1 year end frequency": ["frekvenca: 1 leto - konec"],
+      "1 year start frequency": ["frekvenca: 1 leto - začetek"],
+      "10 minute": ["10 minute"],
+      "104 weeks": ["104 weeks"],
+      "104 weeks ago": ["104 weeks ago"],
+      "15 minute": ["15 minute"],
+      "156 weeks": ["156 weeks"],
+      "156 weeks ago": ["156 weeks ago"],
+      "1AS": ["1AS"],
+      "1D": ["1D"],
+      "1H": ["1H"],
+      "1M": ["1M"],
+      "1T": ["1T"],
+      "2 years": ["2 years"],
+      "2 years ago": ["2 years ago"],
+      "2/98 percentiles": ["2/98 percentil"],
+      "28 days": ["28 days"],
+      "28 days ago": ["28 days ago"],
       "2D": ["2D"],
       "3 letter code of the country": ["Tričrkovna oznaka države"],
-      "3 years ago": [""],
+      "3 years": ["3 years"],
+      "3 years ago": ["3 years ago"],
       "30 days": ["30 dni"],
+      "30 days ago": ["30 days ago"],
       "30 minute": ["30 minut"],
-      "30 minutes": ["30 minut"],
-      "30 second": ["30 sekund"],
-      "30 seconds": ["30 sekund"],
+      "30 minutes": ["30 minutes"],
+      "30 second": ["30 second"],
+      "30 seconds": ["30 seconds"],
       "3D": ["3D"],
-      "4 weeks (freq=4W-MON)": [""],
-      "5 minute": ["5 minut"],
-      "5 minutes": ["5 minut"],
-      "5 second": ["5 sekund"],
-      "52 weeks ago": [""],
-      "6 hour": ["6 ur"],
-      "60 days": ["60 dni"],
-      "7 calendar day frequency": [""],
-      "7D": [""],
-      "9/91 percentiles": [""],
-      "90 days": ["90 dni"],
+      "4 weeks (freq=4W-MON)": ["4 tedni (freq=4W-MON)"],
+      "5 minute": ["5 minute"],
+      "5 minutes": ["5 minutes"],
+      "5 second": ["5 second"],
+      "5 seconds": ["5 seconds"],

Review Comment:
   Why do so many strings in this PR seem like they're being translated back into English?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] chore: Slovenian translation update [superset]

Posted by "dkrat7 (via GitHub)" <gi...@apache.org>.
dkrat7 closed pull request #23873: chore: Slovenian translation update
URL: https://github.com/apache/superset/pull/23873


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org